src/java.base/share/classes/sun/net/ftp/impl/FtpClient.java

rev 51919 : 8215281: Use String.isEmpty() when applicable in java.base
Reviewed-by: dfuchs, alanb

*** 431,441 ****
              replyBuf.setLength(0);
              if (logger.isLoggable(PlatformLogger.Level.FINEST)) {
                  logger.finest("Server [" + serverAddr + "] --> " + response);
              }
  
!             if (response.length() == 0) {
                  code = -1;
              } else {
                  try {
                      code = Integer.parseInt(response, 0, 3, 10);
                  } catch (NumberFormatException e) {
--- 431,441 ----
              replyBuf.setLength(0);
              if (logger.isLoggable(PlatformLogger.Level.FINEST)) {
                  logger.finest("Server [" + serverAddr + "] --> " + response);
              }
  
!             if (response.isEmpty()) {
                  code = -1;
              } else {
                  try {
                      code = Integer.parseInt(response, 0, 3, 10);
                  } catch (NumberFormatException e) {
*** 1047,1057 ****
       */
      public sun.net.ftp.FtpClient login(String user, char[] password) throws sun.net.ftp.FtpProtocolException, IOException {
          if (!isConnected()) {
              throw new sun.net.ftp.FtpProtocolException("Not connected yet", FtpReplyCode.BAD_SEQUENCE);
          }
!         if (user == null || user.length() == 0) {
              throw new IllegalArgumentException("User name can't be null or empty");
          }
          tryLogin(user, password);
  
          // keep the welcome message around so we can
--- 1047,1057 ----
       */
      public sun.net.ftp.FtpClient login(String user, char[] password) throws sun.net.ftp.FtpProtocolException, IOException {
          if (!isConnected()) {
              throw new sun.net.ftp.FtpProtocolException("Not connected yet", FtpReplyCode.BAD_SEQUENCE);
          }
!         if (user == null || user.isEmpty()) {
              throw new IllegalArgumentException("User name can't be null or empty");
          }
          tryLogin(user, password);
  
          // keep the welcome message around so we can
*** 1086,1096 ****
      public sun.net.ftp.FtpClient login(String user, char[] password, String account) throws sun.net.ftp.FtpProtocolException, IOException {
  
          if (!isConnected()) {
              throw new sun.net.ftp.FtpProtocolException("Not connected yet", FtpReplyCode.BAD_SEQUENCE);
          }
!         if (user == null || user.length() == 0) {
              throw new IllegalArgumentException("User name can't be null or empty");
          }
          tryLogin(user, password);
  
          /*
--- 1086,1096 ----
      public sun.net.ftp.FtpClient login(String user, char[] password, String account) throws sun.net.ftp.FtpProtocolException, IOException {
  
          if (!isConnected()) {
              throw new sun.net.ftp.FtpProtocolException("Not connected yet", FtpReplyCode.BAD_SEQUENCE);
          }
!         if (user == null || user.isEmpty()) {
              throw new IllegalArgumentException("User name can't be null or empty");
          }
          tryLogin(user, password);
  
          /*
*** 1150,1160 ****
       * @param remoteDirectory path of the directory to CD to.
       * @return <code>true</code> if the operation was successful.
       * @exception <code>FtpProtocolException</code>
       */
      public sun.net.ftp.FtpClient changeDirectory(String remoteDirectory) throws sun.net.ftp.FtpProtocolException, IOException {
!         if (remoteDirectory == null || "".equals(remoteDirectory)) {
              throw new IllegalArgumentException("directory can't be null or empty");
          }
  
          issueCommandCheck("CWD " + remoteDirectory);
          return this;
--- 1150,1160 ----
       * @param remoteDirectory path of the directory to CD to.
       * @return <code>true</code> if the operation was successful.
       * @exception <code>FtpProtocolException</code>
       */
      public sun.net.ftp.FtpClient changeDirectory(String remoteDirectory) throws sun.net.ftp.FtpProtocolException, IOException {
!         if (remoteDirectory == null || remoteDirectory.isEmpty()) {
              throw new IllegalArgumentException("directory can't be null or empty");
          }
  
          issueCommandCheck("CWD " + remoteDirectory);
          return this;
*** 1736,1746 ****
       *         the server returned an error, which can be checked with
       *         {@link #getLastReplyCode()}.
       * @throws IOException if an error occurs during the transmission.
       */
      public long getSize(String path) throws sun.net.ftp.FtpProtocolException, IOException {
!         if (path == null || path.length() == 0) {
              throw new IllegalArgumentException("path can't be null or empty");
          }
          issueCommandCheck("SIZE " + path);
          if (lastReplyCode == FtpReplyCode.FILE_STATUS) {
              String s = getResponseString();
--- 1736,1746 ----
       *         the server returned an error, which can be checked with
       *         {@link #getLastReplyCode()}.
       * @throws IOException if an error occurs during the transmission.
       */
      public long getSize(String path) throws sun.net.ftp.FtpProtocolException, IOException {
!         if (path == null || path.isEmpty()) {
              throw new IllegalArgumentException("path can't be null or empty");
          }
          issueCommandCheck("SIZE " + path);
          if (lastReplyCode == FtpReplyCode.FILE_STATUS) {
              String s = getResponseString();