< prev index next >
src/java.base/share/classes/sun/util/locale/InternalLocaleBuilder.java
Print this page
rev 51919 : 8215281: Use String.isEmpty() when applicable in java.base
Reviewed-by: dfuchs, alanb
@@ -329,11 +329,11 @@
}
}
done.add(key);
}
}
- if (privateuse != null && privateuse.length() > 0) {
+ if (privateuse != null && !privateuse.isEmpty()) {
// privateuse string contains prefix, e.g. "x-abc-def"
if (extensions == null) {
extensions = new HashMap<>(1);
}
extensions.put(new CaseInsensitiveChar(privateuse), privateuse.substring(2));
@@ -404,23 +404,23 @@
}
// Validate base locale fields before updating internal state.
// LocaleExtensions always store validated/canonicalized values,
// so no checks are necessary.
- if (language.length() > 0 && !LanguageTag.isLanguage(language)) {
+ if (!language.isEmpty() && !LanguageTag.isLanguage(language)) {
throw new LocaleSyntaxException("Ill-formed language: " + language);
}
- if (script.length() > 0 && !LanguageTag.isScript(script)) {
+ if (!script.isEmpty() && !LanguageTag.isScript(script)) {
throw new LocaleSyntaxException("Ill-formed script: " + script);
}
- if (region.length() > 0 && !LanguageTag.isRegion(region)) {
+ if (!region.isEmpty() && !LanguageTag.isRegion(region)) {
throw new LocaleSyntaxException("Ill-formed region: " + region);
}
- if (variant.length() > 0) {
+ if (!variant.isEmpty()) {
int errIdx = checkVariants(variant, BaseLocale.SEP);
if (errIdx != -1) {
throw new LocaleSyntaxException("Ill-formed variant: " + variant, errIdx);
}
}
< prev index next >