Code Review for jdk

Prepared by:clanger on Tue Apr 21 09:45:31 CEST 2020
Workspace:/priv/d062122/mercurial/jdk
Compare against: http://hg.openjdk.java.net/jdk/jdk/
Compare against version:58909
Summary of changes: 222 lines changed: 25 ins; 148 del; 49 mod; 9918 unchg
Patch of changes: jdk.patch
Bug id: JDK-8243117 : Cleanups in Java code of module jdk.jlink
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java

rev 58910 : Cleanups in Java code of module jdk.jlink
2 lines changed: 0 ins; 1 del; 1 mod; 458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java

rev 58910 : Cleanups in Java code of module jdk.jlink
25 lines changed: 4 ins; 19 del; 2 mod; 574 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/BasicImageWriter.java

rev 58910 : Cleanups in Java code of module jdk.jlink
3 lines changed: 0 ins; 2 del; 1 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/DirArchive.java

rev 58910 : Cleanups in Java code of module jdk.jlink
3 lines changed: 0 ins; 2 del; 1 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginConfiguration.java

rev 58910 : Cleanups in Java code of module jdk.jlink
5 lines changed: 1 ins; 2 del; 2 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java

rev 58910 : Cleanups in Java code of module jdk.jlink
16 lines changed: 1 ins; 12 del; 3 mod; 489 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Jlink.java

rev 58910 : Cleanups in Java code of module jdk.jlink
5 lines changed: 0 ins; 3 del; 2 mod; 315 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java

rev 58910 : Cleanups in Java code of module jdk.jlink
32 lines changed: 0 ins; 31 del; 1 mod; 832 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Main.java

rev 58910 : Cleanups in Java code of module jdk.jlink
3 lines changed: 2 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModularJarArchive.java

rev 58910 : Cleanups in Java code of module jdk.jlink
2 lines changed: 0 ins; 1 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PluginRepository.java

rev 58910 : Cleanups in Java code of module jdk.jlink
1 line changed: 0 ins; 1 del; 0 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolConfiguration.java

rev 58910 : Cleanups in Java code of module jdk.jlink
7 lines changed: 0 ins; 5 del; 2 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java

rev 58910 : Cleanups in Java code of module jdk.jlink
24 lines changed: 1 ins; 18 del; 5 mod; 724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Utils.java

rev 58910 : Cleanups in Java code of module jdk.jlink
3 lines changed: 1 ins; 1 del; 1 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/AddOptionsPlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
8 lines changed: 0 ins; 7 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/AddResourcePlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
9 lines changed: 2 ins; 0 del; 7 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeJmodSectionPlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
2 lines changed: 0 ins; 1 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeVMPlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
5 lines changed: 1 ins; 2 del; 2 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/GenerateJLIClassesPlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
6 lines changed: 1 ins; 1 del; 4 mod; 482 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/IncludeLocalesPlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
2 lines changed: 0 ins; 1 del; 1 mod; 421 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/OrderResourcesPlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
6 lines changed: 2 ins; 2 del; 2 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
3 lines changed: 2 ins; 0 del; 1 mod; 1897 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/Plugin.java

rev 58910 : Cleanups in Java code of module jdk.jlink
3 lines changed: 1 ins; 1 del; 1 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/ResourcePool.java

rev 58910 : Cleanups in Java code of module jdk.jlink
2 lines changed: 0 ins; 1 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/ResourcePoolBuilder.java

rev 58910 : Cleanups in Java code of module jdk.jlink
7 lines changed: 0 ins; 6 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/ResourcePoolModule.java

rev 58910 : Cleanups in Java code of module jdk.jlink
2 lines changed: 0 ins; 1 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java

rev 58910 : Cleanups in Java code of module jdk.jlink
33 lines changed: 4 ins; 27 del; 2 mod; 1542 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/Main.java

rev 58910 : Cleanups in Java code of module jdk.jlink
3 lines changed: 2 ins; 0 del; 1 mod; 60 unchg

This code review page was prepared using /priv/d062122/mercurial/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).