Code Review for jdk

Prepared by:coffeys on Fri Aug 22 16:13:07 IST 2014
Workspace:/home/scoffey/jdk7u-dev/jdk
Compare against: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk
Compare against version:7397
Summary of changes: 2085 lines changed: 2039 ins; 18 del; 28 mod; 13238 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/Makefile

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
2 lines changed: 0 ins; 0 del; 2 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/shared/Defs-javadoc.gmk

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
1 line changed: 1 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/docs/Makefile

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
51 lines changed: 50 ins; 0 del; 1 mod; 1229 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/docs/NON_CORE_PKGS.gmk

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
3 lines changed: 3 ins; 0 del; 0 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/java/net/FILES_c.gmk

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
1 line changed: 1 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/java/net/mapfile-vers

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
5 lines changed: 4 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/sun/net/FILES_java.gmk

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
1 line changed: 1 ins; 0 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/net/DatagramSocket.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
1 line changed: 1 ins; 0 del; 0 mod; 1268 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/net/DatagramSocketImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
64 lines changed: 64 ins; 0 del; 0 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/net/SocketImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
40 lines changed: 40 ins; 0 del; 0 mod; 357 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/net/SocksProxy.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
4 lines changed: 4 ins; 0 del; 0 mod; 601 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/nio/ch/DatagramChannelImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
23 lines changed: 4 ins; 15 del; 4 mod; 1104 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/nio/ch/Net.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
25 lines changed: 23 ins; 0 del; 2 mod; 614 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
9 lines changed: 9 ins; 0 del; 0 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/nio/ch/SocketChannelImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
14 lines changed: 6 ins; 1 del; 7 mod; 1032 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/java/net/net_util.h

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
1 line changed: 0 ins; 0 del; 1 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/nio/ch/genSocketOptionRegistry.c

rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
1 line changed: 1 ins; 0 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/solaris/classes/java/net/PlainDatagramSocketImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
31 lines changed: 31 ins; 0 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/solaris/classes/java/net/PlainSocketImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
33 lines changed: 32 ins; 1 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/solaris/native/java/net/net_util_md.c

rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
5 lines changed: 2 ins; 0 del; 3 mod; 1691 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/solaris/native/java/net/net_util_md.h

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
41 lines changed: 40 ins; 1 del; 0 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/solaris/native/sun/nio/ch/Net.c

rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
8 lines changed: 7 ins; 0 del; 1 mod; 668 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/windows/native/java/net/net_util_md.c

rev 7401 : 8048212: Two tests failed with "java.net.SocketException: Bad protocol option" on Windows after 8029607
Reviewed-by: alanb
7 lines changed: 7 ins; 0 del; 0 mod; 1025 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/windows/native/sun/nio/ch/Net.c

rev 7400 : 8029607: Type of Service (TOS) cannot be set in IPv6 header
Reviewed-by: alanb
rev 7401 : 8048212: Two tests failed with "java.net.SocketException: Bad protocol option" on Windows after 8029607
Reviewed-by: alanb
8 lines changed: 5 ins; 0 del; 3 mod; 535 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/Makefile

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
2 lines changed: 0 ins; 0 del; 2 mod; 883 unchg

------ ------ ------ ------ --- New ----- Raw make/jdk/Makefile

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/jdk/net/FILES_java.gmk

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/jdk/net/Makefile

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/java/net/SocketSecrets.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/jdk/net/ExtendedSocketOptions.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/jdk/net/NetworkPermission.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/jdk/net/SocketFlow.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/jdk/net/Sockets.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
rev 7399 : 8047186: jdk.net.Sockets throws InvocationTargetException instead of original runtime exceptions
Reviewed-by: michaelm
Contributed-by: artem.smotrakov@oracle.com
405 lines changed: 405 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/jdk/net/package-info.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/sun/net/ExtendedOptionsImpl.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/native/java/net/jdk_net_SocketFlow.h

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/solaris/native/java/net/ExtendedOptionsImpl.c

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
329 lines changed: 329 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/windows/native/java/net/ExtendedOptionsImpl.c

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/net/Sockets/Test.java

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
231 lines changed: 231 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/net/Sockets/policy.fail

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/net/Sockets/policy.success

rev 7398 : 8032808: Support Solaris SO_FLOW_SLA socket option
Reviewed-by: michaelm
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/scoffey/bin/webrev.ksh (vers 26.0-hg+openjdk.java.net).