Code Review for open

Prepared by:coleenp on Mon Nov 11 13:08:19 EST 2019
Workspace:/scratch/coleen/hg/14link-resolver/open
Compare against version:qparent
Summary of changes: 656 lines changed: 99 ins; 61 del; 496 mod; 104941 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

1 line changed: 0 ins; 0 del; 1 mod; 5695 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/aot/aotCompiledMethod.cpp

5 lines changed: 0 ins; 5 del; 0 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_Runtime1.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1494 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciEnv.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciExceptionHandler.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciField.cpp

1 line changed: 0 ins; 0 del; 1 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciInstanceKlass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 762 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciMethod.cpp

34 lines changed: 1 ins; 0 del; 33 mod; 1512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciReplay.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciStreams.cpp

8 lines changed: 0 ins; 0 del; 8 mod; 499 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/bytecodeAssembler.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 6336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

12 lines changed: 1 ins; 6 del; 5 mod; 4740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 1667 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

34 lines changed: 2 ins; 3 del; 29 mod; 2840 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.hpp

9 lines changed: 0 ins; 0 del; 9 mod; 647 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

3 lines changed: 0 ins; 1 del; 2 mod; 1085 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/compiledIC.cpp

1 line changed: 0 ins; 0 del; 1 mod; 761 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/compiledMethod.cpp

1 line changed: 0 ins; 0 del; 1 mod; 720 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/nmethod.cpp

14 lines changed: 3 ins; 1 del; 10 mod; 3496 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compileBroker.cpp

3 lines changed: 1 ins; 0 del; 2 mod; 2721 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compileTask.cpp

9 lines changed: 0 ins; 5 del; 4 mod; 496 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/tieredThresholdPolicy.cpp

34 lines changed: 3 ins; 1 del; 30 mod; 1050 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/tieredThresholdPolicy.hpp

13 lines changed: 0 ins; 0 del; 13 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/abstractInterpreter.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecode.cpp

6 lines changed: 2 ins; 0 del; 4 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecode.hpp

1 line changed: 0 ins; 0 del; 1 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/interpreterRuntime.cpp

5 lines changed: 1 ins; 0 del; 4 mod; 1578 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/linkResolver.cpp

83 lines changed: 5 ins; 4 del; 74 mod; 1731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/linkResolver.hpp

26 lines changed: 0 ins; 0 del; 26 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/rewriter.cpp

10 lines changed: 1 ins; 0 del; 9 mod; 621 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/rewriter.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.cpp

1 line changed: 0 ins; 0 del; 1 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/compilerRuntime.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCodeInstaller.cpp

15 lines changed: 4 ins; 0 del; 11 mod; 1338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompiler.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompiler.hpp

1 line changed: 0 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

65 lines changed: 6 ins; 0 del; 59 mod; 2716 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciEnv.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1695 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciJavaClasses.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 669 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciRuntime.cpp

14 lines changed: 0 ins; 0 del; 14 mod; 1532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciRuntime.hpp

12 lines changed: 0 ins; 0 del; 12 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/dynamicArchive.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/heapShared.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1056 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 2090 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.hpp

1 line changed: 0 ins; 0 del; 1 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

6 lines changed: 2 ins; 0 del; 4 mod; 848 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/fieldInfo.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/fieldStreams.hpp

30 lines changed: 1 ins; 24 del; 5 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/generateOopMap.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4041 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klassVtable.cpp

14 lines changed: 1 ins; 0 del; 13 mod; 1588 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

12 lines changed: 5 ins; 0 del; 7 mod; 2513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.hpp

1 line changed: 0 ins; 0 del; 1 mod; 1203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.cpp

10 lines changed: 2 ins; 0 del; 8 mod; 1865 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

3 lines changed: 1 ins; 0 del; 2 mod; 3642 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 959 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiCodeBlobEvents.cpp

1 line changed: 0 ins; 0 del; 1 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEnv.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3632 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.cpp

6 lines changed: 0 ins; 1 del; 5 mod; 4340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.hpp

1 line changed: 0 ins; 0 del; 1 mod; 551 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/methodComparator.cpp

3 lines changed: 1 ins; 0 del; 2 mod; 322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/methodHandles.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1613 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/nativeLookup.cpp

1 line changed: 0 ins; 0 del; 1 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/stackwalk.cpp

1 line changed: 0 ins; 0 del; 1 mod; 491 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/unsafe.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/deoptimization.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 2514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/fieldDescriptor.cpp

1 line changed: 0 ins; 0 del; 1 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/fieldDescriptor.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/frame.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/handles.hpp

1 line changed: 0 ins; 1 del; 0 mod; 315 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/handles.inline.hpp

8 lines changed: 0 ins; 8 del; 0 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/javaCalls.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 632 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/reflection.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

11 lines changed: 0 ins; 1 del; 10 mod; 3248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.hpp

1 line changed: 0 ins; 0 del; 1 mod; 732 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vframeArray.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 672 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/exceptions.cpp

1 line changed: 0 ins; 0 del; 1 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/xmlstream.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/xmlstream.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 185 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/oops/fieldStreams.inline.hpp

54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home.local/coleen/bin/official-webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).