--- old/src/hotspot/share/gc/shared/cardTable.cpp 2020-04-27 12:09:54.234109553 -0400 +++ new/src/hotspot/share/gc/shared/cardTable.cpp 2020-04-27 12:09:53.762097245 -0400 @@ -79,7 +79,7 @@ const size_t rs_align = _page_size == (size_t) os::vm_page_size() ? 0 : MAX2(_page_size, (size_t) os::vm_allocation_granularity()); - ReservedSpace heap_rs(_byte_map_size, rs_align, false); + ReservedSpace heap_rs(_byte_map_size, rs_align); MemTracker::record_virtual_memory_type((address)heap_rs.base(), mtGC); --- old/src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp 2020-04-27 12:09:54.746122903 -0400 +++ new/src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp 2020-04-27 12:09:54.354112682 -0400 @@ -104,8 +104,7 @@ assert(is_aligned(reservation_size_request_bytes, os::vm_allocation_granularity()), "invariant"); _rs = ReservedSpace(reservation_size_request_bytes, os::vm_allocation_granularity(), - UseLargePages && os::can_commit_large_page_memory(), - false); + UseLargePages && os::can_commit_large_page_memory()); if (!_rs.is_reserved()) { return false; } --- old/src/hotspot/share/memory/virtualspace.cpp 2020-04-27 12:09:55.238135732 -0400 +++ new/src/hotspot/share/memory/virtualspace.cpp 2020-04-27 12:09:54.854125720 -0400 @@ -66,12 +66,6 @@ initialize(size, alignment, large, requested_address, false); } -ReservedSpace::ReservedSpace(size_t size, size_t alignment, - bool large, - bool executable) : _fd_for_heap(-1) { - initialize(size, alignment, large, NULL, executable); -} - ReservedSpace::ReservedSpace(char* base, size_t size, size_t alignment, bool special, bool executable) : _fd_for_heap(-1) { assert((size % os::vm_allocation_granularity()) == 0, @@ -646,8 +640,8 @@ // executable. ReservedCodeSpace::ReservedCodeSpace(size_t r_size, size_t rs_align, - bool large) : - ReservedSpace(r_size, rs_align, large, /*executable*/ true) { + bool large) : ReservedSpace() { + initialize(r_size, rs_align, large, /*requested address*/ NULL, /*executable*/ true); MemTracker::record_virtual_memory_type((address)base(), mtCode); } @@ -1127,7 +1121,7 @@ bool large = maybe_large && UseLargePages && size >= os::large_page_size(); - ReservedSpace rs(size, alignment, large, false); + ReservedSpace rs(size, alignment, large); assert(rs.base() != NULL, "Must be"); assert(rs.size() == size, "Must be"); @@ -1255,7 +1249,7 @@ case Commit: return ReservedSpace(reserve_size_aligned, os::vm_allocation_granularity(), - /* large */ false, /* exec */ false); + /* large */ false); } } @@ -1310,7 +1304,7 @@ size_t large_page_size = os::large_page_size(); - ReservedSpace reserved(large_page_size, large_page_size, true, false); + ReservedSpace reserved(large_page_size, large_page_size, true); assert(reserved.is_reserved(), "Must be"); --- old/src/hotspot/share/memory/virtualspace.hpp 2020-04-27 12:09:55.762149396 -0400 +++ new/src/hotspot/share/memory/virtualspace.hpp 2020-04-27 12:09:55.362138966 -0400 @@ -62,7 +62,6 @@ ReservedSpace(size_t size, size_t preferred_page_size = 0); ReservedSpace(size_t size, size_t alignment, bool large, char* requested_address = NULL); - ReservedSpace(size_t size, size_t alignment, bool large, bool executable); // Accessors char* base() const { return _base; } --- old/test/hotspot/gtest/memory/test_virtualspace.cpp 2020-04-27 12:09:56.274162747 -0400 +++ new/test/hotspot/gtest/memory/test_virtualspace.cpp 2020-04-27 12:09:55.866152108 -0400 @@ -104,7 +104,7 @@ bool large = maybe_large && UseLargePages && size >= os::large_page_size(); - ReservedSpace rs(size, alignment, large, false); + ReservedSpace rs(size, alignment, large); MemoryReleaser releaser(&rs); EXPECT_TRUE(rs.base() != NULL) << "rs.special: " << rs.special(); @@ -218,7 +218,7 @@ case Commit: return ReservedSpace(reserve_size_aligned, os::vm_allocation_granularity(), - /* large */ false, /* exec */ false); + /* large */ false); } } @@ -297,7 +297,7 @@ size_t large_page_size = os::large_page_size(); - ReservedSpace reserved(large_page_size, large_page_size, true, false); + ReservedSpace reserved(large_page_size, large_page_size, true); ReservedSpaceReleaser releaser(&reserved); ASSERT_TRUE(reserved.is_reserved());