Code Review for hotspot

Prepared by:coleenp on Mon Jul 17 11:20:25 EDT 2017
Workspace:/scratch/cphillim/hg/10system-dictionary2/hotspot
Compare against: ssh://hg.openjdk.java.net/jdk10/hs/hotspot
Summary of changes: 1793 lines changed: 418 ins; 1085 del; 290 mod; 27213 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/doc/jsdb.html

5 lines changed: 0 ins; 5 del; 0 mod; 1364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java

5 lines changed: 1 ins; 0 del; 4 mod; 1968 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java

38 lines changed: 31 ins; 1 del; 6 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderDataGraph.java

34 lines changed: 23 ins; 0 del; 11 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Dictionary.java

34 lines changed: 1 ins; 24 del; 9 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/DictionaryEntry.java

53 lines changed: 0 ins; 51 del; 2 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java

80 lines changed: 1 ins; 77 del; 2 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Universe.java

12 lines changed: 0 ins; 12 del; 0 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java

5 lines changed: 0 ins; 4 del; 1 mod; 1168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Klass.java

7 lines changed: 6 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/ClassLoaderStats.java

3 lines changed: 1 ins; 0 del; 2 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java

4 lines changed: 1 ins; 0 del; 3 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/Hashtable.java

5 lines changed: 5 ins; 0 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java

33 lines changed: 0 ins; 31 del; 2 mod; 1236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/ReversePtrsAnalysis.java

3 lines changed: 1 ins; 0 del; 2 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/SystemDictionaryHelper.java

40 lines changed: 4 ins; 30 del; 6 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaHeap.java

6 lines changed: 2 ins; 0 del; 4 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/soql/sa.js

11 lines changed: 0 ins; 6 del; 5 mod; 905 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoaderData.cpp

189 lines changed: 186 ins; 0 del; 3 mod; 1265 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoaderData.hpp

30 lines changed: 28 ins; 0 del; 2 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classLoaderData.inline.hpp

4 lines changed: 0 ins; 4 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/dictionary.cpp

189 lines changed: 30 ins; 104 del; 55 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/dictionary.hpp

47 lines changed: 4 ins; 26 del; 17 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/loaderConstraints.cpp

14 lines changed: 4 ins; 1 del; 9 mod; 484 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/loaderConstraints.hpp

13 lines changed: 2 ins; 9 del; 2 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/moduleEntry.cpp

6 lines changed: 0 ins; 5 del; 1 mod; 512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/packageEntry.cpp

6 lines changed: 0 ins; 5 del; 1 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/placeholders.cpp

1 line changed: 0 ins; 0 del; 1 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/placeholders.hpp

4 lines changed: 0 ins; 3 del; 1 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/protectionDomainCache.cpp

3 lines changed: 1 ins; 1 del; 1 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

267 lines changed: 61 ins; 98 del; 108 mod; 2709 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

38 lines changed: 5 ins; 26 del; 7 mod; 684 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionaryShared.hpp

1 line changed: 1 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/universe.cpp

4 lines changed: 0 ins; 1 del; 3 mod; 1342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/klassVtable.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1605 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvmtiGetLoadedClasses.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/biasedLocking.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 807 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/compilationPolicy.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/memprofiler.cpp

1 line changed: 0 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp

82 lines changed: 2 ins; 78 del; 2 mod; 3431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/globalDefinitions.hpp

4 lines changed: 0 ins; 4 del; 0 mod; 1268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/hashtable.cpp

12 lines changed: 12 ins; 0 del; 0 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/hashtable.hpp

35 lines changed: 4 ins; 29 del; 2 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/runtime/NMT/CheckForProperDetailStackTrace.java

3 lines changed: 1 ins; 1 del; 1 mod; 110 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/LoaderConstraintEntry.java

90 lines changed: 0 ins; 90 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java

56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/PlaceholderEntry.java

75 lines changed: 0 ins; 75 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/PlaceholderTable.java

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/ProtectionDomainCacheEntry.java

56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/ProtectionDomainEntry.java

65 lines changed: 0 ins; 65 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/TwoOopHashtable.java

43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

This code review page was prepared using /home/cphillim/bin/official-webrev/webrev.ksh (vers 25.14-hg+openjdk.java.net).