1 /*
   2  * Copyright (c) 1998, 2014, Oracle and/or its affiliates. All rights reserved.
   3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   4  *
   5  * This code is free software; you can redistribute it and/or modify it
   6  * under the terms of the GNU General Public License version 2 only, as
   7  * published by the Free Software Foundation.
   8  *
   9  * This code is distributed in the hope that it will be useful, but WITHOUT
  10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
  12  * version 2 for more details (a copy is included in the LICENSE file that
  13  * accompanied this code).
  14  *
  15  * You should have received a copy of the GNU General Public License version
  16  * 2 along with this work; if not, write to the Free Software Foundation,
  17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  18  *
  19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
  20  * or visit www.oracle.com if you need additional information or have any
  21  * questions.
  22  *
  23  */
  24 
  25 #include "precompiled.hpp"
  26 #include "classfile/classFileStream.hpp"
  27 #include "classfile/javaClasses.hpp"
  28 #include "classfile/stackMapTable.hpp"
  29 #include "classfile/stackMapFrame.hpp"
  30 #include "classfile/stackMapTableFormat.hpp"
  31 #include "classfile/systemDictionary.hpp"
  32 #include "classfile/verifier.hpp"
  33 #include "classfile/vmSymbols.hpp"
  34 #include "interpreter/bytecodes.hpp"
  35 #include "interpreter/bytecodeStream.hpp"
  36 #include "memory/oopFactory.hpp"
  37 #include "memory/resourceArea.hpp"
  38 #include "oops/instanceKlass.hpp"
  39 #include "oops/oop.inline.hpp"
  40 #include "oops/typeArrayOop.hpp"
  41 #include "prims/jvm.h"
  42 #include "runtime/fieldDescriptor.hpp"
  43 #include "runtime/handles.inline.hpp"
  44 #include "runtime/interfaceSupport.hpp"
  45 #include "runtime/javaCalls.hpp"
  46 #include "runtime/orderAccess.inline.hpp"
  47 #include "runtime/os.hpp"
  48 #ifdef TARGET_ARCH_x86
  49 # include "bytes_x86.hpp"
  50 #endif
  51 #ifdef TARGET_ARCH_sparc
  52 # include "bytes_sparc.hpp"
  53 #endif
  54 #ifdef TARGET_ARCH_zero
  55 # include "bytes_zero.hpp"
  56 #endif
  57 #ifdef TARGET_ARCH_arm
  58 # include "bytes_arm.hpp"
  59 #endif
  60 #ifdef TARGET_ARCH_ppc
  61 # include "bytes_ppc.hpp"
  62 #endif
  63 
  64 #define NOFAILOVER_MAJOR_VERSION                       51
  65 #define NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION  51
  66 #define STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION       52
  67 
  68 // Access to external entry for VerifyClassCodes - old byte code verifier
  69 
  70 extern "C" {
  71   typedef jboolean (*verify_byte_codes_fn_t)(JNIEnv *, jclass, char *, jint);
  72   typedef jboolean (*verify_byte_codes_fn_new_t)(JNIEnv *, jclass, char *, jint, jint);
  73 }
  74 
  75 static void* volatile _verify_byte_codes_fn = NULL;
  76 
  77 static volatile jint _is_new_verify_byte_codes_fn = (jint) true;
  78 
  79 static void* verify_byte_codes_fn() {
  80   if (_verify_byte_codes_fn == NULL) {
  81     void *lib_handle = os::native_java_library();
  82     void *func = os::dll_lookup(lib_handle, "VerifyClassCodesForMajorVersion");
  83     OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
  84     if (func == NULL) {
  85       OrderAccess::release_store(&_is_new_verify_byte_codes_fn, false);
  86       func = os::dll_lookup(lib_handle, "VerifyClassCodes");
  87       OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
  88     }
  89   }
  90   return (void*)_verify_byte_codes_fn;
  91 }
  92 
  93 
  94 // Methods in Verifier
  95 
  96 bool Verifier::should_verify_for(oop class_loader, bool should_verify_class) {
  97   return (class_loader == NULL || !should_verify_class) ?
  98     BytecodeVerificationLocal : BytecodeVerificationRemote;
  99 }
 100 
 101 bool Verifier::relax_verify_for(oop loader) {
 102   bool trusted = java_lang_ClassLoader::is_trusted_loader(loader);
 103   bool need_verify =
 104     // verifyAll
 105     (BytecodeVerificationLocal && BytecodeVerificationRemote) ||
 106     // verifyRemote
 107     (!BytecodeVerificationLocal && BytecodeVerificationRemote && !trusted);
 108   return !need_verify;
 109 }
 110 
 111 bool Verifier::verify(instanceKlassHandle klass, Verifier::Mode mode, bool should_verify_class, TRAPS) {
 112   HandleMark hm;
 113   ResourceMark rm(THREAD);
 114 
 115   Symbol* exception_name = NULL;
 116   const size_t message_buffer_len = klass->name()->utf8_length() + 1024;
 117   char* message_buffer = NEW_RESOURCE_ARRAY(char, message_buffer_len);
 118   char* exception_message = message_buffer;
 119 
 120   const char* klassName = klass->external_name();
 121   bool can_failover = FailOverToOldVerifier &&
 122       klass->major_version() < NOFAILOVER_MAJOR_VERSION;
 123 
 124   // If the class should be verified, first see if we can use the split
 125   // verifier.  If not, or if verification fails and FailOverToOldVerifier
 126   // is set, then call the inference verifier.
 127   if (is_eligible_for_verification(klass, should_verify_class)) {
 128     if (TraceClassInitialization) {
 129       tty->print_cr("Start class verification for: %s", klassName);
 130     }
 131     if (klass->major_version() >= STACKMAP_ATTRIBUTE_MAJOR_VERSION) {
 132       ClassVerifier split_verifier(klass, THREAD);
 133       split_verifier.verify_class(THREAD);
 134       exception_name = split_verifier.result();
 135       if (can_failover && !HAS_PENDING_EXCEPTION &&
 136           (exception_name == vmSymbols::java_lang_VerifyError() ||
 137            exception_name == vmSymbols::java_lang_ClassFormatError())) {
 138         if (TraceClassInitialization || VerboseVerification) {
 139           tty->print_cr(
 140             "Fail over class verification to old verifier for: %s", klassName);
 141         }
 142         exception_name = inference_verify(
 143           klass, message_buffer, message_buffer_len, THREAD);
 144       }
 145       if (exception_name != NULL) {
 146         exception_message = split_verifier.exception_message();
 147       }
 148     } else {
 149       exception_name = inference_verify(
 150           klass, message_buffer, message_buffer_len, THREAD);
 151     }
 152 
 153     if (TraceClassInitialization || VerboseVerification) {
 154       if (HAS_PENDING_EXCEPTION) {
 155         tty->print("Verification for %s has", klassName);
 156         tty->print_cr(" exception pending %s ",
 157           InstanceKlass::cast(PENDING_EXCEPTION->klass())->external_name());
 158       } else if (exception_name != NULL) {
 159         tty->print_cr("Verification for %s failed", klassName);
 160       }
 161       tty->print_cr("End class verification for: %s", klassName);
 162     }
 163   }
 164 
 165   if (HAS_PENDING_EXCEPTION) {
 166     return false; // use the existing exception
 167   } else if (exception_name == NULL) {
 168     return true; // verifcation succeeded
 169   } else { // VerifyError or ClassFormatError to be created and thrown
 170     ResourceMark rm(THREAD);
 171     instanceKlassHandle kls =
 172       SystemDictionary::resolve_or_fail(exception_name, true, CHECK_false);
 173     while (!kls.is_null()) {
 174       if (kls == klass) {
 175         // If the class being verified is the exception we're creating
 176         // or one of it's superclasses, we're in trouble and are going
 177         // to infinitely recurse when we try to initialize the exception.
 178         // So bail out here by throwing the preallocated VM error.
 179         THROW_OOP_(Universe::virtual_machine_error_instance(), false);
 180       }
 181       kls = kls->super();
 182     }
 183     message_buffer[message_buffer_len - 1] = '\0'; // just to be sure
 184     THROW_MSG_(exception_name, exception_message, false);
 185   }
 186 }
 187 
 188 bool Verifier::is_eligible_for_verification(instanceKlassHandle klass, bool should_verify_class) {
 189   Symbol* name = klass->name();
 190   Klass* refl_magic_klass = SystemDictionary::reflect_MagicAccessorImpl_klass();
 191 
 192   bool is_reflect = refl_magic_klass != NULL && klass->is_subtype_of(refl_magic_klass);
 193 
 194   return (should_verify_for(klass->class_loader(), should_verify_class) &&
 195     // return if the class is a bootstrapping class
 196     // or defineClass specified not to verify by default (flags override passed arg)
 197     // We need to skip the following four for bootstraping
 198     name != vmSymbols::java_lang_Object() &&
 199     name != vmSymbols::java_lang_Class() &&
 200     name != vmSymbols::java_lang_String() &&
 201     name != vmSymbols::java_lang_Throwable() &&
 202 
 203     // Can not verify the bytecodes for shared classes because they have
 204     // already been rewritten to contain constant pool cache indices,
 205     // which the verifier can't understand.
 206     // Shared classes shouldn't have stackmaps either.
 207     !klass()->is_shared() &&
 208 
 209     // As of the fix for 4486457 we disable verification for all of the
 210     // dynamically-generated bytecodes associated with the 1.4
 211     // reflection implementation, not just those associated with
 212     // sun/reflect/SerializationConstructorAccessor.
 213     // NOTE: this is called too early in the bootstrapping process to be
 214     // guarded by Universe::is_gte_jdk14x_version().
 215     // Also for lambda generated code, gte jdk8
 216     (!is_reflect));
 217 }
 218 
 219 Symbol* Verifier::inference_verify(
 220     instanceKlassHandle klass, char* message, size_t message_len, TRAPS) {
 221   JavaThread* thread = (JavaThread*)THREAD;
 222   JNIEnv *env = thread->jni_environment();
 223 
 224   void* verify_func = verify_byte_codes_fn();
 225 
 226   if (verify_func == NULL) {
 227     jio_snprintf(message, message_len, "Could not link verifier");
 228     return vmSymbols::java_lang_VerifyError();
 229   }
 230 
 231   ResourceMark rm(THREAD);
 232   if (VerboseVerification) {
 233     tty->print_cr("Verifying class %s with old format", klass->external_name());
 234   }
 235 
 236   jclass cls = (jclass) JNIHandles::make_local(env, klass->java_mirror());
 237   jint result;
 238 
 239   {
 240     HandleMark hm(thread);
 241     ThreadToNativeFromVM ttn(thread);
 242     // ThreadToNativeFromVM takes care of changing thread_state, so safepoint
 243     // code knows that we have left the VM
 244 
 245     if (_is_new_verify_byte_codes_fn) {
 246       verify_byte_codes_fn_new_t func =
 247         CAST_TO_FN_PTR(verify_byte_codes_fn_new_t, verify_func);
 248       result = (*func)(env, cls, message, (int)message_len,
 249           klass->major_version());
 250     } else {
 251       verify_byte_codes_fn_t func =
 252         CAST_TO_FN_PTR(verify_byte_codes_fn_t, verify_func);
 253       result = (*func)(env, cls, message, (int)message_len);
 254     }
 255   }
 256 
 257   JNIHandles::destroy_local(cls);
 258 
 259   // These numbers are chosen so that VerifyClassCodes interface doesn't need
 260   // to be changed (still return jboolean (unsigned char)), and result is
 261   // 1 when verification is passed.
 262   if (result == 0) {
 263     return vmSymbols::java_lang_VerifyError();
 264   } else if (result == 1) {
 265     return NULL; // verified.
 266   } else if (result == 2) {
 267     THROW_MSG_(vmSymbols::java_lang_OutOfMemoryError(), message, NULL);
 268   } else if (result == 3) {
 269     return vmSymbols::java_lang_ClassFormatError();
 270   } else {
 271     ShouldNotReachHere();
 272     return NULL;
 273   }
 274 }
 275 
 276 TypeOrigin TypeOrigin::null() {
 277   return TypeOrigin();
 278 }
 279 TypeOrigin TypeOrigin::local(u2 index, StackMapFrame* frame) {
 280   assert(frame != NULL, "Must have a frame");
 281   return TypeOrigin(CF_LOCALS, index, StackMapFrame::copy(frame),
 282      frame->local_at(index));
 283 }
 284 TypeOrigin TypeOrigin::stack(u2 index, StackMapFrame* frame) {
 285   assert(frame != NULL, "Must have a frame");
 286   return TypeOrigin(CF_STACK, index, StackMapFrame::copy(frame),
 287       frame->stack_at(index));
 288 }
 289 TypeOrigin TypeOrigin::sm_local(u2 index, StackMapFrame* frame) {
 290   assert(frame != NULL, "Must have a frame");
 291   return TypeOrigin(SM_LOCALS, index, StackMapFrame::copy(frame),
 292       frame->local_at(index));
 293 }
 294 TypeOrigin TypeOrigin::sm_stack(u2 index, StackMapFrame* frame) {
 295   assert(frame != NULL, "Must have a frame");
 296   return TypeOrigin(SM_STACK, index, StackMapFrame::copy(frame),
 297       frame->stack_at(index));
 298 }
 299 TypeOrigin TypeOrigin::bad_index(u2 index) {
 300   return TypeOrigin(BAD_INDEX, index, NULL, VerificationType::bogus_type());
 301 }
 302 TypeOrigin TypeOrigin::cp(u2 index, VerificationType vt) {
 303   return TypeOrigin(CONST_POOL, index, NULL, vt);
 304 }
 305 TypeOrigin TypeOrigin::signature(VerificationType vt) {
 306   return TypeOrigin(SIG, 0, NULL, vt);
 307 }
 308 TypeOrigin TypeOrigin::implicit(VerificationType t) {
 309   return TypeOrigin(IMPLICIT, 0, NULL, t);
 310 }
 311 TypeOrigin TypeOrigin::frame(StackMapFrame* frame) {
 312   return TypeOrigin(FRAME_ONLY, 0, StackMapFrame::copy(frame),
 313                     VerificationType::bogus_type());
 314 }
 315 
 316 void TypeOrigin::reset_frame() {
 317   if (_frame != NULL) {
 318     _frame->restore();
 319   }
 320 }
 321 
 322 void TypeOrigin::details(outputStream* ss) const {
 323   _type.print_on(ss);
 324   switch (_origin) {
 325     case CF_LOCALS:
 326       ss->print(" (current frame, locals[%d])", _index);
 327       break;
 328     case CF_STACK:
 329       ss->print(" (current frame, stack[%d])", _index);
 330       break;
 331     case SM_LOCALS:
 332       ss->print(" (stack map, locals[%d])", _index);
 333       break;
 334     case SM_STACK:
 335       ss->print(" (stack map, stack[%d])", _index);
 336       break;
 337     case CONST_POOL:
 338       ss->print(" (constant pool %d)", _index);
 339       break;
 340     case SIG:
 341       ss->print(" (from method signature)");
 342       break;
 343     case IMPLICIT:
 344     case FRAME_ONLY:
 345     case NONE:
 346     default:
 347       ;
 348   }
 349 }
 350 
 351 #ifdef ASSERT
 352 void TypeOrigin::print_on(outputStream* str) const {
 353   str->print("{%d,%d,%p:", _origin, _index, _frame);
 354   if (_frame != NULL) {
 355     _frame->print_on(str);
 356   } else {
 357     str->print("null");
 358   }
 359   str->print(",");
 360   _type.print_on(str);
 361   str->print("}");
 362 }
 363 #endif
 364 
 365 void ErrorContext::details(outputStream* ss, const Method* method) const {
 366   if (is_valid()) {
 367     ss->cr();
 368     ss->print_cr("Exception Details:");
 369     location_details(ss, method);
 370     reason_details(ss);
 371     frame_details(ss);
 372     bytecode_details(ss, method);
 373     handler_details(ss, method);
 374     stackmap_details(ss, method);
 375   }
 376 }
 377 
 378 void ErrorContext::reason_details(outputStream* ss) const {
 379   streamIndentor si(ss);
 380   ss->indent().print_cr("Reason:");
 381   streamIndentor si2(ss);
 382   ss->indent().print("%s", "");
 383   switch (_fault) {
 384     case INVALID_BYTECODE:
 385       ss->print("Error exists in the bytecode");
 386       break;
 387     case WRONG_TYPE:
 388       if (_expected.is_valid()) {
 389         ss->print("Type ");
 390         _type.details(ss);
 391         ss->print(" is not assignable to ");
 392         _expected.details(ss);
 393       } else {
 394         ss->print("Invalid type: ");
 395         _type.details(ss);
 396       }
 397       break;
 398     case FLAGS_MISMATCH:
 399       if (_expected.is_valid()) {
 400         ss->print("Current frame's flags are not assignable "
 401                   "to stack map frame's.");
 402       } else {
 403         ss->print("Current frame's flags are invalid in this context.");
 404       }
 405       break;
 406     case BAD_CP_INDEX:
 407       ss->print("Constant pool index %d is invalid", _type.index());
 408       break;
 409     case BAD_LOCAL_INDEX:
 410       ss->print("Local index %d is invalid", _type.index());
 411       break;
 412     case LOCALS_SIZE_MISMATCH:
 413       ss->print("Current frame's local size doesn't match stackmap.");
 414       break;
 415     case STACK_SIZE_MISMATCH:
 416       ss->print("Current frame's stack size doesn't match stackmap.");
 417       break;
 418     case STACK_OVERFLOW:
 419       ss->print("Exceeded max stack size.");
 420       break;
 421     case STACK_UNDERFLOW:
 422       ss->print("Attempt to pop empty stack.");
 423       break;
 424     case MISSING_STACKMAP:
 425       ss->print("Expected stackmap frame at this location.");
 426       break;
 427     case BAD_STACKMAP:
 428       ss->print("Invalid stackmap specification.");
 429       break;
 430     case UNKNOWN:
 431     default:
 432       ShouldNotReachHere();
 433       ss->print_cr("Unknown");
 434   }
 435   ss->cr();
 436 }
 437 
 438 void ErrorContext::location_details(outputStream* ss, const Method* method) const {
 439   if (_bci != -1 && method != NULL) {
 440     streamIndentor si(ss);
 441     const char* bytecode_name = "<invalid>";
 442     if (method->validate_bci(_bci) != -1) {
 443       Bytecodes::Code code = Bytecodes::code_or_bp_at(method->bcp_from(_bci));
 444       if (Bytecodes::is_defined(code)) {
 445           bytecode_name = Bytecodes::name(code);
 446       } else {
 447           bytecode_name = "<illegal>";
 448       }
 449     }
 450     InstanceKlass* ik = method->method_holder();
 451     ss->indent().print_cr("Location:");
 452     streamIndentor si2(ss);
 453     ss->indent().print_cr("%s.%s%s @%d: %s",
 454         ik->name()->as_C_string(), method->name()->as_C_string(),
 455         method->signature()->as_C_string(), _bci, bytecode_name);
 456   }
 457 }
 458 
 459 void ErrorContext::frame_details(outputStream* ss) const {
 460   streamIndentor si(ss);
 461   if (_type.is_valid() && _type.frame() != NULL) {
 462     ss->indent().print_cr("Current Frame:");
 463     streamIndentor si2(ss);
 464     _type.frame()->print_on(ss);
 465   }
 466   if (_expected.is_valid() && _expected.frame() != NULL) {
 467     ss->indent().print_cr("Stackmap Frame:");
 468     streamIndentor si2(ss);
 469     _expected.frame()->print_on(ss);
 470   }
 471 }
 472 
 473 void ErrorContext::bytecode_details(outputStream* ss, const Method* method) const {
 474   if (method != NULL) {
 475     streamIndentor si(ss);
 476     ss->indent().print_cr("Bytecode:");
 477     streamIndentor si2(ss);
 478     ss->print_data(method->code_base(), method->code_size(), false);
 479   }
 480 }
 481 
 482 void ErrorContext::handler_details(outputStream* ss, const Method* method) const {
 483   if (method != NULL) {
 484     streamIndentor si(ss);
 485     ExceptionTable table(method);
 486     if (table.length() > 0) {
 487       ss->indent().print_cr("Exception Handler Table:");
 488       streamIndentor si2(ss);
 489       for (int i = 0; i < table.length(); ++i) {
 490         ss->indent().print_cr("bci [%d, %d] => handler: %d", table.start_pc(i),
 491             table.end_pc(i), table.handler_pc(i));
 492       }
 493     }
 494   }
 495 }
 496 
 497 void ErrorContext::stackmap_details(outputStream* ss, const Method* method) const {
 498   if (method != NULL && method->has_stackmap_table()) {
 499     streamIndentor si(ss);
 500     ss->indent().print_cr("Stackmap Table:");
 501     Array<u1>* data = method->stackmap_data();
 502     stack_map_table* sm_table =
 503         stack_map_table::at((address)data->adr_at(0));
 504     stack_map_frame* sm_frame = sm_table->entries();
 505     streamIndentor si2(ss);
 506     int current_offset = -1;
 507     for (u2 i = 0; i < sm_table->number_of_entries(); ++i) {
 508       ss->indent();
 509       sm_frame->print_on(ss, current_offset);
 510       ss->cr();
 511       current_offset += sm_frame->offset_delta();
 512       sm_frame = sm_frame->next();
 513     }
 514   }
 515 }
 516 
 517 // Methods in ClassVerifier
 518 
 519 ClassVerifier::ClassVerifier(
 520     instanceKlassHandle klass, TRAPS)
 521     : _thread(THREAD), _exception_type(NULL), _message(NULL), _klass(klass) {
 522   _this_type = VerificationType::reference_type(klass->name());
 523   // Create list to hold symbols in reference area.
 524   _symbols = new GrowableArray<Symbol*>(100, 0, NULL);
 525 }
 526 
 527 ClassVerifier::~ClassVerifier() {
 528   // Decrement the reference count for any symbols created.
 529   for (int i = 0; i < _symbols->length(); i++) {
 530     Symbol* s = _symbols->at(i);
 531     s->decrement_refcount();
 532   }
 533 }
 534 
 535 VerificationType ClassVerifier::object_type() const {
 536   return VerificationType::reference_type(vmSymbols::java_lang_Object());
 537 }
 538 
 539 TypeOrigin ClassVerifier::ref_ctx(const char* sig, TRAPS) {
 540   VerificationType vt = VerificationType::reference_type(
 541       create_temporary_symbol(sig, (int)strlen(sig), THREAD));
 542   return TypeOrigin::implicit(vt);
 543 }
 544 
 545 void ClassVerifier::verify_class(TRAPS) {
 546   if (VerboseVerification) {
 547     tty->print_cr("Verifying class %s with new format",
 548       _klass->external_name());
 549   }
 550 
 551   Array<Method*>* methods = _klass->methods();
 552   int num_methods = methods->length();
 553 
 554   for (int index = 0; index < num_methods; index++) {
 555     // Check for recursive re-verification before each method.
 556     if (was_recursively_verified())  return;
 557 
 558     Method* m = methods->at(index);
 559     if (m->is_native() || m->is_abstract() || m->is_overpass()) {
 560       // If m is native or abstract, skip it.  It is checked in class file
 561       // parser that methods do not override a final method.  Overpass methods
 562       // are trusted since the VM generates them.
 563       continue;
 564     }
 565     verify_method(methodHandle(THREAD, m), CHECK_VERIFY(this));
 566   }
 567 
 568   if (VerboseVerification || TraceClassInitialization) {
 569     if (was_recursively_verified())
 570       tty->print_cr("Recursive verification detected for: %s",
 571           _klass->external_name());
 572   }
 573 }
 574 
 575 void ClassVerifier::verify_method(methodHandle m, TRAPS) {
 576   HandleMark hm(THREAD);
 577   _method = m;   // initialize _method
 578   if (VerboseVerification) {
 579     tty->print_cr("Verifying method %s", m->name_and_sig_as_C_string());
 580   }
 581 
 582 // For clang, the only good constant format string is a literal constant format string.
 583 #define bad_type_msg "Bad type on operand stack in %s"
 584 
 585   int32_t max_stack = m->verifier_max_stack();
 586   int32_t max_locals = m->max_locals();
 587   constantPoolHandle cp(THREAD, m->constants());
 588 
 589   if (!SignatureVerifier::is_valid_method_signature(m->signature())) {
 590     class_format_error("Invalid method signature");
 591     return;
 592   }
 593 
 594   // Initial stack map frame: offset is 0, stack is initially empty.
 595   StackMapFrame current_frame(max_locals, max_stack, this);
 596   // Set initial locals
 597   VerificationType return_type = current_frame.set_locals_from_arg(
 598     m, current_type(), CHECK_VERIFY(this));
 599 
 600   int32_t stackmap_index = 0; // index to the stackmap array
 601 
 602   u4 code_length = m->code_size();
 603 
 604   // Scan the bytecode and map each instruction's start offset to a number.
 605   char* code_data = generate_code_data(m, code_length, CHECK_VERIFY(this));
 606 
 607   int ex_min = code_length;
 608   int ex_max = -1;
 609   // Look through each item on the exception table. Each of the fields must refer
 610   // to a legal instruction.
 611   verify_exception_handler_table(
 612     code_length, code_data, ex_min, ex_max, CHECK_VERIFY(this));
 613 
 614   // Look through each entry on the local variable table and make sure
 615   // its range of code array offsets is valid. (4169817)
 616   if (m->has_localvariable_table()) {
 617     verify_local_variable_table(code_length, code_data, CHECK_VERIFY(this));
 618   }
 619 
 620   Array<u1>* stackmap_data = m->stackmap_data();
 621   StackMapStream stream(stackmap_data);
 622   StackMapReader reader(this, &stream, code_data, code_length, THREAD);
 623   StackMapTable stackmap_table(&reader, &current_frame, max_locals, max_stack,
 624                                code_data, code_length, CHECK_VERIFY(this));
 625 
 626   if (VerboseVerification) {
 627     stackmap_table.print_on(tty);
 628   }
 629 
 630   RawBytecodeStream bcs(m);
 631 
 632   // Scan the byte code linearly from the start to the end
 633   bool no_control_flow = false; // Set to true when there is no direct control
 634                                 // flow from current instruction to the next
 635                                 // instruction in sequence
 636   Bytecodes::Code opcode;
 637   while (!bcs.is_last_bytecode()) {
 638     // Check for recursive re-verification before each bytecode.
 639     if (was_recursively_verified())  return;
 640 
 641     opcode = bcs.raw_next();
 642     u2 bci = bcs.bci();
 643 
 644     // Set current frame's offset to bci
 645     current_frame.set_offset(bci);
 646     current_frame.set_mark();
 647 
 648     // Make sure every offset in stackmap table point to the beginning to
 649     // an instruction. Match current_frame to stackmap_table entry with
 650     // the same offset if exists.
 651     stackmap_index = verify_stackmap_table(
 652       stackmap_index, bci, &current_frame, &stackmap_table,
 653       no_control_flow, CHECK_VERIFY(this));
 654 
 655 
 656     bool this_uninit = false;  // Set to true when invokespecial <init> initialized 'this'
 657 
 658     // Merge with the next instruction
 659     {
 660       u2 index;
 661       int target;
 662       VerificationType type, type2;
 663       VerificationType atype;
 664 
 665 #ifndef PRODUCT
 666       if (VerboseVerification) {
 667         current_frame.print_on(tty);
 668         tty->print_cr("offset = %d,  opcode = %s", bci, Bytecodes::name(opcode));
 669       }
 670 #endif
 671 
 672       // Make sure wide instruction is in correct format
 673       if (bcs.is_wide()) {
 674         if (opcode != Bytecodes::_iinc   && opcode != Bytecodes::_iload  &&
 675             opcode != Bytecodes::_aload  && opcode != Bytecodes::_lload  &&
 676             opcode != Bytecodes::_istore && opcode != Bytecodes::_astore &&
 677             opcode != Bytecodes::_lstore && opcode != Bytecodes::_fload  &&
 678             opcode != Bytecodes::_dload  && opcode != Bytecodes::_fstore &&
 679             opcode != Bytecodes::_dstore) {
 680           /* Unreachable?  RawBytecodeStream's raw_next() returns 'illegal'
 681            * if we encounter a wide instruction that modifies an invalid
 682            * opcode (not one of the ones listed above) */
 683           verify_error(ErrorContext::bad_code(bci), "Bad wide instruction");
 684           return;
 685         }
 686       }
 687 
 688       switch (opcode) {
 689         case Bytecodes::_nop :
 690           no_control_flow = false; break;
 691         case Bytecodes::_aconst_null :
 692           current_frame.push_stack(
 693             VerificationType::null_type(), CHECK_VERIFY(this));
 694           no_control_flow = false; break;
 695         case Bytecodes::_iconst_m1 :
 696         case Bytecodes::_iconst_0 :
 697         case Bytecodes::_iconst_1 :
 698         case Bytecodes::_iconst_2 :
 699         case Bytecodes::_iconst_3 :
 700         case Bytecodes::_iconst_4 :
 701         case Bytecodes::_iconst_5 :
 702           current_frame.push_stack(
 703             VerificationType::integer_type(), CHECK_VERIFY(this));
 704           no_control_flow = false; break;
 705         case Bytecodes::_lconst_0 :
 706         case Bytecodes::_lconst_1 :
 707           current_frame.push_stack_2(
 708             VerificationType::long_type(),
 709             VerificationType::long2_type(), CHECK_VERIFY(this));
 710           no_control_flow = false; break;
 711         case Bytecodes::_fconst_0 :
 712         case Bytecodes::_fconst_1 :
 713         case Bytecodes::_fconst_2 :
 714           current_frame.push_stack(
 715             VerificationType::float_type(), CHECK_VERIFY(this));
 716           no_control_flow = false; break;
 717         case Bytecodes::_dconst_0 :
 718         case Bytecodes::_dconst_1 :
 719           current_frame.push_stack_2(
 720             VerificationType::double_type(),
 721             VerificationType::double2_type(), CHECK_VERIFY(this));
 722           no_control_flow = false; break;
 723         case Bytecodes::_sipush :
 724         case Bytecodes::_bipush :
 725           current_frame.push_stack(
 726             VerificationType::integer_type(), CHECK_VERIFY(this));
 727           no_control_flow = false; break;
 728         case Bytecodes::_ldc :
 729           verify_ldc(
 730             opcode, bcs.get_index_u1(), &current_frame,
 731             cp, bci, CHECK_VERIFY(this));
 732           no_control_flow = false; break;
 733         case Bytecodes::_ldc_w :
 734         case Bytecodes::_ldc2_w :
 735           verify_ldc(
 736             opcode, bcs.get_index_u2(), &current_frame,
 737             cp, bci, CHECK_VERIFY(this));
 738           no_control_flow = false; break;
 739         case Bytecodes::_iload :
 740           verify_iload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 741           no_control_flow = false; break;
 742         case Bytecodes::_iload_0 :
 743         case Bytecodes::_iload_1 :
 744         case Bytecodes::_iload_2 :
 745         case Bytecodes::_iload_3 :
 746           index = opcode - Bytecodes::_iload_0;
 747           verify_iload(index, &current_frame, CHECK_VERIFY(this));
 748           no_control_flow = false; break;
 749         case Bytecodes::_lload :
 750           verify_lload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 751           no_control_flow = false; break;
 752         case Bytecodes::_lload_0 :
 753         case Bytecodes::_lload_1 :
 754         case Bytecodes::_lload_2 :
 755         case Bytecodes::_lload_3 :
 756           index = opcode - Bytecodes::_lload_0;
 757           verify_lload(index, &current_frame, CHECK_VERIFY(this));
 758           no_control_flow = false; break;
 759         case Bytecodes::_fload :
 760           verify_fload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 761           no_control_flow = false; break;
 762         case Bytecodes::_fload_0 :
 763         case Bytecodes::_fload_1 :
 764         case Bytecodes::_fload_2 :
 765         case Bytecodes::_fload_3 :
 766           index = opcode - Bytecodes::_fload_0;
 767           verify_fload(index, &current_frame, CHECK_VERIFY(this));
 768           no_control_flow = false; break;
 769         case Bytecodes::_dload :
 770           verify_dload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 771           no_control_flow = false; break;
 772         case Bytecodes::_dload_0 :
 773         case Bytecodes::_dload_1 :
 774         case Bytecodes::_dload_2 :
 775         case Bytecodes::_dload_3 :
 776           index = opcode - Bytecodes::_dload_0;
 777           verify_dload(index, &current_frame, CHECK_VERIFY(this));
 778           no_control_flow = false; break;
 779         case Bytecodes::_aload :
 780           verify_aload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 781           no_control_flow = false; break;
 782         case Bytecodes::_aload_0 :
 783         case Bytecodes::_aload_1 :
 784         case Bytecodes::_aload_2 :
 785         case Bytecodes::_aload_3 :
 786           index = opcode - Bytecodes::_aload_0;
 787           verify_aload(index, &current_frame, CHECK_VERIFY(this));
 788           no_control_flow = false; break;
 789         case Bytecodes::_iaload :
 790           type = current_frame.pop_stack(
 791             VerificationType::integer_type(), CHECK_VERIFY(this));
 792           atype = current_frame.pop_stack(
 793             VerificationType::reference_check(), CHECK_VERIFY(this));
 794           if (!atype.is_int_array()) {
 795             verify_error(ErrorContext::bad_type(bci,
 796                 current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
 797                 bad_type_msg, "iaload");
 798             return;
 799           }
 800           current_frame.push_stack(
 801             VerificationType::integer_type(), CHECK_VERIFY(this));
 802           no_control_flow = false; break;
 803         case Bytecodes::_baload :
 804           type = current_frame.pop_stack(
 805             VerificationType::integer_type(), CHECK_VERIFY(this));
 806           atype = current_frame.pop_stack(
 807             VerificationType::reference_check(), CHECK_VERIFY(this));
 808           if (!atype.is_bool_array() && !atype.is_byte_array()) {
 809             verify_error(
 810                 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
 811                 bad_type_msg, "baload");
 812             return;
 813           }
 814           current_frame.push_stack(
 815             VerificationType::integer_type(), CHECK_VERIFY(this));
 816           no_control_flow = false; break;
 817         case Bytecodes::_caload :
 818           type = current_frame.pop_stack(
 819             VerificationType::integer_type(), CHECK_VERIFY(this));
 820           atype = current_frame.pop_stack(
 821             VerificationType::reference_check(), CHECK_VERIFY(this));
 822           if (!atype.is_char_array()) {
 823             verify_error(ErrorContext::bad_type(bci,
 824                 current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
 825                 bad_type_msg, "caload");
 826             return;
 827           }
 828           current_frame.push_stack(
 829             VerificationType::integer_type(), CHECK_VERIFY(this));
 830           no_control_flow = false; break;
 831         case Bytecodes::_saload :
 832           type = current_frame.pop_stack(
 833             VerificationType::integer_type(), CHECK_VERIFY(this));
 834           atype = current_frame.pop_stack(
 835             VerificationType::reference_check(), CHECK_VERIFY(this));
 836           if (!atype.is_short_array()) {
 837             verify_error(ErrorContext::bad_type(bci,
 838                 current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
 839                 bad_type_msg, "saload");
 840             return;
 841           }
 842           current_frame.push_stack(
 843             VerificationType::integer_type(), CHECK_VERIFY(this));
 844           no_control_flow = false; break;
 845         case Bytecodes::_laload :
 846           type = current_frame.pop_stack(
 847             VerificationType::integer_type(), CHECK_VERIFY(this));
 848           atype = current_frame.pop_stack(
 849             VerificationType::reference_check(), CHECK_VERIFY(this));
 850           if (!atype.is_long_array()) {
 851             verify_error(ErrorContext::bad_type(bci,
 852                 current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
 853                 bad_type_msg, "laload");
 854             return;
 855           }
 856           current_frame.push_stack_2(
 857             VerificationType::long_type(),
 858             VerificationType::long2_type(), CHECK_VERIFY(this));
 859           no_control_flow = false; break;
 860         case Bytecodes::_faload :
 861           type = current_frame.pop_stack(
 862             VerificationType::integer_type(), CHECK_VERIFY(this));
 863           atype = current_frame.pop_stack(
 864             VerificationType::reference_check(), CHECK_VERIFY(this));
 865           if (!atype.is_float_array()) {
 866             verify_error(ErrorContext::bad_type(bci,
 867                 current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
 868                 bad_type_msg, "faload");
 869             return;
 870           }
 871           current_frame.push_stack(
 872             VerificationType::float_type(), CHECK_VERIFY(this));
 873           no_control_flow = false; break;
 874         case Bytecodes::_daload :
 875           type = current_frame.pop_stack(
 876             VerificationType::integer_type(), CHECK_VERIFY(this));
 877           atype = current_frame.pop_stack(
 878             VerificationType::reference_check(), CHECK_VERIFY(this));
 879           if (!atype.is_double_array()) {
 880             verify_error(ErrorContext::bad_type(bci,
 881                 current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
 882                 bad_type_msg, "daload");
 883             return;
 884           }
 885           current_frame.push_stack_2(
 886             VerificationType::double_type(),
 887             VerificationType::double2_type(), CHECK_VERIFY(this));
 888           no_control_flow = false; break;
 889         case Bytecodes::_aaload : {
 890           type = current_frame.pop_stack(
 891             VerificationType::integer_type(), CHECK_VERIFY(this));
 892           atype = current_frame.pop_stack(
 893             VerificationType::reference_check(), CHECK_VERIFY(this));
 894           if (!atype.is_reference_array()) {
 895             verify_error(ErrorContext::bad_type(bci,
 896                 current_frame.stack_top_ctx(),
 897                 TypeOrigin::implicit(VerificationType::reference_check())),
 898                 bad_type_msg, "aaload");
 899             return;
 900           }
 901           if (atype.is_null()) {
 902             current_frame.push_stack(
 903               VerificationType::null_type(), CHECK_VERIFY(this));
 904           } else {
 905             VerificationType component =
 906               atype.get_component(this, CHECK_VERIFY(this));
 907             current_frame.push_stack(component, CHECK_VERIFY(this));
 908           }
 909           no_control_flow = false; break;
 910         }
 911         case Bytecodes::_istore :
 912           verify_istore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 913           no_control_flow = false; break;
 914         case Bytecodes::_istore_0 :
 915         case Bytecodes::_istore_1 :
 916         case Bytecodes::_istore_2 :
 917         case Bytecodes::_istore_3 :
 918           index = opcode - Bytecodes::_istore_0;
 919           verify_istore(index, &current_frame, CHECK_VERIFY(this));
 920           no_control_flow = false; break;
 921         case Bytecodes::_lstore :
 922           verify_lstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 923           no_control_flow = false; break;
 924         case Bytecodes::_lstore_0 :
 925         case Bytecodes::_lstore_1 :
 926         case Bytecodes::_lstore_2 :
 927         case Bytecodes::_lstore_3 :
 928           index = opcode - Bytecodes::_lstore_0;
 929           verify_lstore(index, &current_frame, CHECK_VERIFY(this));
 930           no_control_flow = false; break;
 931         case Bytecodes::_fstore :
 932           verify_fstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 933           no_control_flow = false; break;
 934         case Bytecodes::_fstore_0 :
 935         case Bytecodes::_fstore_1 :
 936         case Bytecodes::_fstore_2 :
 937         case Bytecodes::_fstore_3 :
 938           index = opcode - Bytecodes::_fstore_0;
 939           verify_fstore(index, &current_frame, CHECK_VERIFY(this));
 940           no_control_flow = false; break;
 941         case Bytecodes::_dstore :
 942           verify_dstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 943           no_control_flow = false; break;
 944         case Bytecodes::_dstore_0 :
 945         case Bytecodes::_dstore_1 :
 946         case Bytecodes::_dstore_2 :
 947         case Bytecodes::_dstore_3 :
 948           index = opcode - Bytecodes::_dstore_0;
 949           verify_dstore(index, &current_frame, CHECK_VERIFY(this));
 950           no_control_flow = false; break;
 951         case Bytecodes::_astore :
 952           verify_astore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
 953           no_control_flow = false; break;
 954         case Bytecodes::_astore_0 :
 955         case Bytecodes::_astore_1 :
 956         case Bytecodes::_astore_2 :
 957         case Bytecodes::_astore_3 :
 958           index = opcode - Bytecodes::_astore_0;
 959           verify_astore(index, &current_frame, CHECK_VERIFY(this));
 960           no_control_flow = false; break;
 961         case Bytecodes::_iastore :
 962           type = current_frame.pop_stack(
 963             VerificationType::integer_type(), CHECK_VERIFY(this));
 964           type2 = current_frame.pop_stack(
 965             VerificationType::integer_type(), CHECK_VERIFY(this));
 966           atype = current_frame.pop_stack(
 967             VerificationType::reference_check(), CHECK_VERIFY(this));
 968           if (!atype.is_int_array()) {
 969             verify_error(ErrorContext::bad_type(bci,
 970                 current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
 971                 bad_type_msg, "iastore");
 972             return;
 973           }
 974           no_control_flow = false; break;
 975         case Bytecodes::_bastore :
 976           type = current_frame.pop_stack(
 977             VerificationType::integer_type(), CHECK_VERIFY(this));
 978           type2 = current_frame.pop_stack(
 979             VerificationType::integer_type(), CHECK_VERIFY(this));
 980           atype = current_frame.pop_stack(
 981             VerificationType::reference_check(), CHECK_VERIFY(this));
 982           if (!atype.is_bool_array() && !atype.is_byte_array()) {
 983             verify_error(
 984                 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
 985                 bad_type_msg, "bastore");
 986             return;
 987           }
 988           no_control_flow = false; break;
 989         case Bytecodes::_castore :
 990           current_frame.pop_stack(
 991             VerificationType::integer_type(), CHECK_VERIFY(this));
 992           current_frame.pop_stack(
 993             VerificationType::integer_type(), CHECK_VERIFY(this));
 994           atype = current_frame.pop_stack(
 995             VerificationType::reference_check(), CHECK_VERIFY(this));
 996           if (!atype.is_char_array()) {
 997             verify_error(ErrorContext::bad_type(bci,
 998                 current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
 999                 bad_type_msg, "castore");
1000             return;
1001           }
1002           no_control_flow = false; break;
1003         case Bytecodes::_sastore :
1004           current_frame.pop_stack(
1005             VerificationType::integer_type(), CHECK_VERIFY(this));
1006           current_frame.pop_stack(
1007             VerificationType::integer_type(), CHECK_VERIFY(this));
1008           atype = current_frame.pop_stack(
1009             VerificationType::reference_check(), CHECK_VERIFY(this));
1010           if (!atype.is_short_array()) {
1011             verify_error(ErrorContext::bad_type(bci,
1012                 current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
1013                 bad_type_msg, "sastore");
1014             return;
1015           }
1016           no_control_flow = false; break;
1017         case Bytecodes::_lastore :
1018           current_frame.pop_stack_2(
1019             VerificationType::long2_type(),
1020             VerificationType::long_type(), CHECK_VERIFY(this));
1021           current_frame.pop_stack(
1022             VerificationType::integer_type(), CHECK_VERIFY(this));
1023           atype = current_frame.pop_stack(
1024             VerificationType::reference_check(), CHECK_VERIFY(this));
1025           if (!atype.is_long_array()) {
1026             verify_error(ErrorContext::bad_type(bci,
1027                 current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
1028                 bad_type_msg, "lastore");
1029             return;
1030           }
1031           no_control_flow = false; break;
1032         case Bytecodes::_fastore :
1033           current_frame.pop_stack(
1034             VerificationType::float_type(), CHECK_VERIFY(this));
1035           current_frame.pop_stack
1036             (VerificationType::integer_type(), CHECK_VERIFY(this));
1037           atype = current_frame.pop_stack(
1038             VerificationType::reference_check(), CHECK_VERIFY(this));
1039           if (!atype.is_float_array()) {
1040             verify_error(ErrorContext::bad_type(bci,
1041                 current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
1042                 bad_type_msg, "fastore");
1043             return;
1044           }
1045           no_control_flow = false; break;
1046         case Bytecodes::_dastore :
1047           current_frame.pop_stack_2(
1048             VerificationType::double2_type(),
1049             VerificationType::double_type(), CHECK_VERIFY(this));
1050           current_frame.pop_stack(
1051             VerificationType::integer_type(), CHECK_VERIFY(this));
1052           atype = current_frame.pop_stack(
1053             VerificationType::reference_check(), CHECK_VERIFY(this));
1054           if (!atype.is_double_array()) {
1055             verify_error(ErrorContext::bad_type(bci,
1056                 current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
1057                 bad_type_msg, "dastore");
1058             return;
1059           }
1060           no_control_flow = false; break;
1061         case Bytecodes::_aastore :
1062           type = current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1063           type2 = current_frame.pop_stack(
1064             VerificationType::integer_type(), CHECK_VERIFY(this));
1065           atype = current_frame.pop_stack(
1066             VerificationType::reference_check(), CHECK_VERIFY(this));
1067           // more type-checking is done at runtime
1068           if (!atype.is_reference_array()) {
1069             verify_error(ErrorContext::bad_type(bci,
1070                 current_frame.stack_top_ctx(),
1071                 TypeOrigin::implicit(VerificationType::reference_check())),
1072                 bad_type_msg, "aastore");
1073             return;
1074           }
1075           // 4938384: relaxed constraint in JVMS 3nd edition.
1076           no_control_flow = false; break;
1077         case Bytecodes::_pop :
1078           current_frame.pop_stack(
1079             VerificationType::category1_check(), CHECK_VERIFY(this));
1080           no_control_flow = false; break;
1081         case Bytecodes::_pop2 :
1082           type = current_frame.pop_stack(CHECK_VERIFY(this));
1083           if (type.is_category1()) {
1084             current_frame.pop_stack(
1085               VerificationType::category1_check(), CHECK_VERIFY(this));
1086           } else if (type.is_category2_2nd()) {
1087             current_frame.pop_stack(
1088               VerificationType::category2_check(), CHECK_VERIFY(this));
1089           } else {
1090             /* Unreachable? Would need a category2_1st on TOS
1091              * which does not appear possible. */
1092             verify_error(
1093                 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
1094                 bad_type_msg, "pop2");
1095             return;
1096           }
1097           no_control_flow = false; break;
1098         case Bytecodes::_dup :
1099           type = current_frame.pop_stack(
1100             VerificationType::category1_check(), CHECK_VERIFY(this));
1101           current_frame.push_stack(type, CHECK_VERIFY(this));
1102           current_frame.push_stack(type, CHECK_VERIFY(this));
1103           no_control_flow = false; break;
1104         case Bytecodes::_dup_x1 :
1105           type = current_frame.pop_stack(
1106             VerificationType::category1_check(), CHECK_VERIFY(this));
1107           type2 = current_frame.pop_stack(
1108             VerificationType::category1_check(), CHECK_VERIFY(this));
1109           current_frame.push_stack(type, CHECK_VERIFY(this));
1110           current_frame.push_stack(type2, CHECK_VERIFY(this));
1111           current_frame.push_stack(type, CHECK_VERIFY(this));
1112           no_control_flow = false; break;
1113         case Bytecodes::_dup_x2 :
1114         {
1115           VerificationType type3;
1116           type = current_frame.pop_stack(
1117             VerificationType::category1_check(), CHECK_VERIFY(this));
1118           type2 = current_frame.pop_stack(CHECK_VERIFY(this));
1119           if (type2.is_category1()) {
1120             type3 = current_frame.pop_stack(
1121               VerificationType::category1_check(), CHECK_VERIFY(this));
1122           } else if (type2.is_category2_2nd()) {
1123             type3 = current_frame.pop_stack(
1124               VerificationType::category2_check(), CHECK_VERIFY(this));
1125           } else {
1126             /* Unreachable? Would need a category2_1st at stack depth 2 with
1127              * a category1 on TOS which does not appear possible. */
1128             verify_error(ErrorContext::bad_type(
1129                 bci, current_frame.stack_top_ctx()), bad_type_msg, "dup_x2");
1130             return;
1131           }
1132           current_frame.push_stack(type, CHECK_VERIFY(this));
1133           current_frame.push_stack(type3, CHECK_VERIFY(this));
1134           current_frame.push_stack(type2, CHECK_VERIFY(this));
1135           current_frame.push_stack(type, CHECK_VERIFY(this));
1136           no_control_flow = false; break;
1137         }
1138         case Bytecodes::_dup2 :
1139           type = current_frame.pop_stack(CHECK_VERIFY(this));
1140           if (type.is_category1()) {
1141             type2 = current_frame.pop_stack(
1142               VerificationType::category1_check(), CHECK_VERIFY(this));
1143           } else if (type.is_category2_2nd()) {
1144             type2 = current_frame.pop_stack(
1145               VerificationType::category2_check(), CHECK_VERIFY(this));
1146           } else {
1147             /* Unreachable?  Would need a category2_1st on TOS which does not
1148              * appear possible. */
1149             verify_error(
1150                 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
1151                 bad_type_msg, "dup2");
1152             return;
1153           }
1154           current_frame.push_stack(type2, CHECK_VERIFY(this));
1155           current_frame.push_stack(type, CHECK_VERIFY(this));
1156           current_frame.push_stack(type2, CHECK_VERIFY(this));
1157           current_frame.push_stack(type, CHECK_VERIFY(this));
1158           no_control_flow = false; break;
1159         case Bytecodes::_dup2_x1 :
1160         {
1161           VerificationType type3;
1162           type = current_frame.pop_stack(CHECK_VERIFY(this));
1163           if (type.is_category1()) {
1164             type2 = current_frame.pop_stack(
1165               VerificationType::category1_check(), CHECK_VERIFY(this));
1166           } else if (type.is_category2_2nd()) {
1167             type2 = current_frame.pop_stack(
1168               VerificationType::category2_check(), CHECK_VERIFY(this));
1169           } else {
1170             /* Unreachable?  Would need a category2_1st on TOS which does
1171              * not appear possible. */
1172             verify_error(
1173                 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
1174                 bad_type_msg, "dup2_x1");
1175             return;
1176           }
1177           type3 = current_frame.pop_stack(
1178             VerificationType::category1_check(), CHECK_VERIFY(this));
1179           current_frame.push_stack(type2, CHECK_VERIFY(this));
1180           current_frame.push_stack(type, CHECK_VERIFY(this));
1181           current_frame.push_stack(type3, CHECK_VERIFY(this));
1182           current_frame.push_stack(type2, CHECK_VERIFY(this));
1183           current_frame.push_stack(type, CHECK_VERIFY(this));
1184           no_control_flow = false; break;
1185         }
1186         case Bytecodes::_dup2_x2 :
1187         {
1188           VerificationType type3, type4;
1189           type = current_frame.pop_stack(CHECK_VERIFY(this));
1190           if (type.is_category1()) {
1191             type2 = current_frame.pop_stack(
1192               VerificationType::category1_check(), CHECK_VERIFY(this));
1193           } else if (type.is_category2_2nd()) {
1194             type2 = current_frame.pop_stack(
1195               VerificationType::category2_check(), CHECK_VERIFY(this));
1196           } else {
1197             /* Unreachable?  Would need a category2_1st on TOS which does
1198              * not appear possible. */
1199             verify_error(
1200                 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
1201                 bad_type_msg, "dup2_x2");
1202             return;
1203           }
1204           type3 = current_frame.pop_stack(CHECK_VERIFY(this));
1205           if (type3.is_category1()) {
1206             type4 = current_frame.pop_stack(
1207               VerificationType::category1_check(), CHECK_VERIFY(this));
1208           } else if (type3.is_category2_2nd()) {
1209             type4 = current_frame.pop_stack(
1210               VerificationType::category2_check(), CHECK_VERIFY(this));
1211           } else {
1212             /* Unreachable?  Would need a category2_1st on TOS after popping
1213              * a long/double or two category 1's, which does not
1214              * appear possible. */
1215             verify_error(
1216                 ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
1217                 bad_type_msg, "dup2_x2");
1218             return;
1219           }
1220           current_frame.push_stack(type2, CHECK_VERIFY(this));
1221           current_frame.push_stack(type, CHECK_VERIFY(this));
1222           current_frame.push_stack(type4, CHECK_VERIFY(this));
1223           current_frame.push_stack(type3, CHECK_VERIFY(this));
1224           current_frame.push_stack(type2, CHECK_VERIFY(this));
1225           current_frame.push_stack(type, CHECK_VERIFY(this));
1226           no_control_flow = false; break;
1227         }
1228         case Bytecodes::_swap :
1229           type = current_frame.pop_stack(
1230             VerificationType::category1_check(), CHECK_VERIFY(this));
1231           type2 = current_frame.pop_stack(
1232             VerificationType::category1_check(), CHECK_VERIFY(this));
1233           current_frame.push_stack(type, CHECK_VERIFY(this));
1234           current_frame.push_stack(type2, CHECK_VERIFY(this));
1235           no_control_flow = false; break;
1236         case Bytecodes::_iadd :
1237         case Bytecodes::_isub :
1238         case Bytecodes::_imul :
1239         case Bytecodes::_idiv :
1240         case Bytecodes::_irem :
1241         case Bytecodes::_ishl :
1242         case Bytecodes::_ishr :
1243         case Bytecodes::_iushr :
1244         case Bytecodes::_ior :
1245         case Bytecodes::_ixor :
1246         case Bytecodes::_iand :
1247           current_frame.pop_stack(
1248             VerificationType::integer_type(), CHECK_VERIFY(this));
1249           // fall through
1250         case Bytecodes::_ineg :
1251           current_frame.pop_stack(
1252             VerificationType::integer_type(), CHECK_VERIFY(this));
1253           current_frame.push_stack(
1254             VerificationType::integer_type(), CHECK_VERIFY(this));
1255           no_control_flow = false; break;
1256         case Bytecodes::_ladd :
1257         case Bytecodes::_lsub :
1258         case Bytecodes::_lmul :
1259         case Bytecodes::_ldiv :
1260         case Bytecodes::_lrem :
1261         case Bytecodes::_land :
1262         case Bytecodes::_lor :
1263         case Bytecodes::_lxor :
1264           current_frame.pop_stack_2(
1265             VerificationType::long2_type(),
1266             VerificationType::long_type(), CHECK_VERIFY(this));
1267           // fall through
1268         case Bytecodes::_lneg :
1269           current_frame.pop_stack_2(
1270             VerificationType::long2_type(),
1271             VerificationType::long_type(), CHECK_VERIFY(this));
1272           current_frame.push_stack_2(
1273             VerificationType::long_type(),
1274             VerificationType::long2_type(), CHECK_VERIFY(this));
1275           no_control_flow = false; break;
1276         case Bytecodes::_lshl :
1277         case Bytecodes::_lshr :
1278         case Bytecodes::_lushr :
1279           current_frame.pop_stack(
1280             VerificationType::integer_type(), CHECK_VERIFY(this));
1281           current_frame.pop_stack_2(
1282             VerificationType::long2_type(),
1283             VerificationType::long_type(), CHECK_VERIFY(this));
1284           current_frame.push_stack_2(
1285             VerificationType::long_type(),
1286             VerificationType::long2_type(), CHECK_VERIFY(this));
1287           no_control_flow = false; break;
1288         case Bytecodes::_fadd :
1289         case Bytecodes::_fsub :
1290         case Bytecodes::_fmul :
1291         case Bytecodes::_fdiv :
1292         case Bytecodes::_frem :
1293           current_frame.pop_stack(
1294             VerificationType::float_type(), CHECK_VERIFY(this));
1295           // fall through
1296         case Bytecodes::_fneg :
1297           current_frame.pop_stack(
1298             VerificationType::float_type(), CHECK_VERIFY(this));
1299           current_frame.push_stack(
1300             VerificationType::float_type(), CHECK_VERIFY(this));
1301           no_control_flow = false; break;
1302         case Bytecodes::_dadd :
1303         case Bytecodes::_dsub :
1304         case Bytecodes::_dmul :
1305         case Bytecodes::_ddiv :
1306         case Bytecodes::_drem :
1307           current_frame.pop_stack_2(
1308             VerificationType::double2_type(),
1309             VerificationType::double_type(), CHECK_VERIFY(this));
1310           // fall through
1311         case Bytecodes::_dneg :
1312           current_frame.pop_stack_2(
1313             VerificationType::double2_type(),
1314             VerificationType::double_type(), CHECK_VERIFY(this));
1315           current_frame.push_stack_2(
1316             VerificationType::double_type(),
1317             VerificationType::double2_type(), CHECK_VERIFY(this));
1318           no_control_flow = false; break;
1319         case Bytecodes::_iinc :
1320           verify_iinc(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
1321           no_control_flow = false; break;
1322         case Bytecodes::_i2l :
1323           type = current_frame.pop_stack(
1324             VerificationType::integer_type(), CHECK_VERIFY(this));
1325           current_frame.push_stack_2(
1326             VerificationType::long_type(),
1327             VerificationType::long2_type(), CHECK_VERIFY(this));
1328           no_control_flow = false; break;
1329        case Bytecodes::_l2i :
1330           current_frame.pop_stack_2(
1331             VerificationType::long2_type(),
1332             VerificationType::long_type(), CHECK_VERIFY(this));
1333           current_frame.push_stack(
1334             VerificationType::integer_type(), CHECK_VERIFY(this));
1335           no_control_flow = false; break;
1336         case Bytecodes::_i2f :
1337           current_frame.pop_stack(
1338             VerificationType::integer_type(), CHECK_VERIFY(this));
1339           current_frame.push_stack(
1340             VerificationType::float_type(), CHECK_VERIFY(this));
1341           no_control_flow = false; break;
1342         case Bytecodes::_i2d :
1343           current_frame.pop_stack(
1344             VerificationType::integer_type(), CHECK_VERIFY(this));
1345           current_frame.push_stack_2(
1346             VerificationType::double_type(),
1347             VerificationType::double2_type(), CHECK_VERIFY(this));
1348           no_control_flow = false; break;
1349         case Bytecodes::_l2f :
1350           current_frame.pop_stack_2(
1351             VerificationType::long2_type(),
1352             VerificationType::long_type(), CHECK_VERIFY(this));
1353           current_frame.push_stack(
1354             VerificationType::float_type(), CHECK_VERIFY(this));
1355           no_control_flow = false; break;
1356         case Bytecodes::_l2d :
1357           current_frame.pop_stack_2(
1358             VerificationType::long2_type(),
1359             VerificationType::long_type(), CHECK_VERIFY(this));
1360           current_frame.push_stack_2(
1361             VerificationType::double_type(),
1362             VerificationType::double2_type(), CHECK_VERIFY(this));
1363           no_control_flow = false; break;
1364         case Bytecodes::_f2i :
1365           current_frame.pop_stack(
1366             VerificationType::float_type(), CHECK_VERIFY(this));
1367           current_frame.push_stack(
1368             VerificationType::integer_type(), CHECK_VERIFY(this));
1369           no_control_flow = false; break;
1370         case Bytecodes::_f2l :
1371           current_frame.pop_stack(
1372             VerificationType::float_type(), CHECK_VERIFY(this));
1373           current_frame.push_stack_2(
1374             VerificationType::long_type(),
1375             VerificationType::long2_type(), CHECK_VERIFY(this));
1376           no_control_flow = false; break;
1377         case Bytecodes::_f2d :
1378           current_frame.pop_stack(
1379             VerificationType::float_type(), CHECK_VERIFY(this));
1380           current_frame.push_stack_2(
1381             VerificationType::double_type(),
1382             VerificationType::double2_type(), CHECK_VERIFY(this));
1383           no_control_flow = false; break;
1384         case Bytecodes::_d2i :
1385           current_frame.pop_stack_2(
1386             VerificationType::double2_type(),
1387             VerificationType::double_type(), CHECK_VERIFY(this));
1388           current_frame.push_stack(
1389             VerificationType::integer_type(), CHECK_VERIFY(this));
1390           no_control_flow = false; break;
1391         case Bytecodes::_d2l :
1392           current_frame.pop_stack_2(
1393             VerificationType::double2_type(),
1394             VerificationType::double_type(), CHECK_VERIFY(this));
1395           current_frame.push_stack_2(
1396             VerificationType::long_type(),
1397             VerificationType::long2_type(), CHECK_VERIFY(this));
1398           no_control_flow = false; break;
1399         case Bytecodes::_d2f :
1400           current_frame.pop_stack_2(
1401             VerificationType::double2_type(),
1402             VerificationType::double_type(), CHECK_VERIFY(this));
1403           current_frame.push_stack(
1404             VerificationType::float_type(), CHECK_VERIFY(this));
1405           no_control_flow = false; break;
1406         case Bytecodes::_i2b :
1407         case Bytecodes::_i2c :
1408         case Bytecodes::_i2s :
1409           current_frame.pop_stack(
1410             VerificationType::integer_type(), CHECK_VERIFY(this));
1411           current_frame.push_stack(
1412             VerificationType::integer_type(), CHECK_VERIFY(this));
1413           no_control_flow = false; break;
1414         case Bytecodes::_lcmp :
1415           current_frame.pop_stack_2(
1416             VerificationType::long2_type(),
1417             VerificationType::long_type(), CHECK_VERIFY(this));
1418           current_frame.pop_stack_2(
1419             VerificationType::long2_type(),
1420             VerificationType::long_type(), CHECK_VERIFY(this));
1421           current_frame.push_stack(
1422             VerificationType::integer_type(), CHECK_VERIFY(this));
1423           no_control_flow = false; break;
1424         case Bytecodes::_fcmpl :
1425         case Bytecodes::_fcmpg :
1426           current_frame.pop_stack(
1427             VerificationType::float_type(), CHECK_VERIFY(this));
1428           current_frame.pop_stack(
1429             VerificationType::float_type(), CHECK_VERIFY(this));
1430           current_frame.push_stack(
1431             VerificationType::integer_type(), CHECK_VERIFY(this));
1432           no_control_flow = false; break;
1433         case Bytecodes::_dcmpl :
1434         case Bytecodes::_dcmpg :
1435           current_frame.pop_stack_2(
1436             VerificationType::double2_type(),
1437             VerificationType::double_type(), CHECK_VERIFY(this));
1438           current_frame.pop_stack_2(
1439             VerificationType::double2_type(),
1440             VerificationType::double_type(), CHECK_VERIFY(this));
1441           current_frame.push_stack(
1442             VerificationType::integer_type(), CHECK_VERIFY(this));
1443           no_control_flow = false; break;
1444         case Bytecodes::_if_icmpeq:
1445         case Bytecodes::_if_icmpne:
1446         case Bytecodes::_if_icmplt:
1447         case Bytecodes::_if_icmpge:
1448         case Bytecodes::_if_icmpgt:
1449         case Bytecodes::_if_icmple:
1450           current_frame.pop_stack(
1451             VerificationType::integer_type(), CHECK_VERIFY(this));
1452           // fall through
1453         case Bytecodes::_ifeq:
1454         case Bytecodes::_ifne:
1455         case Bytecodes::_iflt:
1456         case Bytecodes::_ifge:
1457         case Bytecodes::_ifgt:
1458         case Bytecodes::_ifle:
1459           current_frame.pop_stack(
1460             VerificationType::integer_type(), CHECK_VERIFY(this));
1461           target = bcs.dest();
1462           stackmap_table.check_jump_target(
1463             &current_frame, target, CHECK_VERIFY(this));
1464           no_control_flow = false; break;
1465         case Bytecodes::_if_acmpeq :
1466         case Bytecodes::_if_acmpne :
1467           current_frame.pop_stack(
1468             VerificationType::reference_check(), CHECK_VERIFY(this));
1469           // fall through
1470         case Bytecodes::_ifnull :
1471         case Bytecodes::_ifnonnull :
1472           current_frame.pop_stack(
1473             VerificationType::reference_check(), CHECK_VERIFY(this));
1474           target = bcs.dest();
1475           stackmap_table.check_jump_target
1476             (&current_frame, target, CHECK_VERIFY(this));
1477           no_control_flow = false; break;
1478         case Bytecodes::_goto :
1479           target = bcs.dest();
1480           stackmap_table.check_jump_target(
1481             &current_frame, target, CHECK_VERIFY(this));
1482           no_control_flow = true; break;
1483         case Bytecodes::_goto_w :
1484           target = bcs.dest_w();
1485           stackmap_table.check_jump_target(
1486             &current_frame, target, CHECK_VERIFY(this));
1487           no_control_flow = true; break;
1488         case Bytecodes::_tableswitch :
1489         case Bytecodes::_lookupswitch :
1490           verify_switch(
1491             &bcs, code_length, code_data, &current_frame,
1492             &stackmap_table, CHECK_VERIFY(this));
1493           no_control_flow = true; break;
1494         case Bytecodes::_ireturn :
1495           type = current_frame.pop_stack(
1496             VerificationType::integer_type(), CHECK_VERIFY(this));
1497           verify_return_value(return_type, type, bci,
1498                               &current_frame, CHECK_VERIFY(this));
1499           no_control_flow = true; break;
1500         case Bytecodes::_lreturn :
1501           type2 = current_frame.pop_stack(
1502             VerificationType::long2_type(), CHECK_VERIFY(this));
1503           type = current_frame.pop_stack(
1504             VerificationType::long_type(), CHECK_VERIFY(this));
1505           verify_return_value(return_type, type, bci,
1506                               &current_frame, CHECK_VERIFY(this));
1507           no_control_flow = true; break;
1508         case Bytecodes::_freturn :
1509           type = current_frame.pop_stack(
1510             VerificationType::float_type(), CHECK_VERIFY(this));
1511           verify_return_value(return_type, type, bci,
1512                               &current_frame, CHECK_VERIFY(this));
1513           no_control_flow = true; break;
1514         case Bytecodes::_dreturn :
1515           type2 = current_frame.pop_stack(
1516             VerificationType::double2_type(),  CHECK_VERIFY(this));
1517           type = current_frame.pop_stack(
1518             VerificationType::double_type(), CHECK_VERIFY(this));
1519           verify_return_value(return_type, type, bci,
1520                               &current_frame, CHECK_VERIFY(this));
1521           no_control_flow = true; break;
1522         case Bytecodes::_areturn :
1523           type = current_frame.pop_stack(
1524             VerificationType::reference_check(), CHECK_VERIFY(this));
1525           verify_return_value(return_type, type, bci,
1526                               &current_frame, CHECK_VERIFY(this));
1527           no_control_flow = true; break;
1528         case Bytecodes::_return :
1529           if (return_type != VerificationType::bogus_type()) {
1530             verify_error(ErrorContext::bad_code(bci),
1531                          "Method expects a return value");
1532             return;
1533           }
1534           // Make sure "this" has been initialized if current method is an
1535           // <init>
1536           if (_method->name() == vmSymbols::object_initializer_name() &&
1537               current_frame.flag_this_uninit()) {
1538             verify_error(ErrorContext::bad_code(bci),
1539                          "Constructor must call super() or this() "
1540                          "before return");
1541             return;
1542           }
1543           no_control_flow = true; break;
1544         case Bytecodes::_getstatic :
1545         case Bytecodes::_putstatic :
1546         case Bytecodes::_getfield :
1547         case Bytecodes::_putfield :
1548           verify_field_instructions(
1549             &bcs, &current_frame, cp, CHECK_VERIFY(this));
1550           no_control_flow = false; break;
1551         case Bytecodes::_invokevirtual :
1552         case Bytecodes::_invokespecial :
1553         case Bytecodes::_invokestatic :
1554           verify_invoke_instructions(
1555             &bcs, code_length, &current_frame,
1556             &this_uninit, return_type, cp, CHECK_VERIFY(this));
1557           no_control_flow = false; break;
1558         case Bytecodes::_invokeinterface :
1559         case Bytecodes::_invokedynamic :
1560           verify_invoke_instructions(
1561             &bcs, code_length, &current_frame,
1562             &this_uninit, return_type, cp, CHECK_VERIFY(this));
1563           no_control_flow = false; break;
1564         case Bytecodes::_new :
1565         {
1566           index = bcs.get_index_u2();
1567           verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1568           VerificationType new_class_type =
1569             cp_index_to_type(index, cp, CHECK_VERIFY(this));
1570           if (!new_class_type.is_object()) {
1571             verify_error(ErrorContext::bad_type(bci,
1572                 TypeOrigin::cp(index, new_class_type)),
1573                 "Illegal new instruction");
1574             return;
1575           }
1576           type = VerificationType::uninitialized_type(bci);
1577           current_frame.push_stack(type, CHECK_VERIFY(this));
1578           no_control_flow = false; break;
1579         }
1580         case Bytecodes::_newarray :
1581           type = get_newarray_type(bcs.get_index(), bci, CHECK_VERIFY(this));
1582           current_frame.pop_stack(
1583             VerificationType::integer_type(),  CHECK_VERIFY(this));
1584           current_frame.push_stack(type, CHECK_VERIFY(this));
1585           no_control_flow = false; break;
1586         case Bytecodes::_anewarray :
1587           verify_anewarray(
1588             bci, bcs.get_index_u2(), cp, &current_frame, CHECK_VERIFY(this));
1589           no_control_flow = false; break;
1590         case Bytecodes::_arraylength :
1591           type = current_frame.pop_stack(
1592             VerificationType::reference_check(), CHECK_VERIFY(this));
1593           if (!(type.is_null() || type.is_array())) {
1594             verify_error(ErrorContext::bad_type(
1595                 bci, current_frame.stack_top_ctx()),
1596                 bad_type_msg, "arraylength");
1597           }
1598           current_frame.push_stack(
1599             VerificationType::integer_type(), CHECK_VERIFY(this));
1600           no_control_flow = false; break;
1601         case Bytecodes::_checkcast :
1602         {
1603           index = bcs.get_index_u2();
1604           verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1605           current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1606           VerificationType klass_type = cp_index_to_type(
1607             index, cp, CHECK_VERIFY(this));
1608           current_frame.push_stack(klass_type, CHECK_VERIFY(this));
1609           no_control_flow = false; break;
1610         }
1611         case Bytecodes::_instanceof : {
1612           index = bcs.get_index_u2();
1613           verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1614           current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1615           current_frame.push_stack(
1616             VerificationType::integer_type(), CHECK_VERIFY(this));
1617           no_control_flow = false; break;
1618         }
1619         case Bytecodes::_monitorenter :
1620         case Bytecodes::_monitorexit :
1621           current_frame.pop_stack(
1622             VerificationType::reference_check(), CHECK_VERIFY(this));
1623           no_control_flow = false; break;
1624         case Bytecodes::_multianewarray :
1625         {
1626           index = bcs.get_index_u2();
1627           u2 dim = *(bcs.bcp()+3);
1628           verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1629           VerificationType new_array_type =
1630             cp_index_to_type(index, cp, CHECK_VERIFY(this));
1631           if (!new_array_type.is_array()) {
1632             verify_error(ErrorContext::bad_type(bci,
1633                 TypeOrigin::cp(index, new_array_type)),
1634                 "Illegal constant pool index in multianewarray instruction");
1635             return;
1636           }
1637           if (dim < 1 || new_array_type.dimensions() < dim) {
1638             verify_error(ErrorContext::bad_code(bci),
1639                 "Illegal dimension in multianewarray instruction: %d", dim);
1640             return;
1641           }
1642           for (int i = 0; i < dim; i++) {
1643             current_frame.pop_stack(
1644               VerificationType::integer_type(), CHECK_VERIFY(this));
1645           }
1646           current_frame.push_stack(new_array_type, CHECK_VERIFY(this));
1647           no_control_flow = false; break;
1648         }
1649         case Bytecodes::_athrow :
1650           type = VerificationType::reference_type(
1651             vmSymbols::java_lang_Throwable());
1652           current_frame.pop_stack(type, CHECK_VERIFY(this));
1653           no_control_flow = true; break;
1654         default:
1655           // We only need to check the valid bytecodes in class file.
1656           // And jsr and ret are not in the new class file format in JDK1.5.
1657           verify_error(ErrorContext::bad_code(bci),
1658               "Bad instruction: %02x", opcode);
1659           no_control_flow = false;
1660           return;
1661       }  // end switch
1662     }  // end Merge with the next instruction
1663 
1664     // Look for possible jump target in exception handlers and see if it
1665     // matches current_frame
1666     if (bci >= ex_min && bci < ex_max) {
1667       verify_exception_handler_targets(
1668         bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
1669     }
1670   } // end while
1671 
1672   // Make sure that control flow does not fall through end of the method
1673   if (!no_control_flow) {
1674     verify_error(ErrorContext::bad_code(code_length),
1675         "Control flow falls through code end");
1676     return;
1677   }
1678 }
1679 
1680 #undef bad_type_message
1681 
1682 char* ClassVerifier::generate_code_data(methodHandle m, u4 code_length, TRAPS) {
1683   char* code_data = NEW_RESOURCE_ARRAY(char, code_length);
1684   memset(code_data, 0, sizeof(char) * code_length);
1685   RawBytecodeStream bcs(m);
1686 
1687   while (!bcs.is_last_bytecode()) {
1688     if (bcs.raw_next() != Bytecodes::_illegal) {
1689       int bci = bcs.bci();
1690       if (bcs.raw_code() == Bytecodes::_new) {
1691         code_data[bci] = NEW_OFFSET;
1692       } else {
1693         code_data[bci] = BYTECODE_OFFSET;
1694       }
1695     } else {
1696       verify_error(ErrorContext::bad_code(bcs.bci()), "Bad instruction");
1697       return NULL;
1698     }
1699   }
1700 
1701   return code_data;
1702 }
1703 
1704 void ClassVerifier::verify_exception_handler_table(u4 code_length, char* code_data, int& min, int& max, TRAPS) {
1705   ExceptionTable exhandlers(_method());
1706   int exlength = exhandlers.length();
1707   constantPoolHandle cp (THREAD, _method->constants());
1708 
1709   for(int i = 0; i < exlength; i++) {
1710     //reacquire the table in case a GC happened
1711     ExceptionTable exhandlers(_method());
1712     u2 start_pc = exhandlers.start_pc(i);
1713     u2 end_pc = exhandlers.end_pc(i);
1714     u2 handler_pc = exhandlers.handler_pc(i);
1715     if (start_pc >= code_length || code_data[start_pc] == 0) {
1716       class_format_error("Illegal exception table start_pc %d", start_pc);
1717       return;
1718     }
1719     if (end_pc != code_length) {   // special case: end_pc == code_length
1720       if (end_pc > code_length || code_data[end_pc] == 0) {
1721         class_format_error("Illegal exception table end_pc %d", end_pc);
1722         return;
1723       }
1724     }
1725     if (handler_pc >= code_length || code_data[handler_pc] == 0) {
1726       class_format_error("Illegal exception table handler_pc %d", handler_pc);
1727       return;
1728     }
1729     int catch_type_index = exhandlers.catch_type_index(i);
1730     if (catch_type_index != 0) {
1731       VerificationType catch_type = cp_index_to_type(
1732         catch_type_index, cp, CHECK_VERIFY(this));
1733       VerificationType throwable =
1734         VerificationType::reference_type(vmSymbols::java_lang_Throwable());
1735       bool is_subclass = throwable.is_assignable_from(
1736         catch_type, this, CHECK_VERIFY(this));
1737       if (!is_subclass) {
1738         // 4286534: should throw VerifyError according to recent spec change
1739         verify_error(ErrorContext::bad_type(handler_pc,
1740             TypeOrigin::cp(catch_type_index, catch_type),
1741             TypeOrigin::implicit(throwable)),
1742             "Catch type is not a subclass "
1743             "of Throwable in exception handler %d", handler_pc);
1744         return;
1745       }
1746     }
1747     if (start_pc < min) min = start_pc;
1748     if (end_pc > max) max = end_pc;
1749   }
1750 }
1751 
1752 void ClassVerifier::verify_local_variable_table(u4 code_length, char* code_data, TRAPS) {
1753   int localvariable_table_length = _method()->localvariable_table_length();
1754   if (localvariable_table_length > 0) {
1755     LocalVariableTableElement* table = _method()->localvariable_table_start();
1756     for (int i = 0; i < localvariable_table_length; i++) {
1757       u2 start_bci = table[i].start_bci;
1758       u2 length = table[i].length;
1759 
1760       if (start_bci >= code_length || code_data[start_bci] == 0) {
1761         class_format_error(
1762           "Illegal local variable table start_pc %d", start_bci);
1763         return;
1764       }
1765       u4 end_bci = (u4)(start_bci + length);
1766       if (end_bci != code_length) {
1767         if (end_bci >= code_length || code_data[end_bci] == 0) {
1768           class_format_error( "Illegal local variable table length %d", length);
1769           return;
1770         }
1771       }
1772     }
1773   }
1774 }
1775 
1776 u2 ClassVerifier::verify_stackmap_table(u2 stackmap_index, u2 bci,
1777                                         StackMapFrame* current_frame,
1778                                         StackMapTable* stackmap_table,
1779                                         bool no_control_flow, TRAPS) {
1780   if (stackmap_index < stackmap_table->get_frame_count()) {
1781     u2 this_offset = stackmap_table->get_offset(stackmap_index);
1782     if (no_control_flow && this_offset > bci) {
1783       verify_error(ErrorContext::missing_stackmap(bci),
1784                    "Expecting a stack map frame");
1785       return 0;
1786     }
1787     if (this_offset == bci) {
1788       ErrorContext ctx;
1789       // See if current stack map can be assigned to the frame in table.
1790       // current_frame is the stackmap frame got from the last instruction.
1791       // If matched, current_frame will be updated by this method.
1792       bool matches = stackmap_table->match_stackmap(
1793         current_frame, this_offset, stackmap_index,
1794         !no_control_flow, true, &ctx, CHECK_VERIFY_(this, 0));
1795       if (!matches) {
1796         // report type error
1797         verify_error(ctx, "Instruction type does not match stack map");
1798         return 0;
1799       }
1800       stackmap_index++;
1801     } else if (this_offset < bci) {
1802       // current_offset should have met this_offset.
1803       class_format_error("Bad stack map offset %d", this_offset);
1804       return 0;
1805     }
1806   } else if (no_control_flow) {
1807     verify_error(ErrorContext::bad_code(bci), "Expecting a stack map frame");
1808     return 0;
1809   }
1810   return stackmap_index;
1811 }
1812 
1813 void ClassVerifier::verify_exception_handler_targets(u2 bci, bool this_uninit, StackMapFrame* current_frame,
1814                                                      StackMapTable* stackmap_table, TRAPS) {
1815   constantPoolHandle cp (THREAD, _method->constants());
1816   ExceptionTable exhandlers(_method());
1817   int exlength = exhandlers.length();
1818   for(int i = 0; i < exlength; i++) {
1819     //reacquire the table in case a GC happened
1820     ExceptionTable exhandlers(_method());
1821     u2 start_pc = exhandlers.start_pc(i);
1822     u2 end_pc = exhandlers.end_pc(i);
1823     u2 handler_pc = exhandlers.handler_pc(i);
1824     int catch_type_index = exhandlers.catch_type_index(i);
1825     if(bci >= start_pc && bci < end_pc) {
1826       u1 flags = current_frame->flags();
1827       if (this_uninit) {  flags |= FLAG_THIS_UNINIT; }
1828       StackMapFrame* new_frame = current_frame->frame_in_exception_handler(flags);
1829       if (catch_type_index != 0) {
1830         // We know that this index refers to a subclass of Throwable
1831         VerificationType catch_type = cp_index_to_type(
1832           catch_type_index, cp, CHECK_VERIFY(this));
1833         new_frame->push_stack(catch_type, CHECK_VERIFY(this));
1834       } else {
1835         VerificationType throwable =
1836           VerificationType::reference_type(vmSymbols::java_lang_Throwable());
1837         new_frame->push_stack(throwable, CHECK_VERIFY(this));
1838       }
1839       ErrorContext ctx;
1840       bool matches = stackmap_table->match_stackmap(
1841         new_frame, handler_pc, true, false, &ctx, CHECK_VERIFY(this));
1842       if (!matches) {
1843         verify_error(ctx, "Stack map does not match the one at "
1844             "exception handler %d", handler_pc);
1845         return;
1846       }
1847     }
1848   }
1849 }
1850 
1851 void ClassVerifier::verify_cp_index(
1852     u2 bci, constantPoolHandle cp, int index, TRAPS) {
1853   int nconstants = cp->length();
1854   if ((index <= 0) || (index >= nconstants)) {
1855     verify_error(ErrorContext::bad_cp_index(bci, index),
1856         "Illegal constant pool index %d in class %s",
1857         index, cp->pool_holder()->external_name());
1858     return;
1859   }
1860 }
1861 
1862 void ClassVerifier::verify_cp_type(
1863     u2 bci, int index, constantPoolHandle cp, unsigned int types, TRAPS) {
1864 
1865   // In some situations, bytecode rewriting may occur while we're verifying.
1866   // In this case, a constant pool cache exists and some indices refer to that
1867   // instead.  Be sure we don't pick up such indices by accident.
1868   // We must check was_recursively_verified() before we get here.
1869   guarantee(cp->cache() == NULL, "not rewritten yet");
1870 
1871   verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1872   unsigned int tag = cp->tag_at(index).value();
1873   if ((types & (1 << tag)) == 0) {
1874     verify_error(ErrorContext::bad_cp_index(bci, index),
1875       "Illegal type at constant pool entry %d in class %s",
1876       index, cp->pool_holder()->external_name());
1877     return;
1878   }
1879 }
1880 
1881 void ClassVerifier::verify_cp_class_type(
1882     u2 bci, int index, constantPoolHandle cp, TRAPS) {
1883   verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1884   constantTag tag = cp->tag_at(index);
1885   if (!tag.is_klass() && !tag.is_unresolved_klass()) {
1886     verify_error(ErrorContext::bad_cp_index(bci, index),
1887         "Illegal type at constant pool entry %d in class %s",
1888         index, cp->pool_holder()->external_name());
1889     return;
1890   }
1891 }
1892 
1893 void ClassVerifier::verify_error(ErrorContext ctx, const char* msg, ...) {
1894   stringStream ss;
1895 
1896   ctx.reset_frames();
1897   _exception_type = vmSymbols::java_lang_VerifyError();
1898   _error_context = ctx;
1899   va_list va;
1900   va_start(va, msg);
1901   ss.vprint(msg, va);
1902   va_end(va);
1903   _message = ss.as_string();
1904 #ifdef ASSERT
1905   ResourceMark rm;
1906   const char* exception_name = _exception_type->as_C_string();
1907   Exceptions::debug_check_abort(exception_name, NULL);
1908 #endif // ndef ASSERT
1909 }
1910 
1911 void ClassVerifier::class_format_error(const char* msg, ...) {
1912   stringStream ss;
1913   _exception_type = vmSymbols::java_lang_ClassFormatError();
1914   va_list va;
1915   va_start(va, msg);
1916   ss.vprint(msg, va);
1917   va_end(va);
1918   if (!_method.is_null()) {
1919     ss.print(" in method %s", _method->name_and_sig_as_C_string());
1920   }
1921   _message = ss.as_string();
1922 }
1923 
1924 Klass* ClassVerifier::load_class(Symbol* name, TRAPS) {
1925   // Get current loader and protection domain first.
1926   oop loader = current_class()->class_loader();
1927   oop protection_domain = current_class()->protection_domain();
1928 
1929   return SystemDictionary::resolve_or_fail(
1930     name, Handle(THREAD, loader), Handle(THREAD, protection_domain),
1931     true, CHECK_NULL);
1932 }
1933 
1934 bool ClassVerifier::is_protected_access(instanceKlassHandle this_class,
1935                                         Klass* target_class,
1936                                         Symbol* field_name,
1937                                         Symbol* field_sig,
1938                                         bool is_method) {
1939   No_Safepoint_Verifier nosafepoint;
1940 
1941   // If target class isn't a super class of this class, we don't worry about this case
1942   if (!this_class->is_subclass_of(target_class)) {
1943     return false;
1944   }
1945   // Check if the specified method or field is protected
1946   InstanceKlass* target_instance = InstanceKlass::cast(target_class);
1947   fieldDescriptor fd;
1948   if (is_method) {
1949     Method* m = target_instance->uncached_lookup_method(field_name, field_sig, Klass::normal);
1950     if (m != NULL && m->is_protected()) {
1951       if (!this_class->is_same_class_package(m->method_holder())) {
1952         return true;
1953       }
1954     }
1955   } else {
1956     Klass* member_klass = target_instance->find_field(field_name, field_sig, &fd);
1957     if (member_klass != NULL && fd.is_protected()) {
1958       if (!this_class->is_same_class_package(member_klass)) {
1959         return true;
1960       }
1961     }
1962   }
1963   return false;
1964 }
1965 
1966 void ClassVerifier::verify_ldc(
1967     int opcode, u2 index, StackMapFrame* current_frame,
1968     constantPoolHandle cp, u2 bci, TRAPS) {
1969   verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1970   constantTag tag = cp->tag_at(index);
1971   unsigned int types;
1972   if (opcode == Bytecodes::_ldc || opcode == Bytecodes::_ldc_w) {
1973     if (!tag.is_unresolved_klass()) {
1974       types = (1 << JVM_CONSTANT_Integer) | (1 << JVM_CONSTANT_Float)
1975             | (1 << JVM_CONSTANT_String)  | (1 << JVM_CONSTANT_Class)
1976             | (1 << JVM_CONSTANT_MethodHandle) | (1 << JVM_CONSTANT_MethodType);
1977       // Note:  The class file parser already verified the legality of
1978       // MethodHandle and MethodType constants.
1979       verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1980     }
1981   } else {
1982     assert(opcode == Bytecodes::_ldc2_w, "must be ldc2_w");
1983     types = (1 << JVM_CONSTANT_Double) | (1 << JVM_CONSTANT_Long);
1984     verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1985   }
1986   if (tag.is_string() && cp->is_pseudo_string_at(index)) {
1987     current_frame->push_stack(object_type(), CHECK_VERIFY(this));
1988   } else if (tag.is_string()) {
1989     current_frame->push_stack(
1990       VerificationType::reference_type(
1991         vmSymbols::java_lang_String()), CHECK_VERIFY(this));
1992   } else if (tag.is_klass() || tag.is_unresolved_klass()) {
1993     current_frame->push_stack(
1994       VerificationType::reference_type(
1995         vmSymbols::java_lang_Class()), CHECK_VERIFY(this));
1996   } else if (tag.is_int()) {
1997     current_frame->push_stack(
1998       VerificationType::integer_type(), CHECK_VERIFY(this));
1999   } else if (tag.is_float()) {
2000     current_frame->push_stack(
2001       VerificationType::float_type(), CHECK_VERIFY(this));
2002   } else if (tag.is_double()) {
2003     current_frame->push_stack_2(
2004       VerificationType::double_type(),
2005       VerificationType::double2_type(), CHECK_VERIFY(this));
2006   } else if (tag.is_long()) {
2007     current_frame->push_stack_2(
2008       VerificationType::long_type(),
2009       VerificationType::long2_type(), CHECK_VERIFY(this));
2010   } else if (tag.is_method_handle()) {
2011     current_frame->push_stack(
2012       VerificationType::reference_type(
2013         vmSymbols::java_lang_invoke_MethodHandle()), CHECK_VERIFY(this));
2014   } else if (tag.is_method_type()) {
2015     current_frame->push_stack(
2016       VerificationType::reference_type(
2017         vmSymbols::java_lang_invoke_MethodType()), CHECK_VERIFY(this));
2018   } else {
2019     /* Unreachable? verify_cp_type has already validated the cp type. */
2020     verify_error(
2021         ErrorContext::bad_cp_index(bci, index), "Invalid index in ldc");
2022     return;
2023   }
2024 }
2025 
2026 void ClassVerifier::verify_switch(
2027     RawBytecodeStream* bcs, u4 code_length, char* code_data,
2028     StackMapFrame* current_frame, StackMapTable* stackmap_table, TRAPS) {
2029   int bci = bcs->bci();
2030   address bcp = bcs->bcp();
2031   address aligned_bcp = (address) round_to((intptr_t)(bcp + 1), jintSize);
2032 
2033   if (_klass->major_version() < NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION) {
2034     // 4639449 & 4647081: padding bytes must be 0
2035     u2 padding_offset = 1;
2036     while ((bcp + padding_offset) < aligned_bcp) {
2037       if(*(bcp + padding_offset) != 0) {
2038         verify_error(ErrorContext::bad_code(bci),
2039                      "Nonzero padding byte in lookupswitch or tableswitch");
2040         return;
2041       }
2042       padding_offset++;
2043     }
2044   }
2045 
2046   int default_offset = (int) Bytes::get_Java_u4(aligned_bcp);
2047   int keys, delta;
2048   current_frame->pop_stack(
2049     VerificationType::integer_type(), CHECK_VERIFY(this));
2050   if (bcs->raw_code() == Bytecodes::_tableswitch) {
2051     jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
2052     jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
2053     if (low > high) {
2054       verify_error(ErrorContext::bad_code(bci),
2055           "low must be less than or equal to high in tableswitch");
2056       return;
2057     }
2058     keys = high - low + 1;
2059     if (keys < 0) {
2060       verify_error(ErrorContext::bad_code(bci), "too many keys in tableswitch");
2061       return;
2062     }
2063     delta = 1;
2064   } else {
2065     keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
2066     if (keys < 0) {
2067       verify_error(ErrorContext::bad_code(bci),
2068                    "number of keys in lookupswitch less than 0");
2069       return;
2070     }
2071     delta = 2;
2072     // Make sure that the lookupswitch items are sorted
2073     for (int i = 0; i < (keys - 1); i++) {
2074       jint this_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i)*jintSize);
2075       jint next_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i+2)*jintSize);
2076       if (this_key >= next_key) {
2077         verify_error(ErrorContext::bad_code(bci),
2078                      "Bad lookupswitch instruction");
2079         return;
2080       }
2081     }
2082   }
2083   int target = bci + default_offset;
2084   stackmap_table->check_jump_target(current_frame, target, CHECK_VERIFY(this));
2085   for (int i = 0; i < keys; i++) {
2086     // Because check_jump_target() may safepoint, the bytecode could have
2087     // moved, which means 'aligned_bcp' is no good and needs to be recalculated.
2088     aligned_bcp = (address)round_to((intptr_t)(bcs->bcp() + 1), jintSize);
2089     target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
2090     stackmap_table->check_jump_target(
2091       current_frame, target, CHECK_VERIFY(this));
2092   }
2093   NOT_PRODUCT(aligned_bcp = NULL);  // no longer valid at this point
2094 }
2095 
2096 bool ClassVerifier::name_in_supers(
2097     Symbol* ref_name, instanceKlassHandle current) {
2098   Klass* super = current->super();
2099   while (super != NULL) {
2100     if (super->name() == ref_name) {
2101       return true;
2102     }
2103     super = super->super();
2104   }
2105   return false;
2106 }
2107 
2108 void ClassVerifier::verify_field_instructions(RawBytecodeStream* bcs,
2109                                               StackMapFrame* current_frame,
2110                                               constantPoolHandle cp,
2111                                               TRAPS) {
2112   u2 index = bcs->get_index_u2();
2113   verify_cp_type(bcs->bci(), index, cp,
2114       1 << JVM_CONSTANT_Fieldref, CHECK_VERIFY(this));
2115 
2116   // Get field name and signature
2117   Symbol* field_name = cp->name_ref_at(index);
2118   Symbol* field_sig = cp->signature_ref_at(index);
2119 
2120   if (!SignatureVerifier::is_valid_type_signature(field_sig)) {
2121     class_format_error(
2122       "Invalid signature for field in class %s referenced "
2123       "from constant pool index %d", _klass->external_name(), index);
2124     return;
2125   }
2126 
2127   // Get referenced class type
2128   VerificationType ref_class_type = cp_ref_index_to_type(
2129     index, cp, CHECK_VERIFY(this));
2130   if (!ref_class_type.is_object()) {
2131     /* Unreachable?  Class file parser verifies Fieldref contents */
2132     verify_error(ErrorContext::bad_type(bcs->bci(),
2133         TypeOrigin::cp(index, ref_class_type)),
2134         "Expecting reference to class in class %s at constant pool index %d",
2135         _klass->external_name(), index);
2136     return;
2137   }
2138   VerificationType target_class_type = ref_class_type;
2139 
2140   assert(sizeof(VerificationType) == sizeof(uintptr_t),
2141         "buffer type must match VerificationType size");
2142   uintptr_t field_type_buffer[2];
2143   VerificationType* field_type = (VerificationType*)field_type_buffer;
2144   // If we make a VerificationType[2] array directly, the compiler calls
2145   // to the c-runtime library to do the allocation instead of just
2146   // stack allocating it.  Plus it would run constructors.  This shows up
2147   // in performance profiles.
2148 
2149   SignatureStream sig_stream(field_sig, false);
2150   VerificationType stack_object_type;
2151   int n = change_sig_to_verificationType(
2152     &sig_stream, field_type, CHECK_VERIFY(this));
2153   u2 bci = bcs->bci();
2154   bool is_assignable;
2155   switch (bcs->raw_code()) {
2156     case Bytecodes::_getstatic: {
2157       for (int i = 0; i < n; i++) {
2158         current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
2159       }
2160       break;
2161     }
2162     case Bytecodes::_putstatic: {
2163       for (int i = n - 1; i >= 0; i--) {
2164         current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
2165       }
2166       break;
2167     }
2168     case Bytecodes::_getfield: {
2169       stack_object_type = current_frame->pop_stack(
2170         target_class_type, CHECK_VERIFY(this));
2171       for (int i = 0; i < n; i++) {
2172         current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
2173       }
2174       goto check_protected;
2175     }
2176     case Bytecodes::_putfield: {
2177       for (int i = n - 1; i >= 0; i--) {
2178         current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
2179       }
2180       stack_object_type = current_frame->pop_stack(CHECK_VERIFY(this));
2181 
2182       // The JVMS 2nd edition allows field initialization before the superclass
2183       // initializer, if the field is defined within the current class.
2184       fieldDescriptor fd;
2185       if (stack_object_type == VerificationType::uninitialized_this_type() &&
2186           target_class_type.equals(current_type()) &&
2187           _klass->find_local_field(field_name, field_sig, &fd)) {
2188         stack_object_type = current_type();
2189       }
2190       is_assignable = target_class_type.is_assignable_from(
2191         stack_object_type, this, CHECK_VERIFY(this));
2192       if (!is_assignable) {
2193         verify_error(ErrorContext::bad_type(bci,
2194             current_frame->stack_top_ctx(),
2195             TypeOrigin::cp(index, target_class_type)),
2196             "Bad type on operand stack in putfield");
2197         return;
2198       }
2199     }
2200     check_protected: {
2201       if (_this_type == stack_object_type)
2202         break; // stack_object_type must be assignable to _current_class_type
2203       Symbol* ref_class_name =
2204         cp->klass_name_at(cp->klass_ref_index_at(index));
2205       if (!name_in_supers(ref_class_name, current_class()))
2206         // stack_object_type must be assignable to _current_class_type since:
2207         // 1. stack_object_type must be assignable to ref_class.
2208         // 2. ref_class must be _current_class or a subclass of it. It can't
2209         //    be a superclass of it. See revised JVMS 5.4.4.
2210         break;
2211 
2212       Klass* ref_class_oop = load_class(ref_class_name, CHECK);
2213       if (is_protected_access(current_class(), ref_class_oop, field_name,
2214                               field_sig, false)) {
2215         // It's protected access, check if stack object is assignable to
2216         // current class.
2217         is_assignable = current_type().is_assignable_from(
2218           stack_object_type, this, CHECK_VERIFY(this));
2219         if (!is_assignable) {
2220           verify_error(ErrorContext::bad_type(bci,
2221               current_frame->stack_top_ctx(),
2222               TypeOrigin::implicit(current_type())),
2223               "Bad access to protected data in getfield");
2224           return;
2225         }
2226       }
2227       break;
2228     }
2229     default: ShouldNotReachHere();
2230   }
2231 }
2232 
2233 void ClassVerifier::verify_invoke_init(
2234     RawBytecodeStream* bcs, u2 ref_class_index, VerificationType ref_class_type,
2235     StackMapFrame* current_frame, u4 code_length, bool *this_uninit,
2236     constantPoolHandle cp, TRAPS) {
2237   u2 bci = bcs->bci();
2238   VerificationType type = current_frame->pop_stack(
2239     VerificationType::reference_check(), CHECK_VERIFY(this));
2240   if (type == VerificationType::uninitialized_this_type()) {
2241     // The method must be an <init> method of this class or its superclass
2242     Klass* superk = current_class()->super();
2243     if (ref_class_type.name() != current_class()->name() &&
2244         ref_class_type.name() != superk->name()) {
2245       verify_error(ErrorContext::bad_type(bci,
2246           TypeOrigin::implicit(ref_class_type),
2247           TypeOrigin::implicit(current_type())),
2248           "Bad <init> method call");
2249       return;
2250     }
2251     current_frame->initialize_object(type, current_type());
2252     *this_uninit = true;
2253   } else if (type.is_uninitialized()) {
2254     u2 new_offset = type.bci();
2255     address new_bcp = bcs->bcp() - bci + new_offset;
2256     if (new_offset > (code_length - 3) || (*new_bcp) != Bytecodes::_new) {
2257       /* Unreachable?  Stack map parsing ensures valid type and new
2258        * instructions have a valid BCI. */
2259       verify_error(ErrorContext::bad_code(new_offset),
2260                    "Expecting new instruction");
2261       return;
2262     }
2263     u2 new_class_index = Bytes::get_Java_u2(new_bcp + 1);
2264     verify_cp_class_type(bci, new_class_index, cp, CHECK_VERIFY(this));
2265 
2266     // The method must be an <init> method of the indicated class
2267     VerificationType new_class_type = cp_index_to_type(
2268       new_class_index, cp, CHECK_VERIFY(this));
2269     if (!new_class_type.equals(ref_class_type)) {
2270       verify_error(ErrorContext::bad_type(bci,
2271           TypeOrigin::cp(new_class_index, new_class_type),
2272           TypeOrigin::cp(ref_class_index, ref_class_type)),
2273           "Call to wrong <init> method");
2274       return;
2275     }
2276     // According to the VM spec, if the referent class is a superclass of the
2277     // current class, and is in a different runtime package, and the method is
2278     // protected, then the objectref must be the current class or a subclass
2279     // of the current class.
2280     VerificationType objectref_type = new_class_type;
2281     if (name_in_supers(ref_class_type.name(), current_class())) {
2282       Klass* ref_klass = load_class(
2283         ref_class_type.name(), CHECK_VERIFY(this));
2284       Method* m = InstanceKlass::cast(ref_klass)->uncached_lookup_method(
2285         vmSymbols::object_initializer_name(),
2286         cp->signature_ref_at(bcs->get_index_u2()),
2287         Klass::normal);
2288       instanceKlassHandle mh(THREAD, m->method_holder());
2289       if (m->is_protected() && !mh->is_same_class_package(_klass())) {
2290         bool assignable = current_type().is_assignable_from(
2291           objectref_type, this, CHECK_VERIFY(this));
2292         if (!assignable) {
2293           verify_error(ErrorContext::bad_type(bci,
2294               TypeOrigin::cp(new_class_index, objectref_type),
2295               TypeOrigin::implicit(current_type())),
2296               "Bad access to protected <init> method");
2297           return;
2298         }
2299       }
2300     }
2301     current_frame->initialize_object(type, new_class_type);
2302   } else {
2303     verify_error(ErrorContext::bad_type(bci, current_frame->stack_top_ctx()),
2304         "Bad operand type when invoking <init>");
2305     return;
2306   }
2307 }
2308 
2309 bool ClassVerifier::is_same_or_direct_interface(
2310     instanceKlassHandle klass,
2311     VerificationType klass_type,
2312     VerificationType ref_class_type) {
2313   if (ref_class_type.equals(klass_type)) return true;
2314   Array<Klass*>* local_interfaces = klass->local_interfaces();
2315   if (local_interfaces != NULL) {
2316     for (int x = 0; x < local_interfaces->length(); x++) {
2317       Klass* k = local_interfaces->at(x);
2318       assert (k != NULL && k->is_interface(), "invalid interface");
2319       if (ref_class_type.equals(VerificationType::reference_type(k->name()))) {
2320         return true;
2321       }
2322     }
2323   }
2324   return false;
2325 }
2326 
2327 void ClassVerifier::verify_invoke_instructions(
2328     RawBytecodeStream* bcs, u4 code_length, StackMapFrame* current_frame,
2329     bool *this_uninit, VerificationType return_type,
2330     constantPoolHandle cp, TRAPS) {
2331   // Make sure the constant pool item is the right type
2332   u2 index = bcs->get_index_u2();
2333   Bytecodes::Code opcode = bcs->raw_code();
2334   unsigned int types;
2335   switch (opcode) {
2336     case Bytecodes::_invokeinterface:
2337       types = 1 << JVM_CONSTANT_InterfaceMethodref;
2338       break;
2339     case Bytecodes::_invokedynamic:
2340       types = 1 << JVM_CONSTANT_InvokeDynamic;
2341       break;
2342     case Bytecodes::_invokespecial:
2343     case Bytecodes::_invokestatic:
2344       types = (_klass->major_version() < STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION) ?
2345         (1 << JVM_CONSTANT_Methodref) :
2346         ((1 << JVM_CONSTANT_InterfaceMethodref) | (1 << JVM_CONSTANT_Methodref));
2347       break;
2348     default:
2349       types = 1 << JVM_CONSTANT_Methodref;
2350   }
2351   verify_cp_type(bcs->bci(), index, cp, types, CHECK_VERIFY(this));
2352 
2353   // Get method name and signature
2354   Symbol* method_name = cp->name_ref_at(index);
2355   Symbol* method_sig = cp->signature_ref_at(index);
2356 
2357   if (!SignatureVerifier::is_valid_method_signature(method_sig)) {
2358     class_format_error(
2359       "Invalid method signature in class %s referenced "
2360       "from constant pool index %d", _klass->external_name(), index);
2361     return;
2362   }
2363 
2364   // Get referenced class type
2365   VerificationType ref_class_type;
2366   if (opcode == Bytecodes::_invokedynamic) {
2367     if (_klass->major_version() < Verifier::INVOKEDYNAMIC_MAJOR_VERSION) {
2368       class_format_error(
2369         "invokedynamic instructions not supported by this class file version (%d), class %s",
2370         _klass->major_version(), _klass->external_name());
2371       return;
2372     }
2373   } else {
2374     ref_class_type = cp_ref_index_to_type(index, cp, CHECK_VERIFY(this));
2375   }
2376 
2377   // For a small signature length, we just allocate 128 bytes instead
2378   // of parsing the signature once to find its size.
2379   // -3 is for '(', ')' and return descriptor; multiply by 2 is for
2380   // longs/doubles to be consertive.
2381   assert(sizeof(VerificationType) == sizeof(uintptr_t),
2382         "buffer type must match VerificationType size");
2383   uintptr_t on_stack_sig_types_buffer[128];
2384   // If we make a VerificationType[128] array directly, the compiler calls
2385   // to the c-runtime library to do the allocation instead of just
2386   // stack allocating it.  Plus it would run constructors.  This shows up
2387   // in performance profiles.
2388 
2389   VerificationType* sig_types;
2390   int size = (method_sig->utf8_length() - 3) * 2;
2391   if (size > 128) {
2392     // Long and double occupies two slots here.
2393     ArgumentSizeComputer size_it(method_sig);
2394     size = size_it.size();
2395     sig_types = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, VerificationType, size);
2396   } else{
2397     sig_types = (VerificationType*)on_stack_sig_types_buffer;
2398   }
2399   SignatureStream sig_stream(method_sig);
2400   int sig_i = 0;
2401   while (!sig_stream.at_return_type()) {
2402     sig_i += change_sig_to_verificationType(
2403       &sig_stream, &sig_types[sig_i], CHECK_VERIFY(this));
2404     sig_stream.next();
2405   }
2406   int nargs = sig_i;
2407 
2408 #ifdef ASSERT
2409   {
2410     ArgumentSizeComputer size_it(method_sig);
2411     assert(nargs == size_it.size(), "Argument sizes do not match");
2412     assert(nargs <= (method_sig->utf8_length() - 3) * 2, "estimate of max size isn't conservative enough");
2413   }
2414 #endif
2415 
2416   // Check instruction operands
2417   u2 bci = bcs->bci();
2418   if (opcode == Bytecodes::_invokeinterface) {
2419     address bcp = bcs->bcp();
2420     // 4905268: count operand in invokeinterface should be nargs+1, not nargs.
2421     // JSR202 spec: The count operand of an invokeinterface instruction is valid if it is
2422     // the difference between the size of the operand stack before and after the instruction
2423     // executes.
2424     if (*(bcp+3) != (nargs+1)) {
2425       verify_error(ErrorContext::bad_code(bci),
2426           "Inconsistent args count operand in invokeinterface");
2427       return;
2428     }
2429     if (*(bcp+4) != 0) {
2430       verify_error(ErrorContext::bad_code(bci),
2431           "Fourth operand byte of invokeinterface must be zero");
2432       return;
2433     }
2434   }
2435 
2436   if (opcode == Bytecodes::_invokedynamic) {
2437     address bcp = bcs->bcp();
2438     if (*(bcp+3) != 0 || *(bcp+4) != 0) {
2439       verify_error(ErrorContext::bad_code(bci),
2440           "Third and fourth operand bytes of invokedynamic must be zero");
2441       return;
2442     }
2443   }
2444 
2445   if (method_name->byte_at(0) == '<') {
2446     // Make sure <init> can only be invoked by invokespecial
2447     if (opcode != Bytecodes::_invokespecial ||
2448         method_name != vmSymbols::object_initializer_name()) {
2449       verify_error(ErrorContext::bad_code(bci),
2450           "Illegal call to internal method");
2451       return;
2452     }
2453   } else if (opcode == Bytecodes::_invokespecial
2454              && !is_same_or_direct_interface(current_class(), current_type(), ref_class_type)
2455              && !ref_class_type.equals(VerificationType::reference_type(
2456                   current_class()->super()->name()))) {
2457     bool subtype = false;
2458     bool have_imr_indirect = cp->tag_at(index).value() == JVM_CONSTANT_InterfaceMethodref;
2459     if (!current_class()->is_anonymous()) {
2460       subtype = ref_class_type.is_assignable_from(
2461                  current_type(), this, CHECK_VERIFY(this));
2462     } else {
2463       VerificationType host_klass_type =
2464                         VerificationType::reference_type(current_class()->host_klass()->name());
2465       subtype = ref_class_type.is_assignable_from(host_klass_type, this, CHECK_VERIFY(this));
2466 
2467       // If invokespecial of IMR, need to recheck for same or
2468       // direct interface relative to the host class
2469       have_imr_indirect = (have_imr_indirect &&
2470                            !is_same_or_direct_interface(
2471                              InstanceKlass::cast(current_class()->host_klass()),
2472                              host_klass_type, ref_class_type));
2473     }
2474     if (!subtype) {
2475       verify_error(ErrorContext::bad_code(bci),
2476           "Bad invokespecial instruction: "
2477           "current class isn't assignable to reference class.");
2478        return;
2479     } else if (have_imr_indirect) {
2480       verify_error(ErrorContext::bad_code(bci),
2481           "Bad invokespecial instruction: "
2482           "interface method reference is in an indirect superinterface.");
2483       return;
2484     }
2485 
2486   }
2487   // Match method descriptor with operand stack
2488   for (int i = nargs - 1; i >= 0; i--) {  // Run backwards
2489     current_frame->pop_stack(sig_types[i], CHECK_VERIFY(this));
2490   }
2491   // Check objectref on operand stack
2492   if (opcode != Bytecodes::_invokestatic &&
2493       opcode != Bytecodes::_invokedynamic) {
2494     if (method_name == vmSymbols::object_initializer_name()) {  // <init> method
2495       verify_invoke_init(bcs, index, ref_class_type, current_frame,
2496         code_length, this_uninit, cp, CHECK_VERIFY(this));
2497     } else {   // other methods
2498       // Ensures that target class is assignable to method class.
2499       if (opcode == Bytecodes::_invokespecial) {
2500         if (!current_class()->is_anonymous()) {
2501           current_frame->pop_stack(current_type(), CHECK_VERIFY(this));
2502         } else {
2503           // anonymous class invokespecial calls: check if the
2504           // objectref is a subtype of the host_klass of the current class
2505           // to allow an anonymous class to reference methods in the host_klass
2506           VerificationType top = current_frame->pop_stack(CHECK_VERIFY(this));
2507           VerificationType hosttype =
2508             VerificationType::reference_type(current_class()->host_klass()->name());
2509           bool subtype = hosttype.is_assignable_from(top, this, CHECK_VERIFY(this));
2510           if (!subtype) {
2511             verify_error( ErrorContext::bad_type(current_frame->offset(),
2512               current_frame->stack_top_ctx(),
2513               TypeOrigin::implicit(top)),
2514               "Bad type on operand stack");
2515             return;
2516           }
2517         }
2518       } else if (opcode == Bytecodes::_invokevirtual) {
2519         VerificationType stack_object_type =
2520           current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
2521         if (current_type() != stack_object_type) {
2522           assert(cp->cache() == NULL, "not rewritten yet");
2523           Symbol* ref_class_name =
2524             cp->klass_name_at(cp->klass_ref_index_at(index));
2525           // See the comments in verify_field_instructions() for
2526           // the rationale behind this.
2527           if (name_in_supers(ref_class_name, current_class())) {
2528             Klass* ref_class = load_class(ref_class_name, CHECK);
2529             if (is_protected_access(
2530                   _klass, ref_class, method_name, method_sig, true)) {
2531               // It's protected access, check if stack object is
2532               // assignable to current class.
2533               bool is_assignable = current_type().is_assignable_from(
2534                 stack_object_type, this, CHECK_VERIFY(this));
2535               if (!is_assignable) {
2536                 if (ref_class_type.name() == vmSymbols::java_lang_Object()
2537                     && stack_object_type.is_array()
2538                     && method_name == vmSymbols::clone_name()) {
2539                   // Special case: arrays pretend to implement public Object
2540                   // clone().
2541                 } else {
2542                   verify_error(ErrorContext::bad_type(bci,
2543                       current_frame->stack_top_ctx(),
2544                       TypeOrigin::implicit(current_type())),
2545                       "Bad access to protected data in invokevirtual");
2546                   return;
2547                 }
2548               }
2549             }
2550           }
2551         }
2552       } else {
2553         assert(opcode == Bytecodes::_invokeinterface, "Unexpected opcode encountered");
2554         current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
2555       }
2556     }
2557   }
2558   // Push the result type.
2559   if (sig_stream.type() != T_VOID) {
2560     if (method_name == vmSymbols::object_initializer_name()) {
2561       // <init> method must have a void return type
2562       /* Unreachable?  Class file parser verifies that methods with '<' have
2563        * void return */
2564       verify_error(ErrorContext::bad_code(bci),
2565           "Return type must be void in <init> method");
2566       return;
2567     }
2568     VerificationType return_type[2];
2569     int n = change_sig_to_verificationType(
2570       &sig_stream, return_type, CHECK_VERIFY(this));
2571     for (int i = 0; i < n; i++) {
2572       current_frame->push_stack(return_type[i], CHECK_VERIFY(this)); // push types backwards
2573     }
2574   }
2575 }
2576 
2577 VerificationType ClassVerifier::get_newarray_type(
2578     u2 index, u2 bci, TRAPS) {
2579   const char* from_bt[] = {
2580     NULL, NULL, NULL, NULL, "[Z", "[C", "[F", "[D", "[B", "[S", "[I", "[J",
2581   };
2582   if (index < T_BOOLEAN || index > T_LONG) {
2583     verify_error(ErrorContext::bad_code(bci), "Illegal newarray instruction");
2584     return VerificationType::bogus_type();
2585   }
2586 
2587   // from_bt[index] contains the array signature which has a length of 2
2588   Symbol* sig = create_temporary_symbol(
2589     from_bt[index], 2, CHECK_(VerificationType::bogus_type()));
2590   return VerificationType::reference_type(sig);
2591 }
2592 
2593 void ClassVerifier::verify_anewarray(
2594     u2 bci, u2 index, constantPoolHandle cp,
2595     StackMapFrame* current_frame, TRAPS) {
2596   verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
2597   current_frame->pop_stack(
2598     VerificationType::integer_type(), CHECK_VERIFY(this));
2599 
2600   VerificationType component_type =
2601     cp_index_to_type(index, cp, CHECK_VERIFY(this));
2602   int length;
2603   char* arr_sig_str;
2604   if (component_type.is_array()) {     // it's an array
2605     const char* component_name = component_type.name()->as_utf8();
2606     // add one dimension to component
2607     length = (int)strlen(component_name) + 1;
2608     arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
2609     arr_sig_str[0] = '[';
2610     strncpy(&arr_sig_str[1], component_name, length - 1);
2611   } else {         // it's an object or interface
2612     const char* component_name = component_type.name()->as_utf8();
2613     // add one dimension to component with 'L' prepended and ';' postpended.
2614     length = (int)strlen(component_name) + 3;
2615     arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
2616     arr_sig_str[0] = '[';
2617     arr_sig_str[1] = 'L';
2618     strncpy(&arr_sig_str[2], component_name, length - 2);
2619     arr_sig_str[length - 1] = ';';
2620   }
2621   Symbol* arr_sig = create_temporary_symbol(
2622     arr_sig_str, length, CHECK_VERIFY(this));
2623   VerificationType new_array_type = VerificationType::reference_type(arr_sig);
2624   current_frame->push_stack(new_array_type, CHECK_VERIFY(this));
2625 }
2626 
2627 void ClassVerifier::verify_iload(u2 index, StackMapFrame* current_frame, TRAPS) {
2628   current_frame->get_local(
2629     index, VerificationType::integer_type(), CHECK_VERIFY(this));
2630   current_frame->push_stack(
2631     VerificationType::integer_type(), CHECK_VERIFY(this));
2632 }
2633 
2634 void ClassVerifier::verify_lload(u2 index, StackMapFrame* current_frame, TRAPS) {
2635   current_frame->get_local_2(
2636     index, VerificationType::long_type(),
2637     VerificationType::long2_type(), CHECK_VERIFY(this));
2638   current_frame->push_stack_2(
2639     VerificationType::long_type(),
2640     VerificationType::long2_type(), CHECK_VERIFY(this));
2641 }
2642 
2643 void ClassVerifier::verify_fload(u2 index, StackMapFrame* current_frame, TRAPS) {
2644   current_frame->get_local(
2645     index, VerificationType::float_type(), CHECK_VERIFY(this));
2646   current_frame->push_stack(
2647     VerificationType::float_type(), CHECK_VERIFY(this));
2648 }
2649 
2650 void ClassVerifier::verify_dload(u2 index, StackMapFrame* current_frame, TRAPS) {
2651   current_frame->get_local_2(
2652     index, VerificationType::double_type(),
2653     VerificationType::double2_type(), CHECK_VERIFY(this));
2654   current_frame->push_stack_2(
2655     VerificationType::double_type(),
2656     VerificationType::double2_type(), CHECK_VERIFY(this));
2657 }
2658 
2659 void ClassVerifier::verify_aload(u2 index, StackMapFrame* current_frame, TRAPS) {
2660   VerificationType type = current_frame->get_local(
2661     index, VerificationType::reference_check(), CHECK_VERIFY(this));
2662   current_frame->push_stack(type, CHECK_VERIFY(this));
2663 }
2664 
2665 void ClassVerifier::verify_istore(u2 index, StackMapFrame* current_frame, TRAPS) {
2666   current_frame->pop_stack(
2667     VerificationType::integer_type(), CHECK_VERIFY(this));
2668   current_frame->set_local(
2669     index, VerificationType::integer_type(), CHECK_VERIFY(this));
2670 }
2671 
2672 void ClassVerifier::verify_lstore(u2 index, StackMapFrame* current_frame, TRAPS) {
2673   current_frame->pop_stack_2(
2674     VerificationType::long2_type(),
2675     VerificationType::long_type(), CHECK_VERIFY(this));
2676   current_frame->set_local_2(
2677     index, VerificationType::long_type(),
2678     VerificationType::long2_type(), CHECK_VERIFY(this));
2679 }
2680 
2681 void ClassVerifier::verify_fstore(u2 index, StackMapFrame* current_frame, TRAPS) {
2682   current_frame->pop_stack(VerificationType::float_type(), CHECK_VERIFY(this));
2683   current_frame->set_local(
2684     index, VerificationType::float_type(), CHECK_VERIFY(this));
2685 }
2686 
2687 void ClassVerifier::verify_dstore(u2 index, StackMapFrame* current_frame, TRAPS) {
2688   current_frame->pop_stack_2(
2689     VerificationType::double2_type(),
2690     VerificationType::double_type(), CHECK_VERIFY(this));
2691   current_frame->set_local_2(
2692     index, VerificationType::double_type(),
2693     VerificationType::double2_type(), CHECK_VERIFY(this));
2694 }
2695 
2696 void ClassVerifier::verify_astore(u2 index, StackMapFrame* current_frame, TRAPS) {
2697   VerificationType type = current_frame->pop_stack(
2698     VerificationType::reference_check(), CHECK_VERIFY(this));
2699   current_frame->set_local(index, type, CHECK_VERIFY(this));
2700 }
2701 
2702 void ClassVerifier::verify_iinc(u2 index, StackMapFrame* current_frame, TRAPS) {
2703   VerificationType type = current_frame->get_local(
2704     index, VerificationType::integer_type(), CHECK_VERIFY(this));
2705   current_frame->set_local(index, type, CHECK_VERIFY(this));
2706 }
2707 
2708 void ClassVerifier::verify_return_value(
2709     VerificationType return_type, VerificationType type, u2 bci,
2710     StackMapFrame* current_frame, TRAPS) {
2711   if (return_type == VerificationType::bogus_type()) {
2712     verify_error(ErrorContext::bad_type(bci,
2713         current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
2714         "Method expects a return value");
2715     return;
2716   }
2717   bool match = return_type.is_assignable_from(type, this, CHECK_VERIFY(this));
2718   if (!match) {
2719     verify_error(ErrorContext::bad_type(bci,
2720         current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
2721         "Bad return type");
2722     return;
2723   }
2724 }
2725 
2726 // The verifier creates symbols which are substrings of Symbols.
2727 // These are stored in the verifier until the end of verification so that
2728 // they can be reference counted.
2729 Symbol* ClassVerifier::create_temporary_symbol(const Symbol *s, int begin,
2730                                                int end, TRAPS) {
2731   Symbol* sym = SymbolTable::new_symbol(s, begin, end, CHECK_NULL);
2732   _symbols->push(sym);
2733   return sym;
2734 }
2735 
2736 Symbol* ClassVerifier::create_temporary_symbol(const char *s, int length, TRAPS) {
2737   Symbol* sym = SymbolTable::new_symbol(s, length, CHECK_NULL);
2738   _symbols->push(sym);
2739   return sym;
2740 }