Code Review for open

Prepared by:coleenp on Tue Oct 10 17:38:04 EDT 2017
Workspace:/scratch/cphillim/hg/10ptr/open
Compare against version:qparent
Summary of changes: 424 lines changed: 29 ins; 107 del; 288 mod; 105653 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp

rev 47400 : [mq]: cmpxchg_ptr
4 lines changed: 0 ins; 0 del; 4 mod; 2427 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/vm_version_ppc.cpp

rev 47400 : [mq]: cmpxchg_ptr
2 lines changed: 0 ins; 1 del; 1 mod; 823 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/interp_masm_s390.cpp

rev 47400 : [mq]: cmpxchg_ptr
4 lines changed: 0 ins; 0 del; 4 mod; 2147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/vm_version_s390.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 1235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

rev 47402 : [mq]: xchg_ptr
4 lines changed: 0 ins; 0 del; 4 mod; 5210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/zero/cppInterpreter_zero.cpp

rev 47400 : [mq]: cmpxchg_ptr
2 lines changed: 0 ins; 0 del; 2 mod; 822 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/zero/stubGenerator_zero.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47402 : [mq]: xchg_ptr
2 lines changed: 0 ins; 1 del; 1 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp

rev 47402 : [mq]: xchg_ptr
2 lines changed: 0 ins; 0 del; 2 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp

rev 47402 : [mq]: xchg_ptr
2 lines changed: 0 ins; 0 del; 2 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp

rev 47402 : [mq]: xchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp

rev 47402 : [mq]: xchg_ptr
5 lines changed: 0 ins; 0 del; 5 mod; 667 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/windows_x86/os_windows_x86.hpp

rev 47402 : [mq]: xchg_ptr
2 lines changed: 0 ins; 0 del; 2 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/asm/assembler.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
rev 47406 : [mq]: assembler_cmpxchg
3 lines changed: 0 ins; 2 del; 1 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.hpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
4 lines changed: 0 ins; 2 del; 2 mod; 546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
29 lines changed: 0 ins; 5 del; 24 mod; 1435 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/dictionary.hpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
2 lines changed: 0 ins; 0 del; 2 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verifier.cpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
3 lines changed: 0 ins; 0 del; 3 mod; 3082 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/compiledMethod.hpp

rev 47406 : [mq]: assembler_cmpxchg
1 line changed: 0 ins; 0 del; 1 mod; 404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/nmethod.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
11 lines changed: 0 ins; 3 del; 8 mod; 2986 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp

rev 47399 : [mq]: add_ptr
rev 47400 : [mq]: cmpxchg_ptr
rev 47402 : [mq]: xchg_ptr
10 lines changed: 0 ins; 0 del; 10 mod; 8141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

rev 47399 : [mq]: add_ptr
rev 47400 : [mq]: cmpxchg_ptr
rev 47402 : [mq]: xchg_ptr
8 lines changed: 0 ins; 0 del; 8 mod; 1469 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/dirtyCardQueue.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CodeCacheRemSet.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
4 lines changed: 0 ins; 0 del; 4 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 47400 : [mq]: cmpxchg_ptr
3 lines changed: 0 ins; 0 del; 3 mod; 5368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 3019 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1EvacStats.inline.hpp

rev 47399 : [mq]: add_ptr
5 lines changed: 0 ins; 0 del; 5 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1HotCardCache.cpp

rev 47400 : [mq]: cmpxchg_ptr
3 lines changed: 0 ins; 0 del; 3 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp

rev 47399 : [mq]: add_ptr
1 line changed: 0 ins; 0 del; 1 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1StringDedup.cpp

rev 47399 : [mq]: add_ptr
2 lines changed: 0 ins; 0 del; 2 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.inline.hpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegionRemSet.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
8 lines changed: 0 ins; 3 del; 5 mod; 965 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/sparsePRT.cpp

rev 47400 : [mq]: cmpxchg_ptr
4 lines changed: 0 ins; 2 del; 2 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/gcTaskThread.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
2 lines changed: 0 ins; 1 del; 1 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/mutableNUMASpace.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 999 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/mutableSpace.cpp

rev 47400 : [mq]: cmpxchg_ptr
2 lines changed: 0 ins; 0 del; 2 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parMarkBitMap.cpp

rev 47399 : [mq]: add_ptr
1 line changed: 0 ins; 0 del; 1 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp

rev 47399 : [mq]: add_ptr
1 line changed: 0 ins; 0 del; 1 mod; 3179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.hpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 1331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/plab.inline.hpp

rev 47399 : [mq]: add_ptr
4 lines changed: 0 ins; 0 del; 4 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 768 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.inline.hpp

rev 47400 : [mq]: cmpxchg_ptr
3 lines changed: 0 ins; 0 del; 3 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecodeInterpreter.cpp

rev 47400 : [mq]: cmpxchg_ptr
16 lines changed: 0 ins; 0 del; 16 mod; 3433 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/oopMapCache.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47404 : [mq]: load_ptr_acquire
3 lines changed: 0 ins; 0 del; 3 mod; 599 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

rev 47399 : [mq]: add_ptr
rev 47400 : [mq]: cmpxchg_ptr
rev 47404 : [mq]: load_ptr_acquire
10 lines changed: 0 ins; 1 del; 9 mod; 4280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.cpp

rev 47402 : [mq]: xchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 1392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/arrayKlass.inline.hpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/constantPool.cpp

rev 47406 : [mq]: assembler_cmpxchg
3 lines changed: 0 ins; 0 del; 3 mod; 2304 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/constantPool.hpp

rev 47404 : [mq]: load_ptr_acquire
2 lines changed: 0 ins; 0 del; 2 mod; 1030 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47406 : [mq]: assembler_cmpxchg
6 lines changed: 1 ins; 0 del; 5 mod; 782 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.hpp

rev 47404 : [mq]: load_ptr_acquire
2 lines changed: 0 ins; 0 del; 2 mod; 533 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
6 lines changed: 0 ins; 1 del; 5 mod; 3746 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.inline.hpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
4 lines changed: 0 ins; 0 del; 4 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
rev 47404 : [mq]: load_ptr_acquire
7 lines changed: 5 ins; 0 del; 2 mod; 2412 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.hpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
8 lines changed: 0 ins; 3 del; 5 mod; 1175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.hpp

rev 47406 : [mq]: assembler_cmpxchg
1 line changed: 0 ins; 0 del; 1 mod; 2631 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.inline.hpp

rev 47402 : [mq]: xchg_ptr
rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
14 lines changed: 0 ins; 0 del; 14 mod; 718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 1685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jni.cpp

rev 47402 : [mq]: xchg_ptr
rev 47403 : imported patch store_ptr
3 lines changed: 0 ins; 0 del; 3 mod; 4362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRawMonitor.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
rev 47406 : [mq]: assembler_cmpxchg
5 lines changed: 0 ins; 0 del; 5 mod; 419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRawMonitor.hpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
0 lines changed: 0 ins; 0 del; 0 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/atomic.hpp

rev 47399 : [mq]: add_ptr
rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
rev 47402 : [mq]: xchg_ptr
rev 47403 : imported patch store_ptr
50 lines changed: 8 ins; 38 del; 4 mod; 875 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/mutex.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
rev 47407 : [mq]: casptr
20 lines changed: 0 ins; 6 del; 14 mod; 1384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
rev 47406 : [mq]: assembler_cmpxchg
17 lines changed: 0 ins; 0 del; 17 mod; 2434 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.hpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 1 ins; 0 del; 0 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.inline.hpp

rev 47400 : [mq]: cmpxchg_ptr
4 lines changed: 4 ins; 0 del; 0 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/orderAccess.hpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
9 lines changed: 0 ins; 9 del; 0 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/orderAccess.inline.hpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
15 lines changed: 0 ins; 15 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47402 : [mq]: xchg_ptr
2 lines changed: 0 ins; 1 del; 1 mod; 598 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.hpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47402 : [mq]: xchg_ptr
4 lines changed: 0 ins; 2 del; 2 mod; 476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
14 lines changed: 0 ins; 6 del; 8 mod; 1975 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.hpp

rev 47404 : [mq]: load_ptr_acquire
4 lines changed: 1 ins; 2 del; 1 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

rev 47400 : [mq]: cmpxchg_ptr
12 lines changed: 0 ins; 0 del; 12 mod; 4855 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

rev 47404 : [mq]: load_ptr_acquire
6 lines changed: 5 ins; 0 del; 1 mod; 3431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/mallocSiteTable.cpp

rev 47400 : [mq]: cmpxchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
5 lines changed: 4 ins; 0 del; 1 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/mallocSiteTable.hpp

rev 47400 : [mq]: cmpxchg_ptr
4 lines changed: 0 ins; 3 del; 1 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/mallocTracker.hpp

rev 47399 : [mq]: add_ptr
1 line changed: 0 ins; 0 del; 1 mod; 379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryManager.cpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
3 lines changed: 0 ins; 0 del; 3 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryPool.cpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
3 lines changed: 0 ins; 0 del; 3 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.cpp

rev 47401 : [mq]: cmpxchg_if_null
1 line changed: 0 ins; 0 del; 1 mod; 682 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/hashtable.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/hashtable.inline.hpp

rev 47404 : [mq]: load_ptr_acquire
rev 47406 : [mq]: assembler_cmpxchg
2 lines changed: 0 ins; 0 del; 2 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/vmError.cpp

rev 47400 : [mq]: cmpxchg_ptr
1 line changed: 0 ins; 0 del; 1 mod; 1694 unchg

This code review page was prepared using /home/cphillim/bin/official-webrev/webrev.ksh (vers 25.14-hg+openjdk.java.net).