Code Review for open

Prepared by:coleenp on Thu Oct 12 12:07:20 EDT 2017
Workspace:/scratch/cphillim/hg/10ptr/open
Compare against version:casptr
Summary of changes: 34 lines changed: 1 ins; 2 del; 31 mod; 22477 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47406 : [mq]: assembler_cmpxchg
rev 47404 : [mq]: load_ptr_acquire
rev 47400 : [mq]: cmpxchg_ptr
rev 47322 : 8186777: Make Klass::_java_mirror an OopHandle
Summary: Add indirection for fetching mirror so that GC doesn't have to follow CLD::_klasses
Reviewed-by: hseigel, thartmann, eosterlund, stefank
Contributed-by: coleen.phillimore@oracle.com, rickard.backman@oracle.com
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 1458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.hpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47322 : 8186777: Make Klass::_java_mirror an OopHandle
Summary: Add indirection for fetching mirror so that GC doesn't have to follow CLD::_klasses
Reviewed-by: hseigel, thartmann, eosterlund, stefank
Contributed-by: coleen.phillimore@oracle.com, rickard.backman@oracle.com
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/nmethod.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
3 lines changed: 0 ins; 0 del; 3 mod; 2991 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47402 : [mq]: xchg_ptr
rev 47400 : [mq]: cmpxchg_ptr
rev 47399 : [mq]: add_ptr
rev 47322 : 8186777: Make Klass::_java_mirror an OopHandle
Summary: Add indirection for fetching mirror so that GC doesn't have to follow CLD::_klasses
Reviewed-by: hseigel, thartmann, eosterlund, stefank
Contributed-by: coleen.phillimore@oracle.com, rickard.backman@oracle.com
rev 47294 : 8186838: Generalize Atomic::inc/dec with templates
Reviewed-by: kbarrett, coleenp, dholmes
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 1476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47399 : [mq]: add_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/gcTaskThread.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.inline.hpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
3 lines changed: 0 ins; 2 del; 1 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47406 : [mq]: assembler_cmpxchg
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 0 ins; 0 del; 2 mod; 786 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.hpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47404 : [mq]: load_ptr_acquire
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 0 ins; 0 del; 2 mod; 533 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47404 : [mq]: load_ptr_acquire
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 2418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRawMonitor.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47406 : [mq]: assembler_cmpxchg
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 0 ins; 0 del; 2 mod; 422 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/atomic.hpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47403 : imported patch store_ptr
rev 47402 : [mq]: xchg_ptr
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47399 : [mq]: add_ptr
rev 47398 : 8188813: Generalize OrderAccess to use templates
Reviewed-by: dholmes, coleenp
rev 47382 : 8188224: Generalize Atomic::load/store to use templates
Reviewed-by: dholmes, coleenp
rev 47320 : 8187977: Generalize Atomic::xchg to use templates
Reviewed-by: kbarrett, coleenp
rev 47294 : 8186838: Generalize Atomic::inc/dec with templates
Reviewed-by: kbarrett, coleenp, dholmes
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 0 ins; 0 del; 2 mod; 885 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/mutex.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47407 : [mq]: casptr
rev 47406 : [mq]: assembler_cmpxchg
rev 47404 : [mq]: load_ptr_acquire
rev 47400 : [mq]: cmpxchg_ptr
rev 47398 : 8188813: Generalize OrderAccess to use templates
Reviewed-by: dholmes, coleenp
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 0 ins; 0 del; 2 mod; 1396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47406 : [mq]: assembler_cmpxchg
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
6 lines changed: 0 ins; 0 del; 6 mod; 2445 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.inline.hpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 1 ins; 0 del; 0 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47406 : [mq]: assembler_cmpxchg
rev 47404 : [mq]: load_ptr_acquire
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 1982 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

rev 47409 : [mq]: review_comments_erik_and_david
rev 47404 : [mq]: load_ptr_acquire
rev 47392 : Merge
rev 47391 : 8187403: [Unknown generation] is shown in Stack Memory on HSDB
Reviewed-by: sspitsyn, jgeorge
rev 47323 : Merge
rev 47322 : 8186777: Make Klass::_java_mirror an OopHandle
Summary: Add indirection for fetching mirror so that GC doesn't have to follow CLD::_klasses
Reviewed-by: hseigel, thartmann, eosterlund, stefank
Contributed-by: coleen.phillimore@oracle.com, rickard.backman@oracle.com
rev 47308 : 8187402: UnknownOopException is occurred on Stack Memory window in HSDB
Reviewed-by: sspitsyn, jgeorge
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 3436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/mallocSiteTable.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47401 : [mq]: cmpxchg_if_null
rev 47400 : [mq]: cmpxchg_ptr
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2 lines changed: 0 ins; 0 del; 2 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.cpp

rev 47408 : [mq]: no_cmpxchg_if_null
rev 47401 : [mq]: cmpxchg_if_null
rev 47216 : 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
1 line changed: 0 ins; 0 del; 1 mod; 682 unchg

This code review page was prepared using /home/cphillim/bin/official-webrev/webrev.ksh (vers 25.14-hg+openjdk.java.net).