Code Review for jdk9-hs3

Prepared by:ctornqvi on Thu Aug 11 12:51:40 EDT 2016
Workspace:/cygdrive/c/source/jdk9-hs3
Compare against: ssh://hg.openjdk.java.net/jdk9/hs
Summary of changes: 2751 lines changed: 2728 ins; 11 del; 12 mod; 9883 unchg
Patch of changes: jdk9-hs3.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/test/BuildTestLib.gmk

1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/ClassFileInstaller.java

257 lines changed: 257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/RedefineClassHelper.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/Asserts.java (was test/lib/share/classes/jdk/test/lib/Asserts.java)

0 lines changed: 0 ins; 0 del; 0 mod; 620 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/BuildHelper.java

106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/ByteCodeLoader.java

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/DynamicVMOption.java

165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/FileInstaller.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/InMemoryJavaCompiler.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/JDKToolFinder.java (was test/lib/share/classes/jdk/test/lib/JDKToolFinder.java)

0 lines changed: 0 ins; 0 del; 0 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/JDKToolLauncher.java (was test/lib/share/classes/jdk/test/lib/JDKToolLauncher.java)

1 line changed: 0 ins; 0 del; 1 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/Platform.java (was test/lib/share/classes/jdk/test/lib/Platform.java)

4 lines changed: 0 ins; 1 del; 3 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/Utils.java (was test/lib/share/classes/jdk/test/lib/Utils.java)

56 lines changed: 55 ins; 1 del; 0 mod; 639 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/apps/InfiniteLoop.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/apps/LingeredApp.java (was test/lib/share/classes/jdk/test/lib/apps/LingeredApp.java)

0 lines changed: 0 ins; 0 del; 0 mod; 466 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/apps/LingeredAppWithDeadlock.java (was test/lib/share/classes/jdk/test/lib/apps/LingeredAppWithDeadlock.java)

0 lines changed: 0 ins; 0 del; 0 mod; 81 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/apps/TimeLimitedRunner.java

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/cli/CPUSpecificCommandLineOptionTest.java

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/cli/CommandLineOptionTest.java

524 lines changed: 524 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/cli/predicate/AndPredicate.java

41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/cli/predicate/CPUSpecificPredicate.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/cli/predicate/NotPredicate.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/cli/predicate/OrPredicate.java

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/dcmd/CommandExecutor.java

75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/dcmd/CommandExecutorException.java

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/dcmd/FileJcmdExecutor.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/dcmd/JMXExecutor.java

187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/dcmd/JcmdExecutor.java

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/dcmd/MainClassJcmdExecutor.java

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/dcmd/PidJcmdExecutor.java

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/HprofParser.java (was test/lib/share/classes/jdk/test/lib/hprof/HprofParser.java)

0 lines changed: 0 ins; 0 del; 0 mod; 97 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/README (was test/lib/share/classes/jdk/test/lib/hprof/README)

0 lines changed: 0 ins; 0 del; 0 mod; 13 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/AbstractJavaHeapObjectVisitor.java (was test/lib/share/classes/jdk/test/lib/hprof/model/AbstractJavaHeapObjectVisitor.java)

0 lines changed: 0 ins; 0 del; 0 mod; 60 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/ArrayTypeCodes.java (was test/lib/share/classes/jdk/test/lib/hprof/model/ArrayTypeCodes.java)

0 lines changed: 0 ins; 0 del; 0 mod; 50 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/HackJavaValue.java (was test/lib/share/classes/jdk/test/lib/hprof/model/HackJavaValue.java)

0 lines changed: 0 ins; 0 del; 0 mod; 65 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaBoolean.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaBoolean.java)

0 lines changed: 0 ins; 0 del; 0 mod; 54 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaByte.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaByte.java)

0 lines changed: 0 ins; 0 del; 0 mod; 54 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaChar.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaChar.java)

0 lines changed: 0 ins; 0 del; 0 mod; 54 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaClass.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaClass.java)

0 lines changed: 0 ins; 0 del; 0 mod; 503 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaDouble.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaDouble.java)

0 lines changed: 0 ins; 0 del; 0 mod; 53 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaField.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaField.java)

0 lines changed: 0 ins; 0 del; 0 mod; 69 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaFloat.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaFloat.java)

0 lines changed: 0 ins; 0 del; 0 mod; 53 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaHeapObject.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaHeapObject.java)

0 lines changed: 0 ins; 0 del; 0 mod; 207 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaHeapObjectVisitor.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaHeapObjectVisitor.java)

0 lines changed: 0 ins; 0 del; 0 mod; 55 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaInt.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaInt.java)

0 lines changed: 0 ins; 0 del; 0 mod; 54 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaLazyReadObject.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaLazyReadObject.java)

0 lines changed: 0 ins; 0 del; 0 mod; 176 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaLong.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaLong.java)

0 lines changed: 0 ins; 0 del; 0 mod; 53 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaObject.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaObject.java)

0 lines changed: 0 ins; 0 del; 0 mod; 334 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaObjectArray.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaObjectArray.java)

0 lines changed: 0 ins; 0 del; 0 mod; 172 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaObjectRef.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaObjectRef.java)

0 lines changed: 0 ins; 0 del; 0 mod; 97 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaShort.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaShort.java)

0 lines changed: 0 ins; 0 del; 0 mod; 54 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaStatic.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaStatic.java)

0 lines changed: 0 ins; 0 del; 0 mod; 79 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaThing.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaThing.java)

0 lines changed: 0 ins; 0 del; 0 mod; 99 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaValue.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaValue.java)

0 lines changed: 0 ins; 0 del; 0 mod; 61 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/JavaValueArray.java (was test/lib/share/classes/jdk/test/lib/hprof/model/JavaValueArray.java)

0 lines changed: 0 ins; 0 del; 0 mod; 433 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/ReachableExcludes.java (was test/lib/share/classes/jdk/test/lib/hprof/model/ReachableExcludes.java)

0 lines changed: 0 ins; 0 del; 0 mod; 50 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/ReachableExcludesImpl.java (was test/lib/share/classes/jdk/test/lib/hprof/model/ReachableExcludesImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 103 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/ReachableObjects.java (was test/lib/share/classes/jdk/test/lib/hprof/model/ReachableObjects.java)

0 lines changed: 0 ins; 0 del; 0 mod; 148 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/ReferenceChain.java (was test/lib/share/classes/jdk/test/lib/hprof/model/ReferenceChain.java)

0 lines changed: 0 ins; 0 del; 0 mod; 69 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/Root.java (was test/lib/share/classes/jdk/test/lib/hprof/model/Root.java)

0 lines changed: 0 ins; 0 del; 0 mod; 174 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/Snapshot.java (was test/lib/share/classes/jdk/test/lib/hprof/model/Snapshot.java)

0 lines changed: 0 ins; 0 del; 0 mod; 635 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/StackFrame.java (was test/lib/share/classes/jdk/test/lib/hprof/model/StackFrame.java)

0 lines changed: 0 ins; 0 del; 0 mod; 101 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/model/StackTrace.java (was test/lib/share/classes/jdk/test/lib/hprof/model/StackTrace.java)

0 lines changed: 0 ins; 0 del; 0 mod; 77 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/parser/FileReadBuffer.java (was test/lib/share/classes/jdk/test/lib/hprof/parser/FileReadBuffer.java)

0 lines changed: 0 ins; 0 del; 0 mod; 89 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/parser/HprofReader.java (was test/lib/share/classes/jdk/test/lib/hprof/parser/HprofReader.java)

0 lines changed: 0 ins; 0 del; 0 mod; 899 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/parser/MappedReadBuffer.java (was test/lib/share/classes/jdk/test/lib/hprof/parser/MappedReadBuffer.java)

0 lines changed: 0 ins; 0 del; 0 mod; 136 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/parser/PositionDataInputStream.java (was test/lib/share/classes/jdk/test/lib/hprof/parser/PositionDataInputStream.java)

0 lines changed: 0 ins; 0 del; 0 mod; 64 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/parser/PositionInputStream.java (was test/lib/share/classes/jdk/test/lib/hprof/parser/PositionInputStream.java)

0 lines changed: 0 ins; 0 del; 0 mod; 84 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/parser/ReadBuffer.java (was test/lib/share/classes/jdk/test/lib/hprof/parser/ReadBuffer.java)

0 lines changed: 0 ins; 0 del; 0 mod; 51 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/parser/Reader.java (was test/lib/share/classes/jdk/test/lib/hprof/parser/Reader.java)

0 lines changed: 0 ins; 0 del; 0 mod; 97 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/util/ArraySorter.java (was test/lib/share/classes/jdk/test/lib/hprof/util/ArraySorter.java)

0 lines changed: 0 ins; 0 del; 0 mod; 147 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/util/Comparer.java (was test/lib/share/classes/jdk/test/lib/hprof/util/Comparer.java)

0 lines changed: 0 ins; 0 del; 0 mod; 49 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/util/CompositeEnumeration.java (was test/lib/share/classes/jdk/test/lib/hprof/util/CompositeEnumeration.java)

0 lines changed: 0 ins; 0 del; 0 mod; 63 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/util/Misc.java (was test/lib/share/classes/jdk/test/lib/hprof/util/Misc.java)

0 lines changed: 0 ins; 0 del; 0 mod; 112 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/hprof/util/VectorSorter.java (was test/lib/share/classes/jdk/test/lib/hprof/util/VectorSorter.java)

0 lines changed: 0 ins; 0 del; 0 mod; 148 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/process/ExitCode.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/process/OutputAnalyzer.java (was test/lib/share/classes/jdk/test/lib/process/OutputAnalyzer.java)

7 lines changed: 0 ins; 0 del; 7 mod; 429 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/process/OutputBuffer.java (was test/lib/share/classes/jdk/test/lib/process/OutputBuffer.java)

0 lines changed: 0 ins; 0 del; 0 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/process/ProcessTools.java (was test/lib/share/classes/jdk/test/lib/process/ProcessTools.java)

45 lines changed: 36 ins; 9 del; 0 mod; 581 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/process/StreamPumper.java (was test/lib/share/classes/jdk/test/lib/process/StreamPumper.java)

0 lines changed: 0 ins; 0 del; 0 mod; 197 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/util/Pair.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/util/Triple.java

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/utils/webrev.ksh (vers 25.16-hg+openjdk.java.net).