Code Review for jdk

Prepared by:darcy on Wed Apr 27 14:31:07 PDT 2016
Workspace:/home/darcy/JDK/9/hg/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Summary of changes: 386 lines changed: 183 ins; 24 del; 179 mod; 87445 unchg
Patch of changes: jdk.patch
Bug id: <title>[JDK-6850612] Deprecate Class.newInstance since it violates the checked exception language contract - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

2 lines changed: 1 ins; 0 del; 1 mod; 3870 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/InetAddress.java

6 lines changed: 4 ins; 0 del; 2 mod; 1744 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/ProxySelector.java

3 lines changed: 2 ins; 0 del; 1 mod; 209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/URL.java

6 lines changed: 3 ins; 0 del; 3 mod; 1720 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/URLConnection.java

3 lines changed: 2 ins; 0 del; 1 mod; 1826 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/spi/AsynchronousChannelProvider.java

4 lines changed: 1 ins; 0 del; 3 mod; 242 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/spi/SelectorProvider.java

4 lines changed: 1 ins; 0 del; 3 mod; 320 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Policy.java

3 lines changed: 1 ins; 0 del; 2 mod; 861 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/time/zone/ZoneRulesProvider.java

1 line changed: 1 ins; 0 del; 0 mod; 439 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/ServiceLoader.java

3 lines changed: 2 ins; 0 del; 1 mod; 1120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java

1 line changed: 1 ins; 0 del; 0 mod; 3579 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/jar/Pack200.java

3 lines changed: 2 ins; 0 del; 1 mod; 722 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/net/ssl/SSLServerSocketFactory.java

1 line changed: 1 ins; 0 del; 0 mod; 200 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java

1 line changed: 1 ins; 0 del; 0 mod; 305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/security/auth/login/Configuration.java

3 lines changed: 2 ins; 0 del; 1 mod; 621 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/security/auth/login/LoginContext.java

6 lines changed: 3 ins; 0 del; 3 mod; 924 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java

3 lines changed: 2 ins; 0 del; 1 mod; 354 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/MethodAccessorGenerator.java

1 line changed: 1 ins; 0 del; 0 mod; 780 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/ftp/FtpClientProvider.java

3 lines changed: 1 ins; 0 del; 2 mod; 155 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ThreadPool.java

8 lines changed: 0 ins; 3 del; 5 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/FastCharsetProvider.java

4 lines changed: 1 ins; 0 del; 3 mod; 157 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/StandardCharsets.java.template

5 lines changed: 1 ins; 0 del; 4 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/jca/ProviderConfig.java

4 lines changed: 3 ins; 0 del; 1 mod; 419 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java

4 lines changed: 1 ins; 2 del; 1 mod; 448 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/tools/keytool/Main.java

1 line changed: 1 ins; 0 del; 0 mod; 4233 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/KeyStoreDelegator.java

12 lines changed: 7 ins; 0 del; 5 mod; 299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/X509Key.java

4 lines changed: 1 ins; 2 del; 1 mod; 474 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/util/calendar/CalendarSystem.java

3 lines changed: 1 ins; 0 del; 2 mod; 348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java

3 lines changed: 1 ins; 0 del; 2 mod; 441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java

1 line changed: 0 ins; 0 del; 1 mod; 615 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/DefaultDatagramSocketImplFactory.java

3 lines changed: 2 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java

3 lines changed: 2 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/nio/fs/DefaultFileSystemProvider.java

3 lines changed: 2 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaBorder.java

1 line changed: 1 ins; 0 del; 0 mod; 145 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/com/apple/laf/AquaUtils.java

1 line changed: 1 ins; 0 del; 0 mod; 458 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/beans/decoder/DocumentHandler.java

3 lines changed: 2 ins; 0 del; 1 mod; 410 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/beans/finder/InstanceFinder.java

1 line changed: 0 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java

3 lines changed: 2 ins; 0 del; 1 mod; 1144 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/JARSoundbankReader.java

4 lines changed: 1 ins; 0 del; 3 mod; 124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/ModelAbstractOscillator.java

4 lines changed: 0 ins; 0 del; 4 mod; 196 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/GraphicsEnvironment.java

3 lines changed: 2 ins; 0 del; 1 mod; 461 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Toolkit.java

7 lines changed: 4 ins; 0 del; 3 mod; 2333 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/print/PrinterJob.java

3 lines changed: 2 ins; 0 del; 1 mod; 617 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/beans/Beans.java

3 lines changed: 2 ins; 0 del; 1 mod; 629 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/beans/Introspector.java

3 lines changed: 1 ins; 0 del; 2 mod; 1409 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/beans/MetaData.java

3 lines changed: 2 ins; 0 del; 1 mod; 1453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/beans/PropertyDescriptor.java

3 lines changed: 2 ins; 0 del; 1 mod; 786 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/JEditorPane.java

3 lines changed: 2 ins; 0 del; 1 mod; 2436 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/UIManager.java

9 lines changed: 4 ins; 1 del; 4 mod; 1494 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/GlyphView.java

1 line changed: 1 ins; 0 del; 0 mod; 1387 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/ParagraphView.java

1 line changed: 1 ins; 0 del; 0 mod; 1196 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java

3 lines changed: 1 ins; 0 del; 2 mod; 2442 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/html/ObjectView.java

1 line changed: 1 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/applet/AppletPanel.java

3 lines changed: 2 ins; 0 del; 1 mod; 1290 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/FontConfiguration.java

3 lines changed: 2 ins; 0 del; 1 mod; 2287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/SunToolkit.java

4 lines changed: 1 ins; 0 del; 3 mod; 2104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java

3 lines changed: 1 ins; 0 del; 2 mod; 619 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/font/FontManagerFactory.java

3 lines changed: 1 ins; 0 del; 2 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/cmm/CMSManager.java

3 lines changed: 1 ins; 0 del; 2 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveProxy.java

3 lines changed: 1 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/pipe/RenderingEngine.java

6 lines changed: 2 ins; 0 del; 4 mod; 472 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/font/XMap.java

3 lines changed: 2 ins; 0 del; 1 mod; 252 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.httpclient/share/classes/java/net/http/FilterFactory.java

3 lines changed: 2 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.logging/share/classes/java/util/logging/LogManager.java

23 lines changed: 8 ins; 0 del; 15 mod; 2663 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.logging/share/classes/java/util/logging/MemoryHandler.java

3 lines changed: 2 ins; 0 del; 1 mod; 278 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java

6 lines changed: 4 ins; 0 del; 2 mod; 1515 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/javax/management/MBeanServerFactory.java

1 line changed: 1 ins; 0 del; 0 mod; 543 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java

3 lines changed: 2 ins; 0 del; 1 mod; 571 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/naming/internal/FactoryEnumeration.java

3 lines changed: 2 ins; 0 del; 1 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/naming/internal/ResourceManager.java

3 lines changed: 2 ins; 0 del; 1 mod; 591 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/javax/naming/ldap/StartTlsRequest.java

13 lines changed: 2 ins; 8 del; 3 mod; 238 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/javax/naming/spi/NamingManager.java

6 lines changed: 3 ins; 0 del; 3 mod; 918 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.prefs/share/classes/java/util/prefs/Preferences.java

13 lines changed: 3 ins; 0 del; 10 mod; 1278 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/java/rmi/activation/ActivationID.java

1 line changed: 1 ins; 0 del; 0 mod; 291 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/java/rmi/server/RMIClassLoader.java

3 lines changed: 2 ins; 0 del; 1 mod; 721 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/java/rmi/server/RemoteObject.java

8 lines changed: 2 ins; 4 del; 2 mod; 453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/sun/rmi/server/Activation.java

3 lines changed: 2 ins; 0 del; 1 mod; 2550 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.smartcardio/share/classes/javax/smartcardio/TerminalFactory.java

3 lines changed: 1 ins; 0 del; 2 mod; 368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.sql.rowset/share/classes/com/sun/rowset/CachedRowSetImpl.java

6 lines changed: 4 ins; 0 del; 2 mod; 10124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.sql.rowset/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java

3 lines changed: 2 ins; 0 del; 1 mod; 1471 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.sql.rowset/share/classes/javax/sql/rowset/RowSetProvider.java

4 lines changed: 2 ins; 0 del; 2 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SQLInputImpl.java

3 lines changed: 2 ins; 0 del; 1 mod; 668 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncFactory.java

8 lines changed: 2 ins; 4 del; 2 mod; 954 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java

3 lines changed: 2 ins; 0 del; 1 mod; 464 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/Canonicalizer.java

3 lines changed: 2 ins; 0 del; 1 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java

5 lines changed: 4 ins; 0 del; 1 mod; 421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverSpi.java

3 lines changed: 2 ins; 0 del; 1 mod; 260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transform.java

6 lines changed: 4 ins; 0 del; 2 mod; 374 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java

5 lines changed: 3 ins; 0 del; 2 mod; 372 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/Translator.java

1 line changed: 1 ins; 0 del; 0 mod; 756 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/AbstractCharsetProvider.java

1 line changed: 1 ins; 0 del; 0 mod; 205 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/P11Util.java

3 lines changed: 1 ins; 0 del; 2 mod; 179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.pkcs11/share/classes/sun/security/pkcs11/SunPKCS11.java

3 lines changed: 2 ins; 0 del; 1 mod; 1499 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.httpserver/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java

4 lines changed: 1 ins; 0 del; 3 mod; 175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.le/share/classes/jdk/internal/jline/TerminalFactory.java

3 lines changed: 2 ins; 0 del; 1 mod; 172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.le/share/classes/jdk/internal/jline/console/internal/ConsoleRunner.java

1 line changed: 1 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/tools/jdi/ProcessAttachingConnector.java

3 lines changed: 2 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/tools/jdi/RawCommandLineLauncher.java

8 lines changed: 2 ins; 0 del; 6 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

8 lines changed: 2 ins; 0 del; 6 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.localedata/share/classes/sun/util/resources/provider/LocaleDataProvider.java

1 line changed: 0 ins; 0 del; 1 mod; 57 unchg

This code review page was prepared using /home/darcy/JDK/webrev/webrev.ksh (vers 25.12-hg+openjdk.java.net).