Code Review for langtools

Prepared by:darcy on Thu Jul 15 23:38:14 PDT 2010
Workspace:/home/darcy/Sun/OpenJDK/7/hg/7.ARM/langtools
Compare against: http://hg.openjdk.java.net/jdk7/tl/langtools
Summary of changes: 1951 lines changed: 1933 ins; 0 del; 18 mod; 25704 unchg
Patch of changes: langtools.patch
Bug id: 6911256 Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/build.properties

2 lines changed: 1 ins; 0 del; 1 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/source/tree/TryTree.java

1 line changed: 1 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/source/util/TreeScanner.java

2 lines changed: 1 ins; 0 del; 1 mod; 393 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/code/Lint.java

6 lines changed: 5 ins; 0 del; 1 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/code/Source.java

3 lines changed: 3 ins; 0 del; 0 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/code/Symbol.java

7 lines changed: 5 ins; 0 del; 2 mod; 1414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/code/Symtab.java

10 lines changed: 10 ins; 0 del; 0 mod; 645 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/comp/Attr.java

55 lines changed: 50 ins; 0 del; 5 mod; 3110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/comp/Check.java

5 lines changed: 4 ins; 0 del; 1 mod; 2450 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/comp/Flow.java

51 lines changed: 50 ins; 0 del; 1 mod; 1372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/comp/Lower.java

148 lines changed: 148 ins; 0 del; 0 mod; 3638 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/comp/TransTypes.java

8 lines changed: 8 ins; 0 del; 0 mod; 804 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/jvm/CRTable.java

1 line changed: 1 ins; 0 del; 0 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/parser/JavacParser.java

59 lines changed: 56 ins; 0 del; 3 mod; 3222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/resources/compiler.properties

14 lines changed: 14 ins; 0 del; 0 mod; 1335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/tree/JCTree.java

14 lines changed: 13 ins; 0 del; 1 mod; 2267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/tree/Pretty.java

13 lines changed: 13 ins; 0 del; 0 mod; 1280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/tree/TreeCopier.java

2 lines changed: 1 ins; 0 del; 1 mod; 427 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/tree/TreeMaker.java

8 lines changed: 7 ins; 0 del; 1 mod; 927 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/tree/TreeScanner.java

1 line changed: 1 ins; 0 del; 0 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java

1 line changed: 1 ins; 0 del; 0 mod; 423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/util/Names.java

5 lines changed: 5 ins; 0 del; 0 mod; 295 unchg

------ ------ ------ ------ --- --- ----- --- 6911256.9

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmFlow.java

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmFlow.out

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmInference.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmIntersection.java

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmIntersection02.java

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmIntersection02.out

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmLint.java

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmLint.out

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmMultiCatch.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmOnNonResource.java

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmOnNonResource.out

7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ArmTests.java

743 lines changed: 743 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/BadArm.java

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/BadArm.out

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/BadArmSyntax.java

22 lines changed: 22 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/BadArmSyntax.out

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/DuplicateResource.java

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/DuplicateResourceDecl.java

20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/DuplicateResourceDecl.out

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ImplicitFinal.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ImplicitFinal.out

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/PlainTry.java

15 lines changed: 15 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/PlainTry.out

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/PlainTry6.out

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ResourceOutsideTry.java

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ResourceOutsideTry.out

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/ResourceTypeVar.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/TryWithResource/WeirdArm.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/processing/model/element/TestResourceVariable.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/darcy/Sun/bin/webrev (vers 23.18-hg).