Code Review for langtools

Prepared by:darcy on Tue Jul 15 10:27:48 PDT 2014
Workspace:/home/darcy/Sun/OpenJDK/9/dev/langtools
Compare against: http://hg.openjdk.java.net/jdk9/dev/langtools
Summary of changes: 995 lines changed: 867 ins; 37 del; 91 mod; 13730 unchg
Patch of changes: langtools.patch
Bug id: JDK-8050430 : Provided new utility visitors supporting SourceVersion.RELEASE_9
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java

1 line changed: 0 ins; 0 del; 1 mod; 1514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java

2 lines changed: 0 ins; 0 del; 2 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java

1 line changed: 0 ins; 0 del; 1 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javah/JavahTask.java

3 lines changed: 0 ins; 0 del; 3 mod; 756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javah/LLNI.java

3 lines changed: 0 ins; 0 del; 3 mod; 677 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javah/TypeSignature.java

3 lines changed: 0 ins; 0 del; 3 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/sjavac/comp/PubapiVisitor.java

2 lines changed: 0 ins; 0 del; 2 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/element/ElementVisitor.java

3 lines changed: 0 ins; 2 del; 1 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java

5 lines changed: 4 ins; 0 del; 1 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java

2 lines changed: 1 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java

2 lines changed: 1 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java

5 lines changed: 4 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java

2 lines changed: 1 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java

2 lines changed: 1 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java

9 lines changed: 8 ins; 0 del; 1 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java

6 lines changed: 5 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java

6 lines changed: 5 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/ElementKindVisitor6.java

5 lines changed: 4 ins; 0 del; 1 mod; 412 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/ElementKindVisitor7.java

2 lines changed: 1 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/ElementKindVisitor8.java

2 lines changed: 1 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/ElementScanner6.java

5 lines changed: 4 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/ElementScanner7.java

2 lines changed: 1 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/ElementScanner8.java

2 lines changed: 1 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java

5 lines changed: 4 ins; 0 del; 1 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java

2 lines changed: 1 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java

2 lines changed: 1 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java

5 lines changed: 4 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java

2 lines changed: 1 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java

3 lines changed: 1 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java

5 lines changed: 4 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java

2 lines changed: 1 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java

3 lines changed: 1 ins; 0 del; 2 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/lang/model/util/TypeKindVisitor6.java

3 lines changed: 3 ins; 0 del; 0 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/sample/javac/processing/src/CheckNamesProcessor.java

3 lines changed: 0 ins; 0 del; 3 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/sample/language/model/CoreReflectionFactory.java

11 lines changed: 0 ins; 0 del; 11 mod; 3756 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/6402516/CheckLocalElements.java

1 line changed: 0 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/lib/JavacTestingAbstractProcessor.java

10 lines changed: 0 ins; 0 del; 10 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/multicatch/model/ModelChecker.java

2 lines changed: 0 ins; 1 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/processing/model/TestSymtabItems.java

3 lines changed: 0 ins; 0 del; 3 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/processing/model/element/TestTypeParameter.java

1 line changed: 0 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/processing/model/type/InheritedAP.java

11 lines changed: 0 ins; 2 del; 9 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/processing/model/util/elements/doccomments/TestDocComments.java

20 lines changed: 3 ins; 13 del; 4 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/processing/model/util/elements/doccomments/TestPackageInfoComments.java

23 lines changed: 3 ins; 17 del; 3 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/tree/NoPrivateTypesExported.java

5 lines changed: 0 ins; 2 del; 3 mod; 286 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor9.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/AbstractElementVisitor9.java

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/AbstractTypeVisitor9.java

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/ElementKindVisitor9.java

98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/ElementScanner9.java

111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor9.java

88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/SimpleElementVisitor9.java

93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/SimpleTypeVisitor9.java

93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/javax/lang/model/util/TypeKindVisitor9.java

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/darcy/Sun/OpenJDK/webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).