Code Review for jdk

Prepared by:darcy on Mon Jun 3 13:23:14 PDT 2019
Workspace:/home/darcy/JDK/Scm/hg/jdk
Compare against: https://hg.openjdk.java.net/jdk/jdk
Summary of changes: 975 lines changed: 455 ins; 2 del; 518 mod; 8584 unchg
Patch of changes: jdk.patch
Bug id: JDK-8164819 : Make javac's toString() on annotation objects consistent with core reflection
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java

55 lines changed: 36 ins; 2 del; 17 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Attribute.java

3 lines changed: 1 ins; 0 del; 2 mod; 424 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java

5 lines changed: 3 ins; 0 del; 2 mod; 361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/annotation/AnnotationToStringTest.java

49 lines changed: 9 ins; 0 del; 40 mod; 261 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/processing/model/element/AnnotationToStringTest.java

405 lines changed: 405 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/annotation/ParameterAnnotations.java

2 lines changed: 0 ins; 0 del; 2 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/annotation/TestConstructorParameterAnnotations.java

16 lines changed: 0 ins; 0 del; 16 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/annotation/typeAnnotations/TestConstructorParameterTypeAnnotations.java

8 lines changed: 0 ins; 0 del; 8 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/annotation/typeAnnotations/TestObjectMethods.java

1 line changed: 0 ins; 0 del; 1 mod; 506 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/modules/AnnotationsOnModules.java

3 lines changed: 0 ins; 0 del; 3 mod; 709 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/messager/6388543/T6388543.out

6 lines changed: 0 ins; 0 del; 6 mod; 9 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/repeatingAnnotations/combo/ReflectionTest.java

201 lines changed: 0 ins; 0 del; 201 mod; 2828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/typeAnnotations/classfile/AnonymousExtendsTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerBasicTest.java

18 lines changed: 0 ins; 0 del; 18 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java

7 lines changed: 0 ins; 0 del; 7 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA2Test.java

10 lines changed: 0 ins; 0 del; 10 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java

5 lines changed: 0 ins; 0 del; 5 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java

8 lines changed: 0 ins; 0 del; 8 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerBasicTest.java

19 lines changed: 0 ins; 0 del; 19 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedA1Test.java

7 lines changed: 0 ins; 0 del; 7 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedA2Test.java

8 lines changed: 0 ins; 0 del; 8 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedB1Test.java

7 lines changed: 0 ins; 0 del; 7 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedB2Test.java

8 lines changed: 0 ins; 0 del; 8 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/OfficialContainerBasicTest.java

16 lines changed: 0 ins; 0 del; 16 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/OfficialContainerInheritedTest.java

6 lines changed: 0 ins; 0 del; 6 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/RepeatableBasicTest.java

19 lines changed: 0 ins; 0 del; 19 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/RepeatableInheritedTest.java

7 lines changed: 0 ins; 0 del; 7 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOfficialContainerBasicTest.java

13 lines changed: 0 ins; 0 del; 13 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOfficialContainerInheritedTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java

8 lines changed: 0 ins; 0 del; 8 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java

9 lines changed: 0 ins; 0 del; 9 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/SingularBasicTest.java

10 lines changed: 0 ins; 0 del; 10 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/SingularInheritedATest.java

4 lines changed: 0 ins; 0 del; 4 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/SingularInheritedBTest.java

5 lines changed: 0 ins; 0 del; 5 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/UnofficialContainerBasicTest.java

10 lines changed: 0 ins; 0 del; 10 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/element/repeatingAnnotations/UnofficialContainerInheritedTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/sym/ElementStructureTest.java

1 line changed: 1 ins; 0 del; 0 mod; 673 unchg

This code review page was prepared using /home/darcy/JDK/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).