Code Review for jdk

Prepared by:darcy on Wed Jul 25 12:21:17 PDT 2018
Workspace:/home/darcy/JDK/Scm/hg/jdk
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 314 lines changed: 284 ins; 2 del; 28 mod; 847 unchg
Patch of changes: jdk.patch
Bug id: JDK-8190886 : package-info handling in RoundEnvironment.getElementsAnnotatedWith
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java

46 lines changed: 43 ins; 0 del; 3 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/BuriedAnnotations.java

4 lines changed: 2 ins; 0 del; 2 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/C2.java

3 lines changed: 2 ins; 0 del; 1 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/ErroneousAnnotations.java

2 lines changed: 2 ins; 0 del; 0 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/ErroneousAnnotations.out

2 lines changed: 0 ins; 0 del; 2 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/Foo.java

4 lines changed: 2 ins; 0 del; 2 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/ParameterAnnotations.java

3 lines changed: 2 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/Part1.java

3 lines changed: 2 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/SurfaceAnnotations.java

3 lines changed: 2 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java

45 lines changed: 30 ins; 2 del; 13 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/TypeParameterAnnotations.java

3 lines changed: 2 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/environment/round/annot/AnnotatedElementInfo.java (was test/langtools/tools/javac/processing/environment/round/AnnotatedElementInfo.java)

5 lines changed: 4 ins; 0 del; 1 mod; 35 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/processing/environment/round/annot/MarkerAnnot.java

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/processing/environment/round/mod/module-info.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/processing/environment/round/mod/quux/Quux.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/processing/environment/round/mod/quux/package-info.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/processing/environment/round/pkg/Foo.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/processing/environment/round/pkg/package-info.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/darcy/JDK/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).