Code Review for jdk

Prepared by:darcy on Wed Feb 20 13:07:32 PST 2019
Workspace:/home/darcy/JDK/Scm/hg/jdk13/jdk
Compare against: https://hg.openjdk.java.net/jdk/jdk
Summary of changes: 185 lines changed: 54 ins; 2 del; 129 mod; 7123 unchg
Patch of changes: jdk.patch
Bug id: JDK-8219254 : Update explicit uses of latest source/target in langtools tests to a property
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/TEST.ROOT

1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/6330997/T6330997.java

3 lines changed: 0 ins; 0 del; 3 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/ConditionalWithVoid.java

1 line changed: 0 ins; 0 del; 1 mod; 19 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/Example.java

47 lines changed: 45 ins; 0 del; 2 mod; 795 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakAmbiguousTarget.java

2 lines changed: 0 ins; 0 del; 2 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakExprNotImmediate.java

2 lines changed: 0 ins; 0 del; 2 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakMissingValue.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakOutsideSwitchExpression.java

2 lines changed: 0 ins; 0 del; 2 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/ContinueOutsideSwitchExpression.java

2 lines changed: 0 ins; 0 del; 2 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/IncompatibleTypesInSwitchExpression.java

2 lines changed: 0 ins; 0 del; 2 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/MultipleCaseLabels.java

2 lines changed: 0 ins; 0 del; 2 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/NotExhaustive.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewFeatureUse.java

2 lines changed: 0 ins; 0 del; 2 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewFilename.java

2 lines changed: 0 ins; 0 del; 2 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewFilenameAdditional.java

2 lines changed: 0 ins; 0 del; 2 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewPlural/PreviewPlural.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/ReturnOutsideSwitchExpression.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/RuleCompletesNormally.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchCaseUnexpectedStatement.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressionCompletesNormally.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressionEmpty.java

2 lines changed: 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressionTargetCantBeVoid.java

2 lines changed: 0 ins; 0 del; 2 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressions.java

2 lines changed: 0 ins; 0 del; 2 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchMixingCaseTypes.java

2 lines changed: 0 ins; 0 del; 2 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchRules.java

2 lines changed: 0 ins; 0 del; 2 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/expswitch/ExpSwitchNestingTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/BadSwitchExpressionLambda.java

1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/parser/JavacParserTest.java

7 lines changed: 2 ins; 2 del; 3 mod; 1375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/preview/classReaderTest/Client.java

2 lines changed: 0 ins; 0 del; 2 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/BlockExpression.java

2 lines changed: 0 ins; 0 del; 2 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/BooleanNumericNonNumeric.java

1 line changed: 0 ins; 0 del; 1 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/BreakTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/CRT.java

4 lines changed: 2 ins; 0 del; 2 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/DefiniteAssignment1.java

2 lines changed: 0 ins; 0 del; 2 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/DefiniteAssignment2.java

1 line changed: 0 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/EmptySwitch.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExhaustiveEnumSwitch.java

2 lines changed: 0 ins; 0 del; 2 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitch.java

1 line changed: 0 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks1.java

2 lines changed: 0 ins; 0 del; 2 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks2.java

1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBugs.java

2 lines changed: 0 ins; 0 del; 2 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBugsInGen.java

2 lines changed: 0 ins; 0 del; 2 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchCodeFromJLS.java

2 lines changed: 0 ins; 0 del; 2 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchDA.java

2 lines changed: 0 ins; 0 del; 2 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchEmbedding.java

2 lines changed: 0 ins; 0 del; 2 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough.java

2 lines changed: 0 ins; 0 del; 2 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough1.java

2 lines changed: 0 ins; 0 del; 2 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchFlow.java

1 line changed: 0 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchInExpressionSwitch.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchIntersectionTypes.java

2 lines changed: 0 ins; 0 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchNotExhaustive.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchUnreachable.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ParseIncomplete.java

3 lines changed: 1 ins; 0 del; 2 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ParserRecovery.java

1 line changed: 0 ins; 0 del; 1 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/SwitchExpressionIsNotAConstant.java

2 lines changed: 0 ins; 0 del; 2 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/SwitchExpressionScopesIsolated.java

1 line changed: 0 ins; 0 del; 1 mod; 17 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/SwitchExpressionSimpleVisitorTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/TryCatch.java

2 lines changed: 0 ins; 0 del; 2 mod; 421 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/CaseTest.java

13 lines changed: 1 ins; 0 del; 12 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/MultipleLabelsExpression.java

1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/MultipleLabelsStatement.java

1 line changed: 0 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/RuleParsingTest.java

5 lines changed: 1 ins; 0 del; 4 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchArrowBrokenConstant.java

1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementArrow.java

1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementBroken.java

1 line changed: 0 ins; 0 del; 1 mod; 20 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementBroken2.java

1 line changed: 0 ins; 0 del; 1 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementScopesIsolated.java

1 line changed: 0 ins; 0 del; 1 mod; 17 unchg

This code review page was prepared using /home/darcy/JDK/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).