--- old/test/langtools/tools/javac/processing/model/TestSourceVersion.java 2019-11-12 15:15:09.817001000 -0800 +++ new/test/langtools/tools/javac/processing/model/TestSourceVersion.java 2019-11-12 15:15:09.589001000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,7 +23,7 @@ /* * @test - * @bug 7025809 8028543 6415644 8028544 8029942 8187951 8193291 8196551 + * @bug 7025809 8028543 6415644 8028544 8029942 8187951 8193291 8196551 8233096 * @summary Test latest, latestSupported, underscore as keyword, etc. * @author Joseph D. Darcy * @modules java.compiler @@ -31,11 +31,12 @@ */ import java.util.*; +import java.util.function.Predicate; import javax.lang.model.SourceVersion; import static javax.lang.model.SourceVersion.*; /** - * Verify latest[Supported] behavior. + * Verify latest[Supported] behavior and other methods. */ public class TestSourceVersion { public static void main(String... args) { @@ -43,6 +44,7 @@ testVersionVaryingKeywords(); testRestrictedKeywords(); testVar(); + testYield(); } private static void testLatestSupported() { @@ -73,14 +75,14 @@ String key = entry.getKey(); SourceVersion value = entry.getValue(); - check(true, isKeyword(key), "keyword", latest()); - check(false, isName(key), "name", latest()); + check(true, key, (String s) -> isKeyword(s), "keyword", latest()); + check(false, key, (String s) -> isName(s), "name", latest()); for(SourceVersion version : SourceVersion.values()) { boolean isKeyword = version.compareTo(value) >= 0; - check(isKeyword, isKeyword(key, version), "keyword", version); - check(!isKeyword, isName(key, version), "name", version); + check(isKeyword, key, (String s) -> isKeyword(s, version), "keyword", version); + check(!isKeyword, key, (String s) -> isName(s, version), "name", version); } } } @@ -100,29 +102,51 @@ for(String key : restrictedKeywords) { for(SourceVersion version : SourceVersion.values()) { - check(false, isKeyword(key, version), "keyword", version); - check(true, isName(key, version), "name", version); + check(false, key, (String s) -> isKeyword(s, version), "keyword", version); + check(true, key, (String s) -> isName(s, version), "name", version); } } } private static void testVar() { + for(SourceVersion version : SourceVersion.values()) { + Predicate isKeywordVersion = (String s) -> isKeyword(s, version); + Predicate isNameVersion = (String s) -> isName(s, version); + + check(false, "var", isKeywordVersion, "keyword", version); + check(false, "foo.var",isKeywordVersion, "keyword", version); + check(false, "var.foo",isKeywordVersion, "keyword", version); + + check(true, "var", isNameVersion, "name", version); + check(true, "foo.var", isNameVersion, "name", version); + check(true, "var.foo", isNameVersion, "name", version); + } + } + private static void testYield() { for(SourceVersion version : SourceVersion.values()) { - check(false, isKeyword("var", version), "keyword", version); - check(false, isKeyword("foo.var", version), "keyword", version); - check(false, isKeyword("var.foo", version), "keyword", version); + Predicate isKeywordVersion = (String s) -> isKeyword(s, version); + Predicate isNameVersion = (String s) -> isName(s, version); - check(true, isName("var", version), "name", version); - check(true, isName("foo.var", version), "name", version); - check(true, isName("var.foo", version), "name", version); + check(false, "yield", isKeywordVersion, "keyword", version); + check(false, "foo.yield", isKeywordVersion, "keyword", version); + check(false, "yield.foo", isKeywordVersion, "keyword", version); + + check(true, "yield", isNameVersion, "name", version); + check(true, "foo.yield", isNameVersion, "name", version); + check(true, "yield.foo", isNameVersion, "name", version); } } - private static void check(boolean result, boolean expected, - String message, SourceVersion version) { + private static void check(boolean expected, + String input, + Predicate predicate, + String message, + SourceVersion version) { + boolean result = predicate.test(input); if (result != expected) { - throw new RuntimeException("Unexpected " + message + "-ness of _ on " + version); + throw new RuntimeException("Unexpected " + message + "-ness of " + input + + " on " + version); } } }