Code Review for open

Prepared by:dcubed on Tue Nov 21 15:12:16 PST 2017
Workspace:/export/home/ddaugher/8167108/SMR_prototype_10_20171117/open
Compare against: /export/home/ddaugher/8167108/SMR_base_10_20171117/open
Compare against version:qparent
Summary of changes: 4668 lines changed: 3683 ins; 435 del; 550 mod; 85541 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
9 lines changed: 4 ins; 3 del; 2 mod; 6117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/posix/os_posix.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
5 lines changed: 0 ins; 3 del; 2 mod; 1978 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
5 lines changed: 0 ins; 3 del; 2 mod; 5404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/dirtyCardQueue.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
3 lines changed: 1 ins; 0 del; 2 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
4 lines changed: 1 ins; 2 del; 1 mod; 5393 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/satbMarkQueue.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
8 lines changed: 1 ins; 0 del; 7 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/mutableNUMASpace.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
2 lines changed: 1 ins; 0 del; 1 mod; 999 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
4 lines changed: 2 ins; 0 del; 2 mod; 609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcLocker.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
6 lines changed: 3 ins; 0 del; 3 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
3 lines changed: 1 ins; 0 del; 2 mod; 432 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciRuntime.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
8 lines changed: 4 ins; 2 del; 2 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logTag.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
1 line changed: 1 ins; 0 del; 0 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/idealGraphPrinter.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
4 lines changed: 1 ins; 1 del; 2 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jni.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
2 lines changed: 0 ins; 0 del; 2 mod; 4361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
146 lines changed: 37 ins; 43 del; 66 mod; 3695 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEnter.xsl

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
29 lines changed: 2 ins; 21 del; 6 mod; 1275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEnv.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
207 lines changed: 100 ins; 43 del; 64 mod; 3546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEnvBase.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
161 lines changed: 92 ins; 50 del; 19 mod; 1454 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEnvBase.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
64 lines changed: 0 ins; 57 del; 7 mod; 657 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEnvThreadState.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
2 lines changed: 1 ins; 0 del; 1 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiEventController.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
9 lines changed: 1 ins; 3 del; 5 mod; 1071 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiExport.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
105 lines changed: 103 ins; 1 del; 1 mod; 2755 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiExport.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
8 lines changed: 8 ins; 0 del; 0 mod; 565 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiImpl.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
3 lines changed: 1 ins; 1 del; 1 mod; 1022 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
1 line changed: 1 ins; 0 del; 0 mod; 4231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiTagMap.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
3 lines changed: 2 ins; 0 del; 1 mod; 3426 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiThreadState.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
26 lines changed: 0 ins; 24 del; 2 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiThreadState.inline.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
28 lines changed: 27 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/unsafe.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
19 lines changed: 6 ins; 3 del; 10 mod; 1262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
2 lines changed: 1 ins; 0 del; 1 mod; 2120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/biasedLocking.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47866 : robinw CR: Fix some inefficient code, update some comments, fix some indents, and add some 'const' specifiers.
104 lines changed: 43 ins; 42 del; 19 mod; 788 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/deoptimization.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
2 lines changed: 1 ins; 0 del; 1 mod; 2388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47865 : dholmes CR: Fix indents, trailing spaces and various typos. Add descriptions for the '_cnt', '_max' and '_times" fields, add impl notes to document the type choices.
6 lines changed: 6 ins; 0 del; 0 mod; 4170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/handshake.cpp

rev 47863 : imported patch 10.08.open.rebase_20171114.rehn
rev 47865 : dholmes CR: Fix indents, trailing spaces and various typos. Add descriptions for the '_cnt', '_max' and '_times" fields, add impl notes to document the type choices.
42 lines changed: 22 ins; 3 del; 17 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/java.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
4 lines changed: 4 ins; 0 del; 0 mod; 740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/memprofiler.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47866 : robinw CR: Fix some inefficient code, update some comments, fix some indents, and add some 'const' specifiers.
25 lines changed: 10 ins; 10 del; 5 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
13 lines changed: 1 ins; 10 del; 2 mod; 1815 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/safepoint.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47863 : imported patch 10.08.open.rebase_20171114.rehn
218 lines changed: 37 ins; 28 del; 153 mod; 1264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
2 lines changed: 0 ins; 0 del; 2 mod; 1980 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
2 lines changed: 1 ins; 0 del; 1 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47863 : imported patch 10.08.open.rebase_20171114.rehn
rev 47864 : imported patch 10.09.open.TLH_hang_fix.rehn
rev 47865 : dholmes CR: Fix indents, trailing spaces and various typos. Add descriptions for the '_cnt', '_max' and '_times" fields, add impl notes to document the type choices.
rev 47866 : robinw CR: Fix some inefficient code, update some comments, fix some indents, and add some 'const' specifiers.
1190 lines changed: 1085 ins; 53 del; 52 mod; 4772 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47865 : dholmes CR: Fix indents, trailing spaces and various typos. Add descriptions for the '_cnt', '_max' and '_times" fields, add impl notes to document the type choices.
rev 47866 : robinw CR: Fix some inefficient code, update some comments, fix some indents, and add some 'const' specifiers.
162 lines changed: 137 ins; 9 del; 16 mod; 2182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.inline.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47865 : dholmes CR: Fix indents, trailing spaces and various typos. Add descriptions for the '_cnt', '_max' and '_times" fields, add impl notes to document the type choices.
rev 47866 : robinw CR: Fix some inefficient code, update some comments, fix some indents, and add some 'const' specifiers.
102 lines changed: 98 ins; 4 del; 0 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vm_operations.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
38 lines changed: 28 ins; 0 del; 10 mod; 503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vm_operations.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47866 : robinw CR: Fix some inefficient code, update some comments, fix some indents, and add some 'const' specifiers.
6 lines changed: 2 ins; 0 del; 4 mod; 491 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/heapDumper.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
3 lines changed: 2 ins; 0 del; 1 mod; 2115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/management.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
37 lines changed: 9 ins; 2 del; 26 mod; 2218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/threadService.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
37 lines changed: 15 ins; 6 del; 16 mod; 951 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/threadService.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
25 lines changed: 19 ins; 0 del; 6 mod; 586 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/vmError.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
18 lines changed: 17 ins; 0 del; 1 mod; 1691 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/ErrorHandling/ErrorHandler.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47867 : coleenp CR: Change ThreadsList::_threads from 'mtGC' -> 'mtThread', add header comment to threadSMR.hpp file, cleanup JavaThreadIteratorWithHandle ctr, make ErrorHandling more efficient.
11 lines changed: 6 ins; 4 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/handshake/HandshakeWalkExitTest.java

rev 47864 : imported patch 10.09.open.TLH_hang_fix.rehn
6 lines changed: 0 ins; 4 del; 2 mod; 70 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/threadSMR.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47865 : dholmes CR: Fix indents, trailing spaces and various typos. Add descriptions for the '_cnt', '_max' and '_times" fields, add impl notes to document the type choices.
rev 47867 : coleenp CR: Change ThreadsList::_threads from 'mtGC' -> 'mtThread', add header comment to threadSMR.hpp file, cleanup JavaThreadIteratorWithHandle ctr, make ErrorHandling more efficient.
121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/threadSMR.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47867 : coleenp CR: Change ThreadsList::_threads from 'mtGC' -> 'mtThread', add header comment to threadSMR.hpp file, cleanup JavaThreadIteratorWithHandle ctr, make ErrorHandling more efficient.
257 lines changed: 257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/threadSMR.inline.hpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47867 : coleenp CR: Change ThreadsList::_threads from 'mtGC' -> 'mtThread', add header comment to threadSMR.hpp file, cleanup JavaThreadIteratorWithHandle ctr, make ErrorHandling more efficient.
124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47867 : coleenp CR: Change ThreadsList::_threads from 'mtGC' -> 'mtThread', add header comment to threadSMR.hpp file, cleanup JavaThreadIteratorWithHandle ctr, make ErrorHandling more efficient.
121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/CountStackFramesAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/InterruptAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/IsInterruptedAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/ResumeAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/SetNameAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/SetPriorityAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/StopAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
119 lines changed: 119 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Thread/TestThreadDumpSMRInfo.java

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/handshake/HandshakeWalkOneExitTest.java

rev 47864 : imported patch 10.09.open.TLH_hang_fix.rehn
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ddaugher/Bin/webrev.latest (vers 25.16-hg+openjdk.java.net).