| Prepared by: | dcubed on Tue Jan 28 14:37:03 EST 2020 |
|---|---|
| Workspace: | /work/shared/bug_hunt/8183909/8236035_exp_for_jdk14/open |
| Compare against: | /work/shared/bug_hunt/8183909/8153224_base_for_jdk14/open |
| Compare against version: | 8236035.patch.cr1 |
| Summary of changes: | 25 lines changed: 3 ins; 2 del; 20 mod; 2453 unchg |
| Patch of changes: | open.patch |
| Bug id: | JDK-8236035 : refactor ObjectMonitor::set_owner() and _owner field setting |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/objectMonitor.cpp
rev 57560 : imported patch 8236035.patch.cr0 rev 57561 : dholmes CR - rename simply_set_owner_from() -> set_owner_from() and simply_set_owner_from_BasicLock() -> set_owner_from_BasicLock(); rename release_clear_owner_with_barrier() -> release_clear_owner() and refactor barrier code back into the call sites. rev 57562 : kbarrett CR - rearrange some loads of _owner field to be more efficient; clarify header comment for try_set_owner_from() declaration; make some loads of _owner field DEBUG_ONLY since they only exist for assert()'s; update related logging calls to use the existing function parameter instead.8 lines changed: 1 ins; 1 del; 6 mod; 2004 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/objectMonitor.hpp
rev 57560 : imported patch 8236035.patch.cr0 rev 57561 : dholmes CR - rename simply_set_owner_from() -> set_owner_from() and simply_set_owner_from_BasicLock() -> set_owner_from_BasicLock(); rename release_clear_owner_with_barrier() -> release_clear_owner() and refactor barrier code back into the call sites. rev 57562 : kbarrett CR - rearrange some loads of _owner field to be more efficient; clarify header comment for try_set_owner_from() declaration; make some loads of _owner field DEBUG_ONLY since they only exist for assert()'s; update related logging calls to use the existing function parameter instead.3 lines changed: 2 ins; 0 del; 1 mod; 323 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/objectMonitor.inline.hpp
rev 57560 : imported patch 8236035.patch.cr0 rev 57561 : dholmes CR - rename simply_set_owner_from() -> set_owner_from() and simply_set_owner_from_BasicLock() -> set_owner_from_BasicLock(); rename release_clear_owner_with_barrier() -> release_clear_owner() and refactor barrier code back into the call sites. rev 57562 : kbarrett CR - rearrange some loads of _owner field to be more efficient; clarify header comment for try_set_owner_from() declaration; make some loads of _owner field DEBUG_ONLY since they only exist for assert()'s; update related logging calls to use the existing function parameter instead.14 lines changed: 0 ins; 1 del; 13 mod; 126 unchg
This code review page was prepared using /Users/dcubed/Bin/webrev (vers 25.18-hg+openjdk.java.net).