Code Review for gtkwrapper

Prepared by:ddhill on Fri Apr 22 18:32:05 EDT 2016
Workspace:/home/ddhill/sb/9/gtkwrapper
Compare against: ssh://hg.openjdk.java.net/openjfx/9-dev/rt
Compare against version:9733
Summary of changes: 3916 lines changed: 3403 ins; 488 del; 25 mod; 6066 unchg
Changeset: gtkwrapper.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw buildSrc/linux.gradle

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
3 lines changed: 1 ins; 0 del; 2 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
22 lines changed: 22 ins; 0 del; 0 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/GlassApplication.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
59 lines changed: 59 ins; 0 del; 0 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/GlassCommonDialogs.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
14 lines changed: 2 ins; 6 del; 6 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/GlassRobot.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
2 lines changed: 0 ins; 1 del; 1 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/glass_dnd.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
13 lines changed: 2 ins; 8 del; 3 mod; 1281 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/glass_general.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
45 lines changed: 0 ins; 45 del; 0 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/glass_general.h

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
3 lines changed: 2 ins; 1 del; 0 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/glass_gtkcompat.h

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
32 lines changed: 0 ins; 32 del; 0 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/glass_screen.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/glass_window.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
30 lines changed: 5 ins; 15 del; 10 mod; 1849 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/graphics/src/main/native-glass/gtk/glass_window_ime.cpp

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 274 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/main/native-glass/gtk/wrapper.h

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/main/native-glass/gtk/wrapper_gdk.c

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
1687 lines changed: 1687 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/main/native-glass/gtk/wrapper_gtk.c

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
1141 lines changed: 1141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/main/native-glass/gtk/wrapper_main.c

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw modules/graphics/src/main/native-glass/gtk/wrapper_pix.c

rev 9734 : 8087516: Conditional support for GTK 3 on Linux
Reviewed-by:
237 lines changed: 237 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/graphics/src/main/native-glass/gtk/glass_gtkcompat.cpp

380 lines changed: 0 ins; 380 del; 0 mod; 0 unchg

This code review page was prepared using /home/ddhill/bin/webrev (vers 25.12-hg+openjdk.java.net).