Code Review for rt

Prepared by:ddhill on Tue Apr 18 16:36:20 EDT 2017
Workspace:/home/ddhill/sb/10/graphics/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/10-dev/rt
Compare against version:10423
Summary of changes: 25955 lines changed: 8 ins; 25935 del; 12 mod; 5076 unchg
Changeset: rt.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw build.gradle

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
18 lines changed: 7 ins; 8 del; 3 mod; 4431 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw buildSrc/armv6hf.gradle

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
170 lines changed: 0 ins; 162 del; 8 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/javafx.graphics/src/main/java/com/sun/prism/es2/MonocleGLContext.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
2 lines changed: 1 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw modules/javafx.graphics/src/main/native-prism-es2/eglWrapper/eglWrapper.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
4 lines changed: 0 ins; 4 del; 0 mod; 195 unchg

------ ------ ------ ------ Old --- ----- --- buildSrc/armv5sf.gradle

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
577 lines changed: 0 ins; 577 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- buildSrc/armv6sf.gradle

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
577 lines changed: 0 ins; 577 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- buildSrc/armv7hf.gradle

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
567 lines changed: 0 ins; 567 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- buildSrc/armv7sf.gradle

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
577 lines changed: 0 ins; 577 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- buildSrc/x86egl.gradle

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
585 lines changed: 0 ins; 585 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensApplication.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
1806 lines changed: 0 ins; 1806 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensClipboardDelegate.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensCursor.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
130 lines changed: 0 ins; 130 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensDnDClipboard.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
134 lines changed: 0 ins; 134 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensLogger.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensMenuBarDelegate.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensMenuDelegate.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
95 lines changed: 0 ins; 95 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensPixels.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
94 lines changed: 0 ins; 94 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensPlatformFactory.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
61 lines changed: 0 ins; 61 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensRobot.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
115 lines changed: 0 ins; 115 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensSystemClipboard.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
104 lines changed: 0 ins; 104 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensTimer.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
77 lines changed: 0 ins; 77 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensTouchInputSupport.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
131 lines changed: 0 ins; 131 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensView.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
259 lines changed: 0 ins; 259 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/java/com/sun/glass/ui/lens/LensWindow.java

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
436 lines changed: 0 ins; 436 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensApplication.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
845 lines changed: 0 ins; 845 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensCommon.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
1546 lines changed: 0 ins; 1546 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensCursor.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
137 lines changed: 0 ins; 137 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensCursorImages.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
1609 lines changed: 0 ins; 1609 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensCursorImages.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensInputEvents.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
442 lines changed: 0 ins; 442 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensLogger.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
418 lines changed: 0 ins; 418 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensLogger.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
124 lines changed: 0 ins; 124 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensPixels.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
41 lines changed: 0 ins; 41 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensRobot.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
132 lines changed: 0 ins; 132 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensScreen.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
93 lines changed: 0 ins; 93 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensView.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
318 lines changed: 0 ins; 318 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/LensWindow.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
1027 lines changed: 0 ins; 1027 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/android/android.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
401 lines changed: 0 ins; 401 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/android/android.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
182 lines changed: 0 ins; 182 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/android/com_oracle_dalvik_FXActivity.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
112 lines changed: 0 ins; 112 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/android/com_oracle_dalvik_FXActivity_InternalSurfaceView.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
164 lines changed: 0 ins; 164 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/cursor/fbCursor/fbCursor.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
108 lines changed: 0 ins; 108 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/cursor/nullCursor/nullCursor.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/dalvik/dalvikConst.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
55 lines changed: 0 ins; 55 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/dalvik/dalvikInput.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
239 lines changed: 0 ins; 239 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/dalvik/dalvikInput.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/dalvik/dalvikUtils.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
125 lines changed: 0 ins; 125 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/dalvik/dalvikUtils.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
138 lines changed: 0 ins; 138 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/dalvik/screen.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
140 lines changed: 0 ins; 140 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/input/LensInput.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/input/android/androidInput.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
98 lines changed: 0 ins; 98 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/input/android/androidInput.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
78 lines changed: 0 ins; 78 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/input/android/androidLens.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
177 lines changed: 0 ins; 177 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/input/android/androidLens.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
79 lines changed: 0 ins; 79 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/input/udev/udevInput.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
3404 lines changed: 0 ins; 3404 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/input/x11Container/x11Input.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensRFB/lensRFB.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
48 lines changed: 0 ins; 48 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensRFB/rfb.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
369 lines changed: 0 ins; 369 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensRFB/wrapped_rfb.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/dispmanCursor.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
521 lines changed: 0 ins; 521 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/fbRobot.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
180 lines changed: 0 ins; 180 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/imx6Cursor.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
504 lines changed: 0 ins; 504 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/initPlatform.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
127 lines changed: 0 ins; 127 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/lensPort.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
83 lines changed: 0 ins; 83 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/lensPortInternal.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
59 lines changed: 0 ins; 59 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/lensPortLogger.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
109 lines changed: 0 ins; 109 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/omapCursor.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
382 lines changed: 0 ins; 382 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/wrapped_bcm.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
134 lines changed: 0 ins; 134 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/lensport/wrapped_functions.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
339 lines changed: 0 ins; 339 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/LensWindowManager.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
1594 lines changed: 0 ins; 1594 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/LensWindowManager.h

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
250 lines changed: 0 ins; 250 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/robot.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
137 lines changed: 0 ins; 137 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/screen/androidScreen.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
131 lines changed: 0 ins; 131 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/screen/dfbScreen.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
953 lines changed: 0 ins; 953 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/screen/fbdevScreen.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
345 lines changed: 0 ins; 345 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/screen/headlessScreen.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
276 lines changed: 0 ins; 276 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- modules/javafx.graphics/src/main/native-glass/lens/wm/screen/x11ContainerScreen.c

rev 10424 : 8090969: Remove lens implementation in Glass
Reviewed-by:
189 lines changed: 0 ins; 189 del; 0 mod; 0 unchg

This code review page was prepared using /home/ddhill/bin/webrev (vers 25.16-hg+openjdk.java.net).