Code Review for hotspot

Prepared by:denghui.ddh@alibaba-inc.com on Wed Oct 9 16:40:33 CST 2019
Workspace:/ssd1/home/ddh/dev/jdk8u-jfr-incubator/hotspot
Compare against: http://hg.openjdk.java.net/jdk8u/jdk8u-jfr-incubator/hotspot
Compare against version:9054
Summary of changes: 1992 lines changed: 906 ins; 819 del; 267 mod; 4760 unchg
Changeset: hotspot.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/bfsClosure.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
rev 9057 : 8229437: assert(is_aligned(ref, HeapWordSize)) failed: invariant
Reviewed-by: egahlin
24 lines changed: 7 ins; 14 del; 3 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/bfsClosure.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
2 lines changed: 1 ins; 1 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/bitset.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
1 line changed: 0 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/dfsClosure.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
rev 9057 : 8229437: assert(is_aligned(ref, HeapWordSize)) failed: invariant
Reviewed-by: egahlin
31 lines changed: 11 ins; 5 del; 15 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/dfsClosure.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
3 lines changed: 1 ins; 1 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/edge.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
1 line changed: 0 ins; 0 del; 1 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/edgeStore.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
267 lines changed: 191 ins; 27 del; 49 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/edgeStore.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
70 lines changed: 19 ins; 31 del; 20 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/edgeUtils.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
171 lines changed: 1 ins; 162 del; 8 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/edgeUtils.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
8 lines changed: 3 ins; 3 del; 2 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/rootSetClosure.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
43 lines changed: 8 ins; 15 del; 20 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/chains/rootSetClosure.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
9 lines changed: 1 ins; 5 del; 3 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
rev 9056 : 8228834: Regression caused by JDK-8214542 not installing complete checkpoint data to candidates
Reviewed-by: egahlin
86 lines changed: 20 ins; 47 del; 19 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
rev 9056 : 8228834: Regression caused by JDK-8214542 not installing complete checkpoint data to candidates
Reviewed-by: egahlin
9 lines changed: 3 ins; 2 del; 4 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/checkpoint/objectSampleWriter.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
44 lines changed: 7 ins; 20 del; 17 mod; 578 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/checkpoint/objectSampleWriter.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
9 lines changed: 0 ins; 4 del; 5 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/checkpoint/rootResolver.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
2 lines changed: 1 ins; 1 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/leakProfiler.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
88 lines changed: 23 ins; 45 del; 20 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/leakProfiler.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
23 lines changed: 1 ins; 21 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/sampling/objectSampler.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
165 lines changed: 114 ins; 25 del; 26 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/sampling/objectSampler.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
28 lines changed: 21 ins; 3 del; 4 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/startOperation.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
23 lines changed: 0 ins; 17 del; 6 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/leakprofiler/stopOperation.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
20 lines changed: 0 ins; 16 del; 4 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/recorder/checkpoint/types/jfrType.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
rev 9056 : 8228834: Regression caused by JDK-8214542 not installing complete checkpoint data to candidates
Reviewed-by: egahlin
2 lines changed: 0 ins; 0 del; 2 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/recorder/service/jfrRecorderService.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
40 lines changed: 21 ins; 9 del; 10 mod; 520 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
58 lines changed: 12 ins; 31 del; 15 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/recorder/stacktrace/jfrStackTraceRepository.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
22 lines changed: 10 ins; 6 del; 6 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/support/jfrFlush.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
5 lines changed: 2 ins; 0 del; 3 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/support/jfrThreadLocal.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
7 lines changed: 4 ins; 2 del; 1 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/jfr/support/jfrThreadLocal.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
3 lines changed: 0 ins; 2 del; 1 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/vm_operations.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
1 line changed: 1 ins; 0 del; 0 mod; 415 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/jfr/leakprofiler/chains/pathToGcRootsOperation.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
131 lines changed: 131 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/jfr/leakprofiler/chains/pathToGcRootsOperation.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/jfr/leakprofiler/checkpoint/eventEmitter.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
147 lines changed: 147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/jfr/leakprofiler/checkpoint/eventEmitter.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/jfr/leakprofiler/utilities/vmOperation.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/share/vm/jfr/leakprofiler/emitEventOperation.cpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
235 lines changed: 0 ins; 235 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/share/vm/jfr/leakprofiler/emitEventOperation.hpp

rev 9055 : 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
Reviewed-by: egahlin, rwestberg
69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

This code review page was prepared using /home/denghui.ddh/webrev.ksh (vers 25.18-hg+openjdk.java.net).