Code Review for jdk9-dev-platform-logging-api

Prepared by:dfuchs on Fri Nov 20 17:44:42 CET 2015
Workspace:/Users/danielfuchs/workspaces/jdk/jdk9-dev-platform-logging-api
Summary of changes: 20779 lines changed: 19946 ins; 663 del; 170 mod; 11411 unchg
Patch of changes: jdk9-dev-platform-logging-api.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules.xml

4 lines changed: 4 ins; 0 del; 0 mod; 2020 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/java/lang/RuntimePermission.java

13 lines changed: 13 ins; 0 del; 0 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/java/lang/System.java

650 lines changed: 648 ins; 2 del; 0 mod; 1274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/sun/util/logging/PlatformLogger.java

536 lines changed: 135 ins; 282 del; 119 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.desktop/share/classes/sun/font/FontUtilities.java

2 lines changed: 2 ins; 0 del; 0 mod; 512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.logging/share/classes/java/util/logging/LogManager.java

71 lines changed: 68 ins; 0 del; 3 mod; 2607 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.logging/share/classes/java/util/logging/LogRecord.java

27 lines changed: 22 ins; 1 del; 4 mod; 676 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.logging/share/classes/java/util/logging/Logger.java

78 lines changed: 67 ins; 1 del; 10 mod; 2218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.logging/share/classes/java/util/logging/SimpleFormatter.java

9 lines changed: 4 ins; 1 del; 4 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/java/lang/management/DefaultPlatformMBeanProvider.java

24 lines changed: 2 ins; 0 del; 22 mod; 446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/sun/management/ManagementFactoryHelper.java

50 lines changed: 44 ins; 0 del; 6 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/java/util/logging/LoggerSubclass.java

1 line changed: 0 ins; 0 del; 1 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/sun/util/logging/PlatformLoggerTest.java

4 lines changed: 2 ins; 1 del; 1 mod; 266 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/AbstractLoggerWrapper.java

380 lines changed: 380 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/BootstrapLogger.java

1074 lines changed: 1074 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/DefaultLoggerFinder.java

173 lines changed: 173 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/LazyLoggers.java

446 lines changed: 446 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/LocalizedLoggerWrapper.java

155 lines changed: 155 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/LoggerFinderLoader.java

210 lines changed: 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/LoggerWrapper.java

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/SimpleConsoleLogger.java

486 lines changed: 486 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.base/share/classes/jdk/internal/logger/package-info.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.logging/share/classes/META-INF/services/jdk.internal.logger.DefaultLoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.logging/share/classes/sun/util/logging/internal/LoggingProviderImpl.java

466 lines changed: 466 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.logging/share/classes/sun/util/logging/internal/package-info.java

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/Logger/Level/LoggerLevelTest.java

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/Logger/custom/AccessSystemLogger.java

78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/Logger/custom/CustomLoggerTest.java

728 lines changed: 728 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/Logger/custom/META-INF/services/java.lang.System$LoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/Logger/default/AccessSystemLogger.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/Logger/default/DefaultLoggerTest.java

726 lines changed: 726 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/Logger/interface/LoggerInterfaceTest.java

592 lines changed: 592 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/BaseLoggerFinderTest/AccessSystemLogger.java

78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/BaseLoggerFinderTest/BaseLoggerFinder.java

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/BaseLoggerFinderTest/BaseLoggerFinderTest.java

694 lines changed: 694 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/BaseLoggerFinderTest/CustomSystemClassLoader.java

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/BaseLoggerFinderTest/META-INF/services/java.lang.System$LoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/BaseLoggerFinderTest/TestLoggerFinder.java

181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/DefaultLoggerFinderTest/AccessSystemLogger.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/DefaultLoggerFinderTest/DefaultLoggerFinderTest.java

887 lines changed: 887 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BaseDefaultLoggerFinderTest/AccessSystemLogger.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BaseDefaultLoggerFinderTest/BaseDefaultLoggerFinderTest.java

768 lines changed: 768 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BaseDefaultLoggerFinderTest/CustomSystemClassLoader.java

117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BaseDefaultLoggerFinderTest/META-INF/services/java.lang.System$LoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BaseLoggerBridgeTest/BaseLoggerBridgeTest.java

1058 lines changed: 1058 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BaseLoggerBridgeTest/CustomSystemClassLoader.java

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BaseLoggerBridgeTest/META-INF/services/java.lang.System$LoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BasePlatformLoggerTest/BasePlatformLoggerTest.java

732 lines changed: 732 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BasePlatformLoggerTest/CustomSystemClassLoader.java

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BasePlatformLoggerTest/META-INF/services/java.lang.System$LoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest.java

430 lines changed: 430 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/LoggerBridgeTest/CustomSystemClassLoader.java

141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/LoggerBridgeTest/LoggerBridgeTest.java

1087 lines changed: 1087 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/LoggerBridgeTest/META-INF/services/java.lang.System$LoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/AccessSystemLogger.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/CustomSystemClassLoader.java

118 lines changed: 118 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/LoggerFinderLoaderTest.java

882 lines changed: 882 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/META-INF/services/java.lang.System$LoggerFinder

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/PlatformLoggerBridgeTest/CustomSystemClassLoader.java

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/PlatformLoggerBridgeTest/META-INF/services/java.lang.System$LoggerFinder

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/PlatformLoggerBridgeTest/PlatformLoggerBridgeTest.java

876 lines changed: 876 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/api/LoggerFinderAPITest.java

497 lines changed: 497 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/backend/LoggerFinderBackendTest.java

2316 lines changed: 2316 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/backend/META-INF/services/java.lang.System$LoggerFinder

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/internal/backend/SystemClassLoader.java

98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/jdk/DefaultLoggerBridgeTest/DefaultLoggerBridgeTest.java

850 lines changed: 850 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/java/lang/System/LoggerFinder/jdk/DefaultPlatformLoggerTest/DefaultPlatformLoggerTest.java

544 lines changed: 544 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jdk/src/java.base/share/classes/sun/util/logging/LoggingProxy.java

68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jdk/src/java.base/share/classes/sun/util/logging/LoggingSupport.java

190 lines changed: 0 ins; 190 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jdk/src/java.logging/share/classes/java/util/logging/LoggingProxyImpl.java

117 lines changed: 0 ins; 117 del; 0 mod; 0 unchg

This code review page was prepared using /Users/danielfuchs/bin/webrev (vers 25.12-hg+openjdk.java.net).