Code Review for open

Prepared by:dholmes on Fri May 25 01:45:32 EDT 2018
Workspace:/export/users/dh198349/valhalla/repos/jdk-jep181/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:-4
Summary of changes: 3367 lines changed: 3279 ins; 14 del; 74 mod; 21510 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties

rev 50246 : imported patch jep181-rev1
2 lines changed: 2 ins; 0 del; 0 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

rev 50246 : imported patch jep181-rev1
rev 50247 : imported patch jep181-rev2
154 lines changed: 154 ins; 0 del; 0 mod; 3851 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java

rev 50246 : imported patch jep181-rev1
23 lines changed: 12 ins; 0 del; 11 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandle.java

rev 50246 : imported patch jep181-rev1
4 lines changed: 3 ins; 0 del; 1 mod; 1680 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandles.java

rev 50246 : imported patch jep181-rev1
28 lines changed: 9 ins; 9 del; 10 mod; 5944 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/AccessibleObject.java

rev 50246 : imported patch jep181-rev1
1 line changed: 0 ins; 0 del; 1 mod; 684 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Method.java

rev 50246 : imported patch jep181-rev1
3 lines changed: 0 ins; 0 del; 3 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Attribute.java

rev 50246 : imported patch jep181-rev1
70 lines changed: 70 ins; 0 del; 0 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

rev 50246 : imported patch jep181-rev1
1 line changed: 0 ins; 0 del; 1 mod; 2788 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/MethodAccessorGenerator.java

rev 50246 : imported patch jep181-rev1
9 lines changed: 0 ins; 4 del; 5 mod; 761 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/Reflection.java

rev 50246 : imported patch jep181-rev1
rev 50247 : imported patch jep181-rev2
rev 50248 : [mq]: jep181-rev3
18 lines changed: 17 ins; 0 del; 1 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/VerifyAccess.java

rev 50246 : imported patch jep181-rev1
rev 50247 : imported patch jep181-rev2
33 lines changed: 10 ins; 1 del; 22 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/Class.c

rev 50246 : imported patch jep181-rev1
6 lines changed: 2 ins; 0 del; 4 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/Reflection.c

rev 50246 : imported patch jep181-rev1
7 lines changed: 6 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/AccessControlTest.java

rev 50246 : imported patch jep181-rev1
6 lines changed: 2 ins; 0 del; 4 mod; 561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/invoke/SpecialInterfaceCall.java

rev 50246 : imported patch jep181-rev1
3 lines changed: 1 ins; 0 del; 2 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/lambda/vm/InterfaceAccessFlagsTest.java

rev 50246 : imported patch jep181-rev1
rev 50247 : imported patch jep181-rev2
3 lines changed: 1 ins; 0 del; 2 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/pack200/BandIntegrity.java

rev 50246 : imported patch jep181-rev1
2 lines changed: 0 ins; 0 del; 2 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/pack200/pack200-verifier/make/build.xml

rev 50246 : imported patch jep181-rev1
3 lines changed: 0 ins; 0 del; 3 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java

rev 50246 : imported patch jep181-rev1
27 lines changed: 26 ins; 0 del; 1 mod; 1886 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/FinalVirtualCallFromInterface.java

rev 50246 : imported patch jep181-rev1
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/PrivateInterfaceCall.java

rev 50246 : imported patch jep181-rev1
rev 50248 : [mq]: jep181-rev3
316 lines changed: 316 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/PrivateInterfaceCallI4.jasm

rev 50246 : imported patch jep181-rev1
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/HostOfMemberMalformedHost.jcod

rev 50247 : imported patch jep181-rev2
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/HostOfMemberMissingHost.jcod

rev 50247 : imported patch jep181-rev2
103 lines changed: 103 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/HostOfMemberNoHost.jcod

rev 50247 : imported patch jep181-rev2
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/HostOfMemberNotInstanceHost.jcod

rev 50247 : imported patch jep181-rev2
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/HostOfMemberNotOurHost.jcod

rev 50247 : imported patch jep181-rev2
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/HostWithDuplicateMembers.jcod

rev 50247 : imported patch jep181-rev2
107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/HostWithSelfMember.jcod

rev 50247 : imported patch jep181-rev2
102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/Hosts.java

rev 50247 : imported patch jep181-rev2
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/InvalidNestHost.java

rev 50247 : imported patch jep181-rev2
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/MalformedHost.jcod

rev 50247 : imported patch jep181-rev2
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/MemberMalformedHost.jcod

rev 50247 : imported patch jep181-rev2
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/MemberMissingHost.jcod

rev 50247 : imported patch jep181-rev2
103 lines changed: 103 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/MemberNoHost.jcod

rev 50247 : imported patch jep181-rev2
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/MemberNotInstanceHost.jcod

rev 50247 : imported patch jep181-rev2
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/MemberNotOurHost.jcod

rev 50247 : imported patch jep181-rev2
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/PackagedNestHost.java

rev 50247 : imported patch jep181-rev2
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/PackagedNestHost.jcod

rev 50247 : imported patch jep181-rev2
136 lines changed: 136 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/PackagedNestHost2.java

rev 50247 : imported patch jep181-rev2
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/PackagedNestHost2Member.jcod

rev 50247 : imported patch jep181-rev2
177 lines changed: 177 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/PackagedNestHostMember.jcod

rev 50247 : imported patch jep181-rev2
143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/SampleNest.java

rev 50247 : imported patch jep181-rev2
rev 50248 : [mq]: jep181-rev3
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/TestReflectionAPI.java

rev 50247 : imported patch jep181-rev2
rev 50248 : [mq]: jep181-rev3
322 lines changed: 322 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/TestSecurityManagerChecks.java

rev 50247 : imported patch jep181-rev2
110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/empty.policy

rev 50247 : imported patch jep181-rev2
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/testPkg/Host.java

rev 50247 : imported patch jep181-rev2
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/reflect/Nestmates/testPkg/Singleton.java

rev 50247 : imported patch jep181-rev2
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/dh198349/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).