Code Review for open

Prepared by:dholmes on Tue May 22 00:32:50 EDT 2018
Workspace:/export/users/dh198349/valhalla/repos/jdk-jep181/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:-3
Summary of changes: 2450 lines changed: 2415 ins; 0 del; 35 mod; 35416 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/jdwp/jdwp.spec

rev 50075 : imported patch jep181-rev1
21 lines changed: 16 ins; 0 del; 5 mod; 3283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmti.xml

rev 50075 : imported patch jep181-rev1
25 lines changed: 22 ins; 0 del; 3 mod; 14830 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp

rev 50075 : imported patch jep181-rev1
46 lines changed: 46 ins; 0 del; 0 mod; 914 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiClassFileReconstituter.hpp

rev 50075 : imported patch jep181-rev1
3 lines changed: 2 ins; 0 del; 1 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiExport.cpp

rev 50075 : imported patch jep181-rev1
8 lines changed: 8 ins; 0 del; 0 mod; 2849 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiH.xsl

rev 50075 : imported patch jep181-rev1
6 lines changed: 1 ins; 0 del; 5 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.cpp

rev 50075 : imported patch jep181-rev1
rev 50076 : [mq]: jep181-rev2
117 lines changed: 117 ins; 0 del; 0 mod; 4238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.hpp

rev 50075 : imported patch jep181-rev1
2 lines changed: 1 ins; 0 del; 1 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java

rev 50075 : imported patch jep181-rev1
rev 50076 : [mq]: jep181-rev2
15 lines changed: 8 ins; 0 del; 7 mod; 736 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/native/libinstrument/JavaExceptions.c

rev 50075 : imported patch jep181-rev1
6 lines changed: 5 ins; 0 del; 1 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachine.java

rev 50075 : imported patch jep181-rev1
6 lines changed: 2 ins; 0 del; 4 mod; 914 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java

rev 50075 : imported patch jep181-rev1
4 lines changed: 3 ins; 0 del; 1 mod; 1549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java

rev 50075 : imported patch jep181-rev1
2 lines changed: 0 ins; 0 del; 2 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/VirtualMachineImpl.c

rev 50075 : imported patch jep181-rev1
2 lines changed: 0 ins; 0 del; 2 mod; 949 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/error_messages.c

rev 50075 : imported patch jep181-rev1
2 lines changed: 1 ins; 0 del; 1 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdwp.agent/share/native/libjdwp/util.c

rev 50075 : imported patch jep181-rev1
5 lines changed: 4 ins; 0 del; 1 mod; 2867 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/Host/Host.java

rev 50075 : imported patch jep181-rev1
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/Host/redef/Host.java

rev 50075 : imported patch jep181-rev1
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostA/Host.java

rev 50075 : imported patch jep181-rev1
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostA/redef/Host.java

rev 50075 : imported patch jep181-rev1
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostAB/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostAB/redef/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostABC/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostABC/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostABCD/redef/Host.java

rev 50075 : imported patch jep181-rev1
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostABD/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostAC/redef/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostACB/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostB/redef/Host.java

rev 50075 : imported patch jep181-rev1
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostBA/redef/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostBAC/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostBCA/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostCAB/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/HostCBA/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/instrument/RedefineNestmateAttr/TestNestmateAttr.java

rev 50075 : imported patch jep181-rev1
376 lines changed: 376 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/ProblemList.txt

rev 50075 : imported patch jep181-rev1
13 lines changed: 12 ins; 0 del; 1 mod; 125 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/Host/Host.java

rev 50075 : imported patch jep181-rev1
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/Host/redef/Host.java

rev 50075 : imported patch jep181-rev1
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostA/Host.java

rev 50075 : imported patch jep181-rev1
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostA/redef/Host.java

rev 50075 : imported patch jep181-rev1
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostAB/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostAB/redef/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostABC/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostABC/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostABCD/redef/Host.java

rev 50075 : imported patch jep181-rev1
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostABD/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostAC/redef/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostACB/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostB/redef/Host.java

rev 50075 : imported patch jep181-rev1
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostBA/redef/Host.java

rev 50075 : imported patch jep181-rev1
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostBAC/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostBCA/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostCAB/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/HostCBA/redef/Host.java

rev 50075 : imported patch jep181-rev1
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/NamedBuffer.java

rev 50075 : imported patch jep181-rev1
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java

rev 50075 : imported patch jep181-rev1
rev 50076 : [mq]: jep181-rev2
582 lines changed: 582 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/dh198349/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).