Code Review for open

Prepared by:dholmes on Fri Dec 15 03:51:00 EST 2017
Workspace:/export/users/dh198349/valhalla/repos/valhalla-dev/open
Compare against: ssh://hg.openjdk.java.net/valhalla/valhalla
Branch:nestmates
Summary of changes: 1996 lines changed: 1195 ins; 562 del; 239 mod; 24995 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

70 lines changed: 31 ins; 38 del; 1 mod; 6237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stackMapFrame.hpp

1 line changed: 0 ins; 0 del; 1 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verifier.cpp

38 lines changed: 7 ins; 4 del; 27 mod; 3051 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/linkResolver.cpp

18 lines changed: 0 ins; 18 del; 0 mod; 1831 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

25 lines changed: 2 ins; 6 del; 17 mod; 3945 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

1 line changed: 0 ins; 0 del; 1 mod; 1531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersEntry.jcod

1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersLength.jcod

1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestMember.jcod

1 line changed: 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TestNestmateAttributes.java

5 lines changed: 0 ins; 3 del; 2 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestMembers.jcod

1 line changed: 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerMissingHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerNoHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerNotInstanceHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 387 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerNotOurHost.jcod

5 lines changed: 3 ins; 0 del; 2 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost2Member.jcod

1 line changed: 0 ins; 0 del; 1 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHostMember.jcod

1 line changed: 0 ins; 0 del; 1 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetMissingHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetNoHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetNotInstanceHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetNotOurHost.jcod

5 lines changed: 3 ins; 0 del; 2 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java

426 lines changed: 291 ins; 1 del; 134 mod; 1351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/ExternalSub.jcod

1 line changed: 0 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/ExternalSuper.jcod

1 line changed: 0 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/ExternalSub.jcod

1 line changed: 0 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/ExternalSuper.jcod

1 line changed: 0 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethod.jcod

1 line changed: 0 ins; 0 del; 1 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethodWithSuper.jcod

1 line changed: 0 ins; 0 del; 1 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingNestHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberMalformedHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberMissingHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNoHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNotInstanceHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNotOurHost.jcod

5 lines changed: 3 ins; 0 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/Hosts.java

12 lines changed: 12 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MalformedHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberMalformedHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberMissingHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNoHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNotInstanceHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNotOurHost.jcod

5 lines changed: 3 ins; 0 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost.jcod

1 line changed: 0 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost2Member.jcod

1 line changed: 0 ins; 0 del; 1 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHostMember.jcod

1 line changed: 0 ins; 0 del; 1 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/TestReflectionAPI.java

33 lines changed: 27 ins; 0 del; 6 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/SelectionResolution/InvokeInterfaceICCE.java

14 lines changed: 0 ins; 13 del; 1 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/SelectionResolution/InvokeInterfaceSuccessTest.java

14 lines changed: 14 ins; 0 del; 0 mod; 147 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerSelfHost.jcod

378 lines changed: 378 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/InvalidNestHost.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetSelfHost.jcod

154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostWithDuplicateMembers.jcod

107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostWithSelfMember.jcod

102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/InvalidNestHost.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/classFileParsing/DuplicateNestMemberEntry.jcod

110 lines changed: 0 ins; 110 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/privateMethods/StaticIfaceError.jcod

147 lines changed: 0 ins; 147 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/privateMethods/StaticIfaceGood.jcod

148 lines changed: 0 ins; 148 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvokeInterface.java

74 lines changed: 0 ins; 74 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/dh198349/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).