Code Review for open

Prepared by:dholmes on Mon Jan 8 23:43:07 EST 2018
Workspace:/export/users/dh198349/valhalla/repos/valhalla-dev/open
Compare against: ssh://hg.openjdk.java.net/valhalla/valhalla
Branch:nestmates
Summary of changes: 2045 lines changed: 1193 ins; 560 del; 292 mod; 24944 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

71 lines changed: 31 ins; 38 del; 2 mod; 6236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stackMapFrame.hpp

1 line changed: 0 ins; 0 del; 1 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verifier.cpp

38 lines changed: 5 ins; 2 del; 31 mod; 3049 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/linkResolver.cpp

19 lines changed: 0 ins; 18 del; 1 mod; 1830 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

26 lines changed: 2 ins; 6 del; 18 mod; 3944 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 1530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersEntry.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersLength.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestMember.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TestNestmateAttributes.java

6 lines changed: 0 ins; 3 del; 3 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestMembers.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerMissingHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerNoHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerNotInstanceHost.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerNotOurHost.jcod

6 lines changed: 3 ins; 0 del; 3 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost2Member.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHostMember.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetMissingHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetNoHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetNotInstanceHost.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetNotOurHost.jcod

6 lines changed: 3 ins; 0 del; 3 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java

427 lines changed: 291 ins; 1 del; 135 mod; 1350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/ExternalSub.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateConstructors/ExternalSuper.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/ExternalSub.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/ExternalSuper.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethod.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethodWithSuper.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingNestHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberMalformedHost.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberMissingHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNoHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNotInstanceHost.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNotOurHost.jcod

6 lines changed: 3 ins; 0 del; 3 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/Hosts.java

13 lines changed: 12 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MalformedHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberMalformedHost.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberMissingHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNoHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNotInstanceHost.jcod

3 lines changed: 0 ins; 0 del; 3 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNotOurHost.jcod

6 lines changed: 3 ins; 0 del; 3 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost2Member.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHostMember.jcod

2 lines changed: 0 ins; 0 del; 2 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/TestReflectionAPI.java

34 lines changed: 27 ins; 0 del; 7 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/SelectionResolution/InvokeInterfaceICCE.java

15 lines changed: 0 ins; 13 del; 2 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/SelectionResolution/InvokeInterfaceSuccessTest.java

15 lines changed: 14 ins; 0 del; 1 mod; 146 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/CallerSelfHost.jcod

378 lines changed: 378 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/InvalidNestHost.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TargetSelfHost.jcod

154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostWithDuplicateMembers.jcod

107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostWithSelfMember.jcod

102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/InvalidNestHost.java

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/classFileParsing/DuplicateNestMemberEntry.jcod

110 lines changed: 0 ins; 110 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/privateMethods/StaticIfaceError.jcod

147 lines changed: 0 ins; 147 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/privateMethods/StaticIfaceGood.jcod

148 lines changed: 0 ins; 148 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvokeInterface.java

74 lines changed: 0 ins; 74 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/dh198349/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).