Code Review for hotspot

Prepared by:dlong on Tue Sep 12 22:24:56 PDT 2017
Workspace:/export/drlong/ws/dev0/hotspot
Compare against: http://hg.openjdk.java.net/jdk10/hs/hotspot
Summary of changes: 2358 lines changed: 1957 ins; 165 del; 236 mod; 27312 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/alloc/ComputeBlockOrder.java

8 lines changed: 4 ins; 0 del; 4 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CheckGraalInvariants.java

1 line changed: 0 ins; 0 del; 1 mod; 509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraalCompilerTest.java

1 line changed: 0 ins; 0 del; 1 mod; 1427 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/StaticInterfaceFieldTest.java

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnbalancedMonitorsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnsafeReadEliminationTest.java

75 lines changed: 75 ins; 0 del; 0 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyBailoutUsageTest.java

1 line changed: 0 ins; 0 del; 1 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyDebugUsageTest.java

1 line changed: 0 ins; 0 del; 1 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyVirtualizableTest.java

1 line changed: 0 ins; 0 del; 1 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PEAReadEliminationTest.java

28 lines changed: 1 ins; 17 del; 10 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/tutorial/StaticAnalysis.java

1 line changed: 0 ins; 0 del; 1 mod; 620 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/GraalError.java

6 lines changed: 6 ins; 0 del; 0 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/Node.java

10 lines changed: 10 ins; 0 del; 0 mod; 1200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeBitMap.java

1 line changed: 0 ins; 0 del; 1 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java

47 lines changed: 19 ins; 14 del; 14 mod; 635 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotLIRGenerator.java

2 lines changed: 1 ins; 0 del; 1 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorld.java

37 lines changed: 36 ins; 0 del; 1 mod; 817 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java

1 line changed: 0 ins; 0 del; 1 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilerConfigurationFactory.java

15 lines changed: 4 ins; 5 del; 6 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilerRuntimeHotSpotVMConfig.java

2 lines changed: 1 ins; 0 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotBackend.java

6 lines changed: 5 ins; 0 del; 1 mod; 432 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotLIRGenerator.java

24 lines changed: 11 ins; 0 del; 13 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java

11 lines changed: 5 ins; 3 del; 3 mod; 795 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java

47 lines changed: 2 ins; 41 del; 4 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java

3 lines changed: 2 ins; 0 del; 1 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/aot/ReplaceConstantNodesPhase.java

2 lines changed: 2 ins; 0 del; 0 mod; 511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/aot/ResolveConstantSnippets.java

32 lines changed: 31 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java

189 lines changed: 116 ins; 2 del; 71 mod; 4341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.sparc/src/org/graalvm/compiler/lir/sparc/SPARCPrefetchOp.java

5 lines changed: 0 ins; 1 del; 4 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphDecoder.java

38 lines changed: 15 ins; 23 del; 0 mod; 1931 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/IfNode.java

122 lines changed: 122 ins; 0 del; 0 mod; 1248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/NamedLocationIdentity.java

6 lines changed: 5 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/SignedRemNode.java

19 lines changed: 14 ins; 0 del; 5 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/RawLoadNode.java

34 lines changed: 33 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderConfiguration.java

47 lines changed: 29 ins; 4 del; 14 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderContext.java

16 lines changed: 16 ins; 0 del; 0 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/virtual/VirtualArrayNode.java

3 lines changed: 1 ins; 0 del; 2 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/PEGraphDecoderTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/CachingPEGraphDecoder.java

2 lines changed: 0 ins; 0 del; 2 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/GraphKit.java

4 lines changed: 0 ins; 0 del; 4 mod; 561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java

21 lines changed: 20 ins; 0 del; 1 mod; 1150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetTemplate.java

25 lines changed: 0 ins; 23 del; 2 mod; 1682 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java

7 lines changed: 3 ins; 0 del; 4 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/PEReadEliminationBlockState.java

38 lines changed: 32 ins; 0 del; 6 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/PEReadEliminationClosure.java

97 lines changed: 56 ins; 13 del; 28 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/ReadEliminationClosure.java

50 lines changed: 21 ins; 16 del; 13 mod; 358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/WordOperationPlugin.java

3 lines changed: 3 ins; 0 del; 0 mod; 516 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/GraphProtocol.java

1 line changed: 0 ins; 0 del; 1 mod; 677 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.options/src/org/graalvm/options/OptionKey.java

3 lines changed: 0 ins; 2 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.options/src/org/graalvm/options/OptionType.java

16 lines changed: 11 ins; 1 del; 4 mod; 207 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/HashMapGetTest.java

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/OffHeapUnsafeAccessTest.java

146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/StableArrayReadFoldingTest.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/TrufflePEATest.java

133 lines changed: 133 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotInvokeDynamicPluginTest.java

145 lines changed: 145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HsErrLogTest.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotInvokeDynamicPlugin.java

156 lines changed: 156 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/ResolveDynamicConstantNode.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/ResolveDynamicStubCall.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/bytecode/BC_irem4.java

69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/InvokeDynamicPlugin.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/embedded/users/drlong/ws/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).