Code Review for jdk-7142596

Prepared by:dmocek on Fri Jul 13 13:17:45 PDT 2012
Workspace:/home/dmocek/ws/openjdk/jdk-7142596
Compare against: http://hg.openjdk.java.net/jdk8/tl/jdk
Summary of changes: 793 lines changed: 377 ins; 100 del; 316 mod; 10152 unchg
Patch of changes: jdk-7142596.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/ProblemList.txt

13 lines changed: 0 ins; 13 del; 0 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/TEST.ROOT

1 line changed: 0 ins; 0 del; 1 mod; 11 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/com/sun/jndi/rmi/registry/RegistryContext/ContextWithNullProperties.java

17 lines changed: 4 ins; 8 del; 5 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/com/sun/jndi/rmi/registry/RegistryContext/UnbindIdempotent.java

40 lines changed: 30 ins; 5 del; 5 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/Naming/LookupNameWithColon.java

13 lines changed: 4 ins; 4 del; 5 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/Naming/RmiIsNoScheme.java

8 lines changed: 1 ins; 3 del; 4 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/Naming/UnderscoreHost.java

37 lines changed: 1 ins; 0 del; 36 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/Naming/legalRegistryNames/LegalRegistryNames.java

4 lines changed: 2 ins; 0 del; 2 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkActivateRef/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkAnnotations/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkImplClassLoader/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkRegisterInLog/security.policy

3 lines changed: 1 ins; 0 del; 2 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/createPrivateActivable/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/downloadParameterClass/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/elucidateNoSuchMethod/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/extLoadedImpl/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 27 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/forceLogSnapshot/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/inactiveGroup/security.policy

3 lines changed: 1 ins; 0 del; 2 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/lookupActivationSystem/LookupActivationSystem.java

2 lines changed: 0 ins; 0 del; 2 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nestedActivate/security.policy

3 lines changed: 1 ins; 0 del; 2 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nonExistentActivatable/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartCrashedService/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartLatecomer/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartService/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/shutdownGracefully/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/unregisterInactive/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivateFailedException/activateFails/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/activeGroup/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/modifyDescriptor/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java

5 lines changed: 0 ins; 0 del; 5 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/stubClassesPermitted/security.policy

8 lines changed: 7 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java

5 lines changed: 1 ins; 0 del; 4 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/unregisterGroup/security.policy

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/CommandEnvironment/SetChildEnv.java

28 lines changed: 19 ins; 0 del; 9 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/CommandEnvironment/security.policy

1 line changed: 1 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java

13 lines changed: 3 ins; 3 del; 7 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java

15 lines changed: 5 ins; 2 del; 8 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/rmidViaInheritedChannel/rmid.security.policy

1 line changed: 1 ins; 0 del; 0 mod; 5 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/altSecurityManager/AltSecurityManager.java

32 lines changed: 19 ins; 0 del; 13 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java

6 lines changed: 1 ins; 0 del; 5 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/emptyName/EmptyName.java

4 lines changed: 2 ins; 0 del; 2 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/interfaceHash/InterfaceHash.java

4 lines changed: 2 ins; 0 del; 2 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/multipleRegistries/MultipleRegistries.java

9 lines changed: 3 ins; 0 del; 6 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/readTest/readTest.java

6 lines changed: 2 ins; 1 del; 3 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/readTest/readTest.sh

8 lines changed: 4 ins; 0 del; 4 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/reexport/Reexport.java

14 lines changed: 1 ins; 2 del; 11 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/reliability/juicer/AppleUserImpl.java

16 lines changed: 8 ins; 2 del; 6 mod; 370 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/reliability/juicer/ApplicationServer.java

21 lines changed: 15 ins; 0 del; 6 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/EchoImpl.java

4 lines changed: 1 ins; 0 del; 3 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java

12 lines changed: 6 ins; 2 del; 4 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/HelloImpl.java

3 lines changed: 1 ins; 0 del; 2 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java

10 lines changed: 6 ins; 0 del; 4 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/EchoImpl.java

3 lines changed: 1 ins; 0 del; 2 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java

10 lines changed: 5 ins; 0 del; 5 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/security.policy

9 lines changed: 9 ins; 0 del; 0 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/RemoteServer/AddrInUse.java

7 lines changed: 2 ins; 0 del; 5 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java

6 lines changed: 2 ins; 0 del; 4 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/ShutdownImpl.java

3 lines changed: 1 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java

9 lines changed: 3 ins; 3 del; 3 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java

5 lines changed: 1 ins; 0 del; 4 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java

5 lines changed: 2 ins; 0 del; 3 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/Unreferenced/leaseCheckInterval/SelfTerminator.java

4 lines changed: 2 ins; 0 del; 2 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java

5 lines changed: 2 ins; 0 del; 3 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/useCustomRef/UseCustomRef.java

6 lines changed: 3 ins; 1 del; 2 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/server/useCustomRef/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 27 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/ActivationLibrary.java

33 lines changed: 0 ins; 27 del; 6 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/RMID.java

21 lines changed: 10 ins; 7 del; 4 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/RegistryRunner.java

5 lines changed: 1 ins; 0 del; 4 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/StreamPipe.java

4 lines changed: 2 ins; 0 del; 2 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/TestLibrary.java

131 lines changed: 116 ins; 4 del; 11 mod; 380 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/checkFQDN/CheckFQDN.java

8 lines changed: 3 ins; 0 del; 5 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/checkFQDN/CheckFQDNClient.java

3 lines changed: 1 ins; 0 del; 2 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java

9 lines changed: 4 ins; 1 del; 4 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/checkLeaseInfoLeak/LeaseLeakClient.java

4 lines changed: 1 ins; 1 del; 2 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/checkLeaseInfoLeak/security.policy

1 line changed: 1 ins; 0 del; 0 mod; 27 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/closeServerSocket/CloseServerSocket.java

6 lines changed: 1 ins; 1 del; 4 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java

8 lines changed: 3 ins; 0 del; 5 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/dgcDeadLock/TestImpl.java

6 lines changed: 1 ins; 1 del; 4 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/handshakeFailure/HandshakeFailure.java

4 lines changed: 1 ins; 0 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java

4 lines changed: 1 ins; 0 del; 3 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/httpSocket/HttpSocketTest.java

11 lines changed: 1 ins; 5 del; 5 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/httpSocket/security.policy

4 lines changed: 4 ins; 0 del; 0 mod; 9 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/pinClientSocketFactory/PinClientSocketFactory.java

4 lines changed: 2 ins; 0 del; 2 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java

6 lines changed: 1 ins; 2 del; 3 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java

4 lines changed: 1 ins; 0 del; 3 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/rmi/rmic/newrmic/equivalence/AppleUserImpl.java

10 lines changed: 2 ins; 1 del; 7 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/rmi/rmic/newrmic/equivalence/run.sh

3 lines changed: 2 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java

5 lines changed: 1 ins; 1 del; 3 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java

7 lines changed: 3 ins; 0 del; 4 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/rmi/transport/proxy/EagerHttpFallback.java

5 lines changed: 2 ins; 0 del; 3 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/rmi/transport/tcp/DeadCachedConnection.java

2 lines changed: 0 ins; 0 del; 2 mod; 129 unchg

This code review page was prepared using /home/dmocek/bin/webrev.ksh (vers 23.18-hg).