Code Review for hotspot

Prepared by:Doug Simon on Thu May 12 09:40:54 CEST 2016
Workspace:/Users/dsimon/hs-comp/hotspot
Summary of changes: 395 lines changed: 24 ins; 273 del; 98 mod; 10361 unchg
Patch of changes: hotspot.patch
Bug id: JDK-8156759] [JVMCI : remove JVMCIError and UnsafeUtil classes
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .mx.jvmci/suite.py

13 lines changed: 0 ins; 12 del; 1 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotRegisterConfig.java

3 lines changed: 0 ins; 1 del; 2 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotRegisterConfig.java

3 lines changed: 0 ins; 1 del; 2 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/jdk/vm/ci/hotspot/sparc/SPARCHotSpotRegisterConfig.java

4 lines changed: 0 ins; 1 del; 3 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java

4 lines changed: 1 ins; 2 del; 1 mod; 605 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java

4 lines changed: 0 ins; 1 del; 3 mod; 710 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantReflectionProvider.java

2 lines changed: 0 ins; 1 del; 1 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCICompilerConfig.java

3 lines changed: 0 ins; 1 del; 2 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java

5 lines changed: 1 ins; 2 del; 2 mod; 505 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntimeProvider.java

4 lines changed: 0 ins; 1 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java

8 lines changed: 0 ins; 1 del; 7 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodHandleAccessProvider.java

2 lines changed: 0 ins; 0 del; 2 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaFieldImpl.java

2 lines changed: 0 ins; 1 del; 1 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java

2 lines changed: 0 ins; 1 del; 1 mod; 734 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java

4 lines changed: 0 ins; 1 del; 3 mod; 890 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedPrimitiveType.java

3 lines changed: 0 ins; 1 del; 2 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotSignature.java

2 lines changed: 0 ins; 1 del; 1 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfig.java

42 lines changed: 22 ins; 3 del; 17 mod; 1752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfigVerifier.java

5 lines changed: 0 ins; 1 del; 4 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/jvmciRuntime.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/vmSymbols_jvmci.hpp

1 line changed: 0 ins; 1 del; 0 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/errors/TestInvalidCompilationResult.java

15 lines changed: 0 ins; 2 del; 13 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/errors/TestInvalidDebugInfo.java

20 lines changed: 0 ins; 2 del; 18 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/errors/TestInvalidOopMap.java

7 lines changed: 0 ins; 2 del; 5 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/InterpreterFrameSizeTest.java

1 line changed: 0 ins; 1 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java

4 lines changed: 0 ins; 2 del; 2 mod; 955 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/JVMCIError.java

149 lines changed: 0 ins; 149 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/UnsafeUtil.java

81 lines changed: 0 ins; 81 del; 0 mod; 0 unchg

This code review page was prepared using /Users/dsimon/Dropbox/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).