Code Review for hotspot

Prepared by:Doug Simon on Wed May 18 23:02:31 CEST 2016
Workspace:/Users/dsimon/hs-comp/hotspot
Summary of changes: 1881 lines changed: 383 ins; 1348 del; 150 mod; 19841 unchg
Patch of changes: hotspot.patch
Bug id: JDK-8156835] [JVMCI : clean up and minimize JVMCI
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .mx.jvmci/mx_jvmci.py

114 lines changed: 3 ins; 110 del; 1 mod; 806 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .mx.jvmci/suite.py

64 lines changed: 3 ins; 43 del; 18 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64Kind.java

23 lines changed: 0 ins; 22 del; 1 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/BytecodeFrame.java

5 lines changed: 5 ins; 0 del; 0 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/CompilationRequestResult.java

44 lines changed: 3 ins; 37 del; 4 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/CompiledCode.java

3 lines changed: 2 ins; 0 del; 1 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/ReferenceMap.java

5 lines changed: 5 ins; 0 del; 0 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/Register.java

41 lines changed: 0 ins; 40 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/RegisterConfig.java

10 lines changed: 1 ins; 8 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/ValueUtil.java

72 lines changed: 0 ins; 72 del; 0 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/site/ConstantReference.java

4 lines changed: 4 ins; 0 del; 0 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/site/DataPatch.java

2 lines changed: 0 ins; 0 del; 2 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/site/DataSectionReference.java

4 lines changed: 4 ins; 0 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/site/InfopointReason.java

1 line changed: 0 ins; 1 del; 0 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/site/Mark.java

14 lines changed: 10 ins; 0 del; 4 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/stack/InspectedFrame.java

6 lines changed: 3 ins; 0 del; 3 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/JVMCIError.java

31 lines changed: 0 ins; 31 del; 0 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotJVMCIBackendFactory.java

3 lines changed: 1 ins; 1 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotRegisterConfig.java

5 lines changed: 0 ins; 5 del; 0 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotJVMCIBackendFactory.java

3 lines changed: 1 ins; 1 del; 1 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotRegisterConfig.java

5 lines changed: 0 ins; 5 del; 0 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/jdk/vm/ci/hotspot/sparc/SPARCHotSpotJVMCIBackendFactory.java

3 lines changed: 1 ins; 1 del; 1 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/jdk/vm/ci/hotspot/sparc/SPARCHotSpotRegisterConfig.java

5 lines changed: 0 ins; 5 del; 0 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java

23 lines changed: 17 ins; 3 del; 3 mod; 583 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCompiledNmethod.java

1 line changed: 0 ins; 1 del; 0 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java

1 line changed: 0 ins; 0 del; 1 mod; 713 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantReflectionProvider.java

1 line changed: 0 ins; 0 del; 1 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotInstalledCode.java

3 lines changed: 1 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCICompilerConfig.java

2 lines changed: 0 ins; 1 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIMetaAccessContext.java

7 lines changed: 4 ins; 1 del; 2 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java

42 lines changed: 16 ins; 20 del; 6 mod; 481 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntimeProvider.java

7 lines changed: 1 ins; 6 del; 0 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMemoryAccessProviderImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java

2 lines changed: 0 ins; 1 del; 1 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaData.java

3 lines changed: 1 ins; 0 del; 2 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaspaceConstantImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethod.java

1 line changed: 0 ins; 0 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodHandleAccessProvider.java

1 line changed: 0 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotObjectConstantImpl.java

2 lines changed: 0 ins; 1 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotProfilingInfo.java

5 lines changed: 0 ins; 4 del; 1 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotReferenceMap.java

1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaFieldImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java

7 lines changed: 0 ins; 3 del; 4 mod; 729 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectType.java

2 lines changed: 0 ins; 2 del; 0 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java

8 lines changed: 0 ins; 5 del; 3 mod; 909 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedPrimitiveType.java

7 lines changed: 0 ins; 5 del; 2 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfig.java

26 lines changed: 22 ins; 4 del; 0 mod; 1768 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/services/HotSpotVMEventListener.java

17 lines changed: 0 ins; 16 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/JavaConstant.java

102 lines changed: 0 ins; 102 del; 0 mod; 360 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/JavaKind.java

29 lines changed: 12 ins; 0 del; 17 mod; 441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/JavaType.java

9 lines changed: 9 ins; 0 del; 0 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LineNumberTable.java

23 lines changed: 19 ins; 0 del; 4 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/Local.java

49 lines changed: 43 ins; 0 del; 6 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LocalVariableTable.java

35 lines changed: 31 ins; 0 del; 4 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MemoryAccessProvider.java

5 lines changed: 2 ins; 0 del; 3 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java

157 lines changed: 10 ins; 146 del; 1 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/PlatformKind.java

1 line changed: 0 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/ResolvedJavaType.java

15 lines changed: 0 ins; 15 del; 0 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/VMConstant.java

3 lines changed: 3 ins; 0 del; 0 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/jvmciCodeInstaller.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/jvmciCompiler.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/jvmciCompilerToVM.cpp

3 lines changed: 0 ins; 2 del; 1 mod; 1481 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/jvmciJavaClasses.hpp

9 lines changed: 0 ins; 5 del; 4 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/jvmciRuntime.cpp

17 lines changed: 0 ins; 0 del; 17 mod; 871 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/systemDictionary_jvmci.hpp

3 lines changed: 1 ins; 2 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jvmci/vmSymbols_jvmci.hpp

4 lines changed: 1 ins; 2 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/common/JVMCIHelpers.java

7 lines changed: 6 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/BoxPrimitiveDataProvider.java

6 lines changed: 0 ins; 0 del; 6 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/UnboxPrimitiveDataProvider.java

2 lines changed: 0 ins; 0 del; 2 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ConstantTest.java

31 lines changed: 2 ins; 29 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java

28 lines changed: 0 ins; 28 del; 0 mod; 934 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TypeUniverse.java

2 lines changed: 0 ins; 2 del; 0 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/InitTimer.java (was src/jdk.vm.ci/share/classes/jdk.vm.ci.inittimer/src/jdk/vm/ci/inittimer/InitTimer.java)

1 line changed: 0 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/SuppressFBWarnings.java (was src/jdk.vm.ci/share/classes/jdk.vm.ci.inittimer/src/jdk/vm/ci/inittimer/SuppressFBWarnings.java)

2 lines changed: 0 ins; 0 del; 2 mod; 38 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCompilationRequestResult.java

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/SuppressFBWarnings.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/SourceStackTrace.java

50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/UnsafeUtil.java

81 lines changed: 0 ins; 81 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotOopMap.java

43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotProxified.java

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/JVMCIMetaAccessContext.java

38 lines changed: 0 ins; 38 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LineNumberTableImpl.java

54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LocalImpl.java

84 lines changed: 0 ins; 84 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LocalVariableTableImpl.java

67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/compiler/jvmci/events/JvmciCreateMetaAccessContextTest.java

113 lines changed: 0 ins; 113 del; 0 mod; 0 unchg

This code review page was prepared using /Users/dsimon/Dropbox/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).