Code Review for hotspot

Prepared by:Doug Simon on Fri Apr 21 12:15:41 CEST 2017
Workspace:/Users/dsimon/hs/hotspot
Compare against: http://hg.openjdk.java.net/jdk9/dev/hotspot
Summary of changes: 595 lines changed: 354 ins; 153 del; 88 mod; 13446 unchg
Patch of changes: hotspot.patch
Bug id: JDK-8177845 : Need a mechanism to load Graal
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .mx.jvmci/.pydevproject

1 line changed: 0 ins; 0 del; 1 mod; 11 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCICompilerConfig.java

18 lines changed: 8 ins; 4 del; 6 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java

7 lines changed: 4 ins; 1 del; 2 mod; 551 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMemoryAccessProviderImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java

2 lines changed: 0 ins; 1 del; 1 mod; 928 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/JVMCIServiceLocator.java

20 lines changed: 10 ins; 0 del; 10 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java

144 lines changed: 5 ins; 127 del; 12 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/module-info.java

1 line changed: 0 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/.mx.graal/.pydevproject

3 lines changed: 0 ins; 0 del; 3 mod; 8 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.test/src/org/graalvm/compiler/api/test/Graal.java

1 line changed: 0 ins; 0 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompileTheWorld.java

1 line changed: 0 ins; 1 del; 0 mod; 791 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalCompilerFactory.java

19 lines changed: 2 ins; 12 del; 5 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalServices.java

58 lines changed: 44 ins; 6 del; 8 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/JVM_GetJVMCIRuntimeTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/TestJVMCIPrintProperties.java

2 lines changed: 0 ins; 0 del; 2 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/AsResolvedJavaMethodTest.java

1 line changed: 0 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/DoNotInlineOrCompileTest.java

1 line changed: 1 ins; 0 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/FindUniqueConcreteMethodTest.java

1 line changed: 1 ins; 0 del; 0 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetBytecodeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetClassInitializerTest.java

1 line changed: 1 ins; 0 del; 0 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetConstantPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetExceptionTableTest.java

2 lines changed: 1 ins; 1 del; 0 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetImplementorTest.java

1 line changed: 1 ins; 0 del; 0 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetLineNumberTableTest.java

1 line changed: 1 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetLocalVariableTableTest.java

1 line changed: 1 ins; 0 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetNextStackFrameTest.java

1 line changed: 1 ins; 0 del; 0 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetResolvedJavaMethodTest.java

1 line changed: 1 ins; 0 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetResolvedJavaTypeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetStackTraceElementTest.java

1 line changed: 1 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetSymbolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/GetVtableIndexForInterfaceTest.java

1 line changed: 1 ins; 0 del; 0 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/HasCompiledCodeForOSRTest.java

1 line changed: 0 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/HasFinalizableSubclassTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/HasNeverInlineDirectiveTest.java

1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/InvalidateInstalledCodeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/IsCompilableTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/IsMatureVsReprofileTest.java

1 line changed: 1 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/LookupKlassInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/LookupKlassRefIndexInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/LookupMethodInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/LookupNameAndTypeRefIndexInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/LookupNameInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/LookupSignatureInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/LookupTypeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java

4 lines changed: 4 ins; 0 del; 0 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/MethodIsIgnoredBySecurityStackWalkTest.java

1 line changed: 1 ins; 0 del; 0 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ReadConfigurationTest.java

1 line changed: 1 ins; 0 del; 0 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ReprofileTest.java

1 line changed: 0 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ResolveConstantInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ResolveFieldInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ResolveMethodTest.java

1 line changed: 1 ins; 0 del; 0 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ResolvePossiblyCachedConstantInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ResolveTypeInPoolTest.java

1 line changed: 1 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/compilerToVM/ShouldInlineMethodTest.java

1 line changed: 1 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/errors/TestInvalidCompilationResult.java

2 lines changed: 1 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/errors/TestInvalidDebugInfo.java

2 lines changed: 1 ins; 0 del; 1 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/errors/TestInvalidOopMap.java

2 lines changed: 1 ins; 0 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/events/JvmciNotifyInstallEventTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/DataPatchTest.java

1 line changed: 0 ins; 0 del; 1 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/InterpreterFrameSizeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/MaxOopMapStackOffsetTest.java

1 line changed: 0 ins; 0 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleCodeInstallationTest.java

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java

1 line changed: 0 ins; 0 del; 1 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/VirtualObjectDebugInfoTest.java

1 line changed: 0 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/HotSpotConstantReflectionProviderTest.java

1 line changed: 0 ins; 0 del; 1 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/MemoryAccessProviderTest.java

1 line changed: 0 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/MethodHandleAccessProviderTest.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ConstantTest.java

1 line changed: 0 ins; 0 del; 1 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/RedefineClassTest.java

1 line changed: 0 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ResolvedJavaTypeResolveConcreteMethodTest.java

1 line changed: 0 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ResolvedJavaTypeResolveMethodTest.java

1 line changed: 0 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestConstantReflectionProvider.java

1 line changed: 0 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestJavaField.java

1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestJavaMethod.java

1 line changed: 0 ins; 0 del; 1 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestJavaType.java

1 line changed: 0 ins; 0 del; 1 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestMetaAccessProvider.java

1 line changed: 0 ins; 0 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaField.java

1 line changed: 0 ins; 0 del; 1 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaMethod.java

1 line changed: 0 ins; 0 del; 1 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java

1 line changed: 0 ins; 0 del; 1 mod; 965 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/meta/StableFieldTest.java

1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/internal/ReflectionAccessJDK.java

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/JDK9Method.java

148 lines changed: 148 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/dsimon/Dropbox/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).