src/share/vm/compiler/disassembler.cpp

rev 6626 : 8054292: code comments leak in fastdebug builds
Summary: Added deallocation to destructor; hardened interface against misuse
Reviewed-by: kvn

*** 243,258 ****
    void set_total_ticks(int n) { _total_ticks = n; }
    const char* options() { return _option_buf; }
  };
  
  decode_env::decode_env(CodeBlob* code, outputStream* output, CodeStrings c) {
!   memset(this, 0, sizeof(*this));
    _output = output ? output : tty;
    _code = code;
    if (code != NULL && code->is_nmethod())
      _nm = (nmethod*) code;
!   _strings.assign(c);
  
    // by default, output pc but not bytes:
    _print_pc       = true;
    _print_bytes    = false;
    _bytes_per_line = Disassembler::pd_instruction_alignment();
--- 243,258 ----
    void set_total_ticks(int n) { _total_ticks = n; }
    const char* options() { return _option_buf; }
  };
  
  decode_env::decode_env(CodeBlob* code, outputStream* output, CodeStrings c) {
!   memset(this, 0, sizeof(*this)); // Beware, this zeroes bits of fields.
    _output = output ? output : tty;
    _code = code;
    if (code != NULL && code->is_nmethod())
      _nm = (nmethod*) code;
!   _strings.copy(c);
  
    // by default, output pc but not bytes:
    _print_pc       = true;
    _print_bytes    = false;
    _bytes_per_line = Disassembler::pd_instruction_alignment();