Code Review for open

Prepared by: java g11n sqe (g11n) on Tue Oct 16 01:13:32 PDT 2018
Workspace:/scratch/Dora/jdk/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 1063 lines changed: 274 ins; 674 del; 115 mod; 3461 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/BreakIteratorProviderTest.java

30 lines changed: 19 ins; 5 del; 6 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/CalendarDataProviderTest.java

17 lines changed: 8 ins; 3 del; 6 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/CalendarNameProviderTest.java

27 lines changed: 20 ins; 0 del; 7 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/ClasspathTest.java

13 lines changed: 8 ins; 0 del; 5 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/CollatorProviderTest.java

29 lines changed: 22 ins; 0 del; 7 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/CurrencyNameProviderTest.java

30 lines changed: 22 ins; 0 del; 8 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/DateFormatProviderTest.java

30 lines changed: 23 ins; 0 del; 7 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java

26 lines changed: 19 ins; 0 del; 7 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/DecimalFormatSymbolsProviderTest.java

22 lines changed: 15 ins; 0 del; 7 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/GenericTest.java

46 lines changed: 28 ins; 0 del; 18 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/LocaleNameProviderTest.java

24 lines changed: 16 ins; 0 del; 8 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/NumberFormatProviderTest.java

25 lines changed: 18 ins; 0 del; 7 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/PermissionTest.java

49 lines changed: 34 ins; 0 del; 15 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/PluggableLocale/TimeZoneNameProviderTest.java

29 lines changed: 22 ins; 0 del; 7 mod; 244 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/dummy.policy

0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/META-INF/services/java.util.spi.CalendarDataProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.util.spi.CalendarDataProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/META-INF/services/java.util.spi.CalendarNameProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.util.spi.CalendarNameProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/META-INF/services/java.util.spi.CurrencyNameProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.util.spi.CurrencyNameProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 8 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/META-INF/services/java.util.spi.LocaleNameProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.util.spi.LocaleNameProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/META-INF/services/java.util.spi.TimeZoneNameProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.util.spi.TimeZoneNameProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 8 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/CalendarDataProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/CalendarDataProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 54 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/CalendarNameProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/CalendarNameProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 102 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/CurrencyNameProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/CurrencyNameProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 82 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/CurrencyNameProviderImpl2.java (was test/jdk/java/util/PluggableLocale/providersrc/CurrencyNameProviderImpl2.java)

0 lines changed: 0 ins; 0 del; 0 mod; 72 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/GenericTimeZoneNameProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/GenericTimeZoneNameProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 58 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/LocaleNameProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/LocaleNameProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 100 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/LocaleNames.properties (was test/jdk/java/util/PluggableLocale/providersrc/LocaleNames.properties)

0 lines changed: 0 ins; 0 del; 0 mod; 25 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/LocaleNames_ja.properties (was test/jdk/java/util/PluggableLocale/providersrc/LocaleNames_ja.properties)

0 lines changed: 0 ins; 0 del; 0 mod; 30 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/LocaleNames_ja_JP_kyoto.properties (was test/jdk/java/util/PluggableLocale/providersrc/LocaleNames_ja_JP_kyoto.properties)

0 lines changed: 0 ins; 0 del; 0 mod; 28 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/LocaleNames_ja_JP_osaka.properties (was test/jdk/java/util/PluggableLocale/providersrc/LocaleNames_ja_JP_osaka.properties)

0 lines changed: 0 ins; 0 del; 0 mod; 28 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/LocaleNames_xx.properties (was test/jdk/java/util/PluggableLocale/providersrc/LocaleNames_xx.properties)

0 lines changed: 0 ins; 0 del; 0 mod; 23 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/barprovider/com/bar/TimeZoneNameProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/TimeZoneNameProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 150 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/foobarutils/com/foobar/Utils.java (was test/jdk/java/util/PluggableLocale/providersrc/Utils.java)

0 lines changed: 0 ins; 0 del; 0 mod; 68 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/META-INF/services/java.text.spi.BreakIteratorProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.text.spi.BreakIteratorProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/META-INF/services/java.text.spi.CollatorProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.text.spi.CollatorProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/META-INF/services/java.text.spi.DateFormatProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.text.spi.DateFormatProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/META-INF/services/java.text.spi.DateFormatSymbolsProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.text.spi.DateFormatSymbolsProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/META-INF/services/java.text.spi.DecimalFormatSymbolsProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.text.spi.DecimalFormatSymbolsProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/META-INF/services/java.text.spi.NumberFormatProvider (was test/jdk/java/util/PluggableLocale/providersrc/java.text.spi.NumberFormatProvider)

0 lines changed: 0 ins; 0 del; 0 mod; 7 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/BreakIteratorProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/BreakIteratorProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 140 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/CollatorProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/CollatorProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 68 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/DateFormatProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/DateFormatProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 95 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/DateFormatSymbolsProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/DateFormatSymbolsProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 230 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/DecimalFormatSymbolsProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/DecimalFormatSymbolsProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 110 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/FooDateFormat.java (was test/jdk/java/util/PluggableLocale/providersrc/FooDateFormat.java)

0 lines changed: 0 ins; 0 del; 0 mod; 61 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/FooNumberFormat.java (was test/jdk/java/util/PluggableLocale/providersrc/FooNumberFormat.java)

0 lines changed: 0 ins; 0 del; 0 mod; 81 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/util/PluggableLocale/providersrc/fooprovider/com/foo/NumberFormatProviderImpl.java (was test/jdk/java/util/PluggableLocale/providersrc/NumberFormatProviderImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 156 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/BreakIteratorProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/CalendarDataProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/CalendarNameProviderTest.sh

27 lines changed: 0 ins; 27 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/ClasspathTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/CollatorProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/CurrencyNameProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/DateFormatProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/DateFormatSymbolsProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/DecimalFormatSymbolsProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/ExecTest.sh

145 lines changed: 0 ins; 145 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/GenericTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/LocaleNameProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/NumberFormatProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/PermissionTest.sh

31 lines changed: 0 ins; 31 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/TimeZoneNameProviderTest.sh

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/jdk/java/util/PluggableLocale/barprovider.jar

24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/jdk/java/util/PluggableLocale/fooprovider.jar

25 lines changed: 0 ins; 25 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/util/PluggableLocale/providersrc/Makefile

78 lines changed: 0 ins; 78 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev.ksh (vers 25.16-hg+openjdk.java.net).