Code Review for jmc

Prepared by:ebaron ebaron on Thu May 23 17:07:14 EDT 2019
Workspace:/home/ebaron/hg/jmc
Compare against version:qparent
Summary of changes: 1012 lines changed: 999 ins; 3 del; 10 mod; 5895 unchg
Patch of changes: jmc.patch
Bug id: JMC-5327 : Using HdrHistograms to visualize latencies
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

4 lines changed: 4 ins; 0 del; 0 mod; 591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_zh_CN.properties

4 lines changed: 4 ins; 0 del; 0 mod; 591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF

2 lines changed: 1 ins; 0 del; 1 mod; 22 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/defaultPages.xml

14 lines changed: 14 ins; 0 del; 0 mod; 823 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ItemHistogram.java

1 line changed: 0 ins; 0 del; 1 mod; 309 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java

3 lines changed: 3 ins; 0 del; 0 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/FileIOPage.java

39 lines changed: 36 ins; 1 del; 2 mod; 452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/SocketIOPage.java

42 lines changed: 38 ins; 1 del; 3 mod; 621 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties

4 lines changed: 4 ins; 0 del; 0 mod; 600 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/column/ColumnManager.java

1 line changed: 0 ins; 0 del; 1 mod; 602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw application/uitests/org.openjdk.jmc.flightrecorder.uitest/META-INF/MANIFEST.MF

6 lines changed: 3 ins; 1 del; 2 mod; 21 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target

1 line changed: 1 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target

1 line changed: 1 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target

1 line changed: 1 ins; 0 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw releng/platform-definitions/platform-definition-photon/platform-definition-photon.target

1 line changed: 1 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw releng/third-party/pom.xml

3 lines changed: 3 ins; 0 del; 0 mod; 405 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationHdrHistogram.java

153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DurationPercentileTable.java

481 lines changed: 481 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/FileIOPageTest.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/IOPageTestBase.java

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/resources/jfr/io_test.jfr

Unexpected Error occurred reading `diff -e /dev/null new/application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/resources/jfr/io_test.jfr`: $?=0, err= 1

This code review page was prepared using /home/ebaron/hg/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).