Code Review for graal

Prepared by:Eric Caspole on Tue Dec 10 13:24:47 EST 2013
Workspace:/home/ecaspole/views/graal-exception-demo/graal
Compare against: http://ausb3merapv02:8080/scm/hg/graal/graal
Compare against version:default
Branch:deoptimize-codegen-default
Summary of changes: 554 lines changed: 527 ins; 6 del; 21 mod; 13684 unchg
Patch of changes: graal.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.asm.hsail/src/com/oracle/graal/asm/hsail/HSAILAssembler.java

rev 14067 : Apply Dougs comments
27 lines changed: 19 ins; 4 del; 4 mod; 499 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.compiler.hsail.test.infra/src/com/oracle/graal/compiler/hsail/test/infra/KernelTester.java

rev 14065 : apply Tom's comments
6 lines changed: 4 ins; 0 del; 2 mod; 911 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILCompilationResult.java

rev 14067 : Apply Dougs comments
8 lines changed: 7 ins; 0 del; 1 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotBackend.java

rev 14064 : webrev candidate for hsail exceptions
11 lines changed: 10 ins; 0 del; 1 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotLIRGenerator.java

rev 14067 : Apply Dougs comments
54 lines changed: 53 ins; 0 del; 1 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotLoweringProvider.java

rev 14067 : Apply Dougs comments
55 lines changed: 52 ins; 0 del; 3 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.lir.hsail/src/com/oracle/graal/lir/hsail/HSAILControlFlow.java

rev 14067 : Apply Dougs comments
77 lines changed: 77 ins; 0 del; 0 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/gpu/hsail/vm/gpu_hsail.cpp

rev 14067 : Apply Dougs comments
44 lines changed: 40 ins; 2 del; 2 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/gpu/hsail/vm/gpu_hsail.hpp

rev 14067 : Apply Dougs comments
3 lines changed: 2 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/gpu/hsail/vm/hsailKernelArguments.hpp

rev 13979 : merge with fakegpuexception and beging to implement throwing
8 lines changed: 6 ins; 0 del; 2 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.cpp

rev 13975 : save my fake gpu exception stuff
10 lines changed: 10 ins; 0 del; 0 mod; 3527 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/graal/graalCompilerToGPU.cpp

rev 14064 : webrev candidate for hsail exceptions
2 lines changed: 1 ins; 0 del; 1 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/gpu.cpp

rev 14064 : webrev candidate for hsail exceptions
3 lines changed: 1 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/gpu.hpp

rev 14064 : webrev candidate for hsail exceptions
2 lines changed: 1 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.cpp

rev 13975 : save my fake gpu exception stuff
2 lines changed: 2 ins; 0 del; 0 mod; 4746 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.hpp

rev 13975 : save my fake gpu exception stuff
11 lines changed: 11 ins; 0 del; 0 mod; 2052 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/BoundsCheckTest.java

rev 14066 : eclipseformat on test files
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/ClassCastTest.java

rev 14067 : Apply Dougs comments
97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/replacements/HSAILUnwindNode.java

rev 14064 : webrev candidate for hsail exceptions
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ecaspole/bin/webrev.ksh (vers 23.18-hg).