Code Review for hotspot

Prepared by:ehelin on Tue Sep 17 13:21:59 CEST 2013
Workspace:/home/ehelin/code/oracle/local/hsx/hotspot-gc/metaspace-pools-and-counters/hotspot
Compare against: ssh://hg.openjdk.java.net/hsx/hotspot-gc-gate/hotspot
Compare against version:5248
Summary of changes: 269 lines changed: 155 ins; 68 del; 46 mod; 979 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metaspaceCounters.cpp 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
42 lines changed: 8 ins; 14 del; 20 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/metaspaceCounters.hpp 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
7 lines changed: 3 ins; 0 del; 4 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/memoryPool.cpp 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
14 lines changed: 1 ins; 8 del; 5 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/memoryPool.hpp 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
2 lines changed: 0 ins; 2 del; 0 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/memoryUsage.hpp 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
3 lines changed: 2 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/gc/metaspace/TestMetaspaceMemoryPool.java 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
61 lines changed: 9 ins; 42 del; 10 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/gc/metaspace/TestMetaspacePerfCounters.java 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
29 lines changed: 21 ins; 2 del; 6 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/testlibrary/com/oracle/java/testlibrary/InputArguments.java 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
25 lines changed: 25 ins; 0 del; 0 mod; 51 unchg

------ ------ ------ ------ --- New Patch Raw test/gc/metaspace/TestPerfCountersAndMemoryPools.java 

rev 5249 : 8024718: Metaspace performance counters and memory pools should report the same data
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ehelin/code/oracle/webrev.ksh (vers 23.18-hg).