Code Review for jdk9-sandbox-sa2buildinfra

Prepared by:erikj on Mon Nov 9 19:29:03 CET 2015
Workspace:/localhome/hg/jdk9-sandbox-sa2buildinfra
Compare against version:default
Summary of changes: 1928 lines changed: 229 ins; 1655 del; 44 mod; 11196 unchg
Patch of changes: jdk9-sandbox-sa2buildinfra.patch
Bug id: JDK-8142336 : Convert the SA agent build to modular build-infra makefiles
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

28 lines changed: 23 ins; 5 del; 0 mod; 582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Images.gmk

3 lines changed: 1 ins; 0 del; 2 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Main.gmk

5 lines changed: 0 ins; 5 del; 0 mod; 648 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/Modules.gmk

12 lines changed: 11 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/NativeCompilation.gmk

6 lines changed: 4 ins; 0 del; 2 mod; 771 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/agent/src/os/solaris/proc/saproc.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/aix/Makefile

9 lines changed: 0 ins; 9 del; 0 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/aix/makefiles/buildtree.make

13 lines changed: 0 ins; 12 del; 1 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/aix/makefiles/top.make

7 lines changed: 0 ins; 5 del; 2 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/aix/makefiles/vm.make

6 lines changed: 0 ins; 3 del; 3 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/bsd/Makefile

9 lines changed: 0 ins; 9 del; 0 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/bsd/makefiles/buildtree.make

13 lines changed: 0 ins; 12 del; 1 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/bsd/makefiles/defs.make

44 lines changed: 0 ins; 44 del; 0 mod; 370 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/bsd/makefiles/top.make

7 lines changed: 0 ins; 5 del; 2 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/bsd/makefiles/vm.make

7 lines changed: 0 ins; 3 del; 4 mod; 414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/Makefile

9 lines changed: 0 ins; 9 del; 0 mod; 393 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/buildtree.make

13 lines changed: 0 ins; 12 del; 1 mod; 372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/defs.make

20 lines changed: 0 ins; 20 del; 0 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/top.make

7 lines changed: 0 ins; 5 del; 2 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/linux/makefiles/vm.make

6 lines changed: 0 ins; 3 del; 3 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/solaris/Makefile

9 lines changed: 0 ins; 9 del; 0 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/solaris/makefiles/buildtree.make

13 lines changed: 0 ins; 12 del; 1 mod; 358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/solaris/makefiles/defs.make

10 lines changed: 0 ins; 10 del; 0 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/solaris/makefiles/top.make

7 lines changed: 0 ins; 5 del; 2 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/solaris/makefiles/vm.make

6 lines changed: 0 ins; 3 del; 3 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/windows/build.make

37 lines changed: 0 ins; 36 del; 1 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/windows/makefiles/debug.make

4 lines changed: 0 ins; 2 del; 2 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/windows/makefiles/defs.make

15 lines changed: 0 ins; 15 del; 0 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/windows/makefiles/fastdebug.make

4 lines changed: 0 ins; 2 del; 2 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/windows/makefiles/generated.make

4 lines changed: 0 ins; 3 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw hotspot/make/windows/makefiles/product.make

3 lines changed: 0 ins; 1 del; 2 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/Import.gmk

61 lines changed: 0 ins; 59 del; 2 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/gensrc/Gensrc-jdk.jdi.gmk

3 lines changed: 0 ins; 0 del; 3 mod; 103 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/make/gensrc/Gensrc-jdk.hotspot.agent.gmk

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw hotspot/make/lib/Lib-jdk.hotspot.agent.gmk

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/aix/makefiles/sa.make

112 lines changed: 0 ins; 112 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/aix/makefiles/saproc.make

117 lines changed: 0 ins; 117 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/bsd/makefiles/sa.make

138 lines changed: 0 ins; 138 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/bsd/makefiles/saproc.make

175 lines changed: 0 ins; 175 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/linux/makefiles/sa.make

115 lines changed: 0 ins; 115 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/linux/makefiles/saproc.make

127 lines changed: 0 ins; 127 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/sa.files

133 lines changed: 0 ins; 133 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/solaris/makefiles/sa.make

104 lines changed: 0 ins; 104 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/solaris/makefiles/saproc.make

151 lines changed: 0 ins; 151 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- hotspot/make/windows/makefiles/sa.make

165 lines changed: 0 ins; 165 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev/webrev.ksh (vers 25.14-hg+openjdk.java.net).