Code Review for open

Prepared by:erikj on Mon Apr 1 14:22:39 PDT 2019
Workspace:/home/erik/hg/jdk-findfiles/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:54325
Summary of changes: 518 lines changed: 282 ins; 38 del; 198 mod; 7956 unchg
Changeset: open.changeset
Bug id: JDK-8189861 : Refactor CacheFind
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/Bundles.gmk 

rev 54326 : 8189861: Refactor CacheFind
10 lines changed: 2 ins; 1 del; 7 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/CompileDemos.gmk 

rev 54326 : 8189861: Refactor CacheFind
5 lines changed: 0 ins; 0 del; 5 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/CompileJavaModules.gmk 

rev 54326 : 8189861: Refactor CacheFind
1 line changed: 0 ins; 0 del; 1 mod; 683 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/CopyImportModules.gmk 

rev 54326 : 8189861: Refactor CacheFind
8 lines changed: 0 ins; 0 del; 8 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/CreateBuildJdkCopy.gmk 

rev 54326 : 8189861: Refactor CacheFind
3 lines changed: 0 ins; 0 del; 3 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/CreateJmods.gmk 

rev 54326 : 8189861: Refactor CacheFind
10 lines changed: 0 ins; 0 del; 10 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/Docs.gmk 

rev 54326 : 8189861: Refactor CacheFind
8 lines changed: 0 ins; 0 del; 8 mod; 631 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/Images.gmk 

rev 54326 : 8189861: Refactor CacheFind
17 lines changed: 2 ins; 9 del; 6 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/MacBundles.gmk 

rev 54326 : 8189861: Refactor CacheFind
3 lines changed: 0 ins; 0 del; 3 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/ZipSource.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 1 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/JarArchive.gmk 

rev 54326 : 8189861: Refactor CacheFind
4 lines changed: 0 ins; 0 del; 4 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/JavaCompilation.gmk 

rev 54326 : 8189861: Refactor CacheFind
8 lines changed: 0 ins; 1 del; 7 mod; 528 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/MakeBase.gmk 

rev 54326 : 8189861: Refactor CacheFind
135 lines changed: 70 ins; 26 del; 39 mod; 455 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/NativeCompilation.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 1070 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/TestFilesCompilation.gmk 

rev 54326 : 8189861: Refactor CacheFind
3 lines changed: 0 ins; 1 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/TextFileProcessing.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/Utils.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/ZipArchive.gmk 

rev 54326 : 8189861: Refactor CacheFind
11 lines changed: 7 ins; 0 del; 4 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/copy/CopyCommon.gmk 

rev 54326 : 8189861: Refactor CacheFind
3 lines changed: 0 ins; 0 del; 3 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/gensrc/Gensrc-jdk.internal.vm.compiler.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/gensrc/Gensrc-jdk.internal.vm.compiler.management.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/gensrc/GensrcCommonLangtools.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/gensrc/GensrcLocaleData.gmk 

rev 54326 : 8189861: Refactor CacheFind
10 lines changed: 0 ins; 0 del; 10 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/gensrc/GensrcProperties.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/hotspot/lib/CompileJvm.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/hotspot/lib/JvmOverrideFiles.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Lib-java.base.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Lib-java.desktop.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/make/TestCopyFiles.gmk 

rev 54326 : 8189861: Refactor CacheFind
2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/make/TestMakeBase.gmk 

rev 54326 : 8189861: Refactor CacheFind
242 lines changed: 195 ins; 0 del; 47 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/make/UtilsForTests.gmk 

rev 54326 : 8189861: Refactor CacheFind
11 lines changed: 5 ins; 0 del; 6 mod; 36 unchg

This code review page was prepared using /home/erik/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).