Code Review for open

Prepared by:erikj on Wed Jun 5 13:43:40 PDT 2019
Workspace:/home/erik/hg/jdk-cross-constants/open
Summary of changes: 217 lines changed: 37 ins; 127 del; 53 mod; 3103 unchg
Patch of changes: open.patch
Bug id: JDK-8217739 : Cannot reuse java.base UnixConstants.java from target in BuildJDK when cross compiling
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/ExplodedImageOptimize.gmk

1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Main.gmk

112 lines changed: 28 ins; 48 del; 36 mod; 1158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/autoconf/buildjdk-spec.gmk.in

6 lines changed: 6 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/MakeBase.gmk

5 lines changed: 1 ins; 0 del; 4 mod; 560 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/NativeCompilation.gmk

5 lines changed: 0 ins; 0 del; 5 mod; 1107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/gensrc/GensrcMisc.gmk

9 lines changed: 2 ins; 0 del; 7 mod; 129 unchg

------ ------ ------ ------ Old --- Patch --- make/CreateBuildJdkCopy.gmk

79 lines changed: 0 ins; 79 del; 0 mod; 0 unchg

This code review page was prepared using /home/erik/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).