Code Review for jdk9-dev-nsslibs

Prepared by:erikj on Mon May 23 18:47:10 CEST 2016
Workspace:/localhome/hg/jdk9-dev-nsslibs
Summary of changes: 498 lines changed: 492 ins; 0 del; 6 mod; 146491 unchg
Patch of changes: jdk9-dev-nsslibs.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/autoconf/generated-configure.sh

207 lines changed: 206 ins; 0 del; 1 mod; 67763 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/autoconf/libraries.m4

2 lines changed: 2 ins; 0 del; 0 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/autoconf/spec.gmk.in

1 line changed: 1 ins; 0 del; 0 mod; 848 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/conf/jib-profiles.js

10 lines changed: 7 ins; 0 del; 3 mod; 637 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw closed/autoconf/generated-configure.sh

207 lines changed: 206 ins; 0 del; 1 mod; 76947 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/test/JtregNative.gmk

14 lines changed: 13 ins; 0 del; 1 mod; 81 unchg

------ ------ ------ ------ --- New Patch Raw common/autoconf/lib-nss.m4

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libfreebl3.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libfreebl3.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnspr4.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnspr4.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnss3.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnss3.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnssckbi.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnssckbi.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnssdbm3.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnssdbm3.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnssutil3.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libnssutil3.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libplc4.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libplc4.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libplds4.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libplds4.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libsoftokn3.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libsoftokn3.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libsqlite3.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libsqlite3.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libssl3.dylib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/macosx-x86_64/libssl3.dylib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/freebl3.chk

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/freebl3.chk /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/freebl3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/freebl3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libnspr4.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplc4.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/libplds4.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nss3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nss3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nss3.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nss3.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssckbi.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssckbi.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssdbm3.chk

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssdbm3.chk /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssdbm3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssdbm3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssutil3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssutil3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssutil3.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/nssutil3.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/softokn3.chk

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/softokn3.chk /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/softokn3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/softokn3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/sqlite3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/sqlite3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/ssl3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/ssl3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/ssl3.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-amd64/ssl3.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/freebl3.chk

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/freebl3.chk /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/freebl3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/freebl3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nss3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nss3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nss3.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nss3.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssckbi.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssckbi.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssdbm3.chk

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssdbm3.chk /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssdbm3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssdbm3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssutil3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssutil3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssutil3.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/nssutil3.lib /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.chk

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.chk /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/sqlite3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/sqlite3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/ssl3.dll

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/ssl3.dll /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- jdk/test/sun/security/pkcs11/nss/lib/windows-i586/ssl3.lib

Unexpected Error occurred reading `diff -e old/jdk/test/sun/security/pkcs11/nss/lib/windows-i586/ssl3.lib /dev/null`: $?=0, err= 1

This code review page was prepared using ../webrev/webrev.ksh (vers 25.15-hg+openjdk.java.net).