Code Review for rt

Prepared by:jagraham on Fri Feb 21 17:02:59 PST 2014
Workspace:/Users/jagraham/Work/JavaFX/fx8u/jfx/rt
Summary of changes: 3448 lines changed: 1996 ins; 1191 del; 261 mod; 11965 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/LinearConvolveCoreEffect.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/RenderState.java

222 lines changed: 222 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/GaussianBlur.java

36 lines changed: 1 ins; 33 del; 2 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/GaussianShadow.java

36 lines changed: 2 ins; 33 del; 1 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/BoxBlur.java

48 lines changed: 1 ins; 36 del; 11 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/BoxShadow.java

47 lines changed: 1 ins; 38 del; 8 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/MotionBlur.java

38 lines changed: 1 ins; 35 del; 2 mod; 209 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/LinearConvolveRenderState.java

335 lines changed: 335 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/GaussianRenderState.java

538 lines changed: 538 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/BoxRenderState.java

579 lines changed: 579 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/jsl-decora/LinearConvolve.jsl

23 lines changed: 2 ins; 12 del; 9 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/jsl-decora/LinearConvolveShadow.jsl

22 lines changed: 0 ins; 12 del; 10 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/LinearConvolveKernel.java

352 lines changed: 0 ins; 351 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/GaussianBlurState.java

69 lines changed: 4 ins; 58 del; 7 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/BoxBlurState.java

154 lines changed: 6 ins; 133 del; 15 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/BoxShadowState.java

50 lines changed: 1 ins; 49 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/GaussianShadowState.java

60 lines changed: 0 ins; 59 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/HVSeparableKernel.java

55 lines changed: 0 ins; 55 del; 0 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/MotionBlurState.java

51 lines changed: 2 ins; 46 del; 3 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGGroup.java

1 line changed: 0 ins; 0 del; 1 mod; 456 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/AbstractShadow.java

1 line changed: 0 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/Blend.java

11 lines changed: 3 ins; 0 del; 8 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/Brightpass.java

10 lines changed: 3 ins; 3 del; 4 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/ColorAdjust.java

10 lines changed: 3 ins; 3 del; 4 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/CoreEffect.java

4 lines changed: 2 ins; 0 del; 2 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/Crop.java

12 lines changed: 6 ins; 0 del; 6 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/DisplacementMap.java

16 lines changed: 4 ins; 6 del; 6 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/FilterEffect.java

58 lines changed: 28 ins; 12 del; 18 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/Flood.java

10 lines changed: 5 ins; 0 del; 5 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/ImageData.java

12 lines changed: 12 ins; 0 del; 0 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/InvertMask.java

50 lines changed: 32 ins; 9 del; 9 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/Merge.java

13 lines changed: 5 ins; 3 del; 5 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/PerspectiveTransform.java

20 lines changed: 6 ins; 5 del; 9 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/PhongLighting.java

11 lines changed: 4 ins; 0 del; 7 mod; 322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/Reflection.java

15 lines changed: 3 ins; 5 del; 7 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/SepiaTone.java

10 lines changed: 3 ins; 3 del; 4 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/ZoomRadialBlur.java

12 lines changed: 2 ins; 3 del; 7 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/EffectPeer.java

15 lines changed: 14 ins; 0 del; 1 mod; 403 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/PrCropPeer.java

2 lines changed: 2 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/PrFloodPeer.java

2 lines changed: 2 ins; 0 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/PrMergePeer.java

2 lines changed: 2 ins; 0 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/PrReflectionPeer.java

2 lines changed: 2 ins; 0 del; 0 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/ps/PPSEffectPeer.java

4 lines changed: 3 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/ps/PPSOneSamplerPeer.java

2 lines changed: 1 ins; 0 del; 1 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/ps/PPStoPSWDisplacementMapPeer.java

7 lines changed: 4 ins; 0 del; 3 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/java/JSWBoxBlurPeer.java

16 lines changed: 3 ins; 8 del; 5 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/java/JSWBoxShadowPeer.java

17 lines changed: 3 ins; 7 del; 7 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/java/JSWEffectPeer.java

2 lines changed: 1 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/java/JSWLinearConvolvePeer.java

54 lines changed: 4 ins; 34 del; 16 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/java/JSWLinearConvolveShadowPeer.java

2 lines changed: 0 ins; 0 del; 2 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/sse/SSEBoxBlurPeer.java

15 lines changed: 2 ins; 7 del; 6 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/sse/SSEBoxShadowPeer.java

16 lines changed: 3 ins; 6 del; 7 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/sse/SSEEffectPeer.java

2 lines changed: 1 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/sse/SSELinearConvolvePeer.java

54 lines changed: 2 ins; 41 del; 11 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/impl/sw/sse/SSELinearConvolveShadowPeer.java

1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/effect/BoxBlur.java

4 lines changed: 0 ins; 0 del; 4 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/effect/Effect.java

2 lines changed: 1 ins; 0 del; 1 mod; 330 unchg

------ ------ ------ ------ Old --- Patch --- modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/LinearConvolvePeer.java

56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/graphics/src/main/java/com/sun/scenario/effect/impl/state/LinearConvolveShadowPeer.java

30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/jsl-decora/CompileLinearConvolve.java

8 lines changed: 1 ins; 0 del; 7 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/java/com/sun/scenario/effect/compiler/JSLC.java

6 lines changed: 2 ins; 0 del; 4 mod; 476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/java/com/sun/scenario/effect/compiler/backend/prism/PrismBackend.java

7 lines changed: 7 ins; 0 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/java/com/sun/scenario/effect/compiler/backend/sw/java/JSWBackend.java

8 lines changed: 7 ins; 0 del; 1 mod; 289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/java/com/sun/scenario/effect/compiler/backend/sw/me/MEBackend.java

7 lines changed: 7 ins; 0 del; 0 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/java/com/sun/scenario/effect/compiler/backend/sw/sse/SSEBackend.java

7 lines changed: 7 ins; 0 del; 0 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/resources/com/sun/scenario/effect/compiler/backend/prism/PrismGlue.stg

2 lines changed: 0 ins; 0 del; 2 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/resources/com/sun/scenario/effect/compiler/backend/sw/java/JSWGlue.stg

3 lines changed: 1 ins; 0 del; 2 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/resources/com/sun/scenario/effect/compiler/backend/sw/me/MEJavaGlue.stg

2 lines changed: 0 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/src/main/resources/com/sun/scenario/effect/compiler/backend/sw/sse/SSEJavaGlue.stg

3 lines changed: 1 ins; 0 del; 2 mod; 101 unchg

This code review page was prepared using /Users/jagraham/Work/bin/webrev.sh (vers 23.10-hg).