Code Review for memo-stage-hotspot

Prepared by:goetz on Mon Dec 2 17:42:10 CET 2013
Workspace:/net/usr.work/d045726/oJ/memo-stage-hotspot
Compare against: http://hg.openjdk.java.net/ppc-aix-port/stage/hotspot
Compare against version:5728
Summary of changes: 100 lines changed: 66 ins; 1 del; 33 mod; 14980 unchg
Changeset: memo-stage-hotspot.changeset
Author comments:
  • Accessing arrays in CMS (compactibleFreeListSpace.cpp)
  • CMS: Do release when marking a card dirty. The release must only be done if GC is running. (several files)
  • method counter initialization (method.hpp)
  • Order accessing f1/f2 in constant pool cache.
  • Release stores in OopMapCache constructor (instanceKLass.cpp).
  • BiasedLocking: Release setting object header to displaced mark.
  • Release state of nmethod sweeper (sweeper.cpp).
  • Do barriers when writing the thread state (thread.hpp).
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
26 lines changed: 26 ins; 0 del; 0 mod; 3015 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
2 lines changed: 1 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
1 line changed: 0 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/barrierSet.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
2 lines changed: 0 ins; 0 del; 2 mod; 185 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/barrierSet.inline.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
3 lines changed: 0 ins; 0 del; 3 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/cardTableModRefBS.cpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
2 lines changed: 0 ins; 0 del; 2 mod; 697 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/cardTableModRefBS.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
8 lines changed: 5 ins; 0 del; 3 mod; 478 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/modRefBarrierSet.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
1 line changed: 0 ins; 0 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/cpCache.cpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
1 line changed: 0 ins; 0 del; 1 mod; 689 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/cpCache.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
14 lines changed: 7 ins; 0 del; 7 mod; 485 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/instanceKlass.cpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
5 lines changed: 4 ins; 0 del; 1 mod; 3681 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/method.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
9 lines changed: 6 ins; 1 del; 2 mod; 1048 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/oop.inline.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
12 lines changed: 8 ins; 0 del; 4 mod; 735 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/biasedLocking.cpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
4 lines changed: 2 ins; 0 del; 2 mod; 771 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/sweeper.cpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
2 lines changed: 1 ins; 0 del; 1 mod; 627 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.hpp 

rev 5729 : 8029396: PPC64 (part 212): Several memory ordering fixes in C-code.
8 lines changed: 6 ins; 0 del; 2 mod; 2016 unchg

This code review page was prepared using /sapmnt/home1/d045726/bin/webrev.ksh (vers 24.0-hg+jbs).