src/share/vm/interpreter/bytecodeInterpreter.cpp

rev 5760 : 8029957: PPC64 (part 213): cppInterpreter: memory ordering for object initialization

*** 2238,2264 ****
--- 2238,2273 ----
                } else {
                  result->set_mark(markOopDesc::prototype());
                }
                result->set_klass_gap(0);
                result->set_klass(k_entry);
+               // Must prevent reordering of stores for object initialization
+               // with stores that publish the new object.
+               OrderAccess::storestore();
                SET_STACK_OBJECT(result, 0);
                UPDATE_PC_AND_TOS_AND_CONTINUE(3, 1);
              }
            }
          }
          // Slow case allocation
          CALL_VM(InterpreterRuntime::_new(THREAD, METHOD->constants(), index),
                  handle_exception);
+         // Must prevent reordering of stores for object initialization
+         // with stores that publish the new object.
+         OrderAccess::storestore();
          SET_STACK_OBJECT(THREAD->vm_result(), 0);
          THREAD->set_vm_result(NULL);
          UPDATE_PC_AND_TOS_AND_CONTINUE(3, 1);
        }
        CASE(_anewarray): {
          u2 index = Bytes::get_Java_u2(pc+1);
          jint size = STACK_INT(-1);
          CALL_VM(InterpreterRuntime::anewarray(THREAD, METHOD->constants(), index, size),
                  handle_exception);
+         // Must prevent reordering of stores for object initialization
+         // with stores that publish the new object.
+         OrderAccess::storestore();
          SET_STACK_OBJECT(THREAD->vm_result(), -1);
          THREAD->set_vm_result(NULL);
          UPDATE_PC_AND_CONTINUE(3);
        }
        CASE(_multianewarray): {
*** 2269,2278 ****
--- 2278,2290 ----
                     (jint*)&topOfStack[dims * Interpreter::stackElementWords+
                                        Interpreter::stackElementWords-1];
          //adjust pointer to start of stack element
          CALL_VM(InterpreterRuntime::multianewarray(THREAD, dimarray),
                  handle_exception);
+         // Must prevent reordering of stores for object initialization
+         // with stores that publish the new object.
+         OrderAccess::storestore();
          SET_STACK_OBJECT(THREAD->vm_result(), -dims);
          THREAD->set_vm_result(NULL);
          UPDATE_PC_AND_TOS_AND_CONTINUE(4, -(dims-1));
        }
        CASE(_checkcast):
*** 2691,2700 ****
--- 2703,2715 ----
        CASE(_newarray): {
          BasicType atype = (BasicType) *(pc+1);
          jint size = STACK_INT(-1);
          CALL_VM(InterpreterRuntime::newarray(THREAD, atype, size),
                  handle_exception);
+         // Must prevent reordering of stores for object initialization
+         // with stores that publish the new object.
+         OrderAccess::storestore();
          SET_STACK_OBJECT(THREAD->vm_result(), -1);
          THREAD->set_vm_result(NULL);
  
          UPDATE_PC_AND_CONTINUE(2);
        }
*** 2924,2933 ****
--- 2939,2954 ----
      // Fall through to handle_return.
  
    } // handle_Early_Return
  
    handle_return: {
+     // A storestore barrier is required to order initialization of
+     // final fields with publishing the reference to the object that
+     // holds the field. Without the barrier the value of final fields
+     // can be observed to change.
+     OrderAccess::storestore();
+ 
      DECACHE_STATE();
  
      bool suppress_error = istate->msg() == popping_frame || istate->msg() == early_return;
      bool suppress_exit_event = THREAD->has_pending_exception() || istate->msg() == popping_frame;
      Handle original_exception(THREAD, THREAD->pending_exception());