Code Review for noWarn-hs-rt

Prepared by:goetz on Mon Mar 3 23:26:35 CET 2014
Workspace:/net/usr.work/d045726/oJ/noWarn-hs-rt
Compare against: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot
Compare against version:6073
Summary of changes: 31 lines changed: 2 ins; 21 del; 8 mod; 8040 unchg
Changeset: noWarn-hs-rt.changeset
Author comments:

Since "8030350: Enable additional compiler warnings for GCC", the hotspot build issues warnings:
src/share/vm/compiler/compilerOracle.cpp: In function 'bool scan_line(const char*, char*, MethodMatcher::Mode*, char*, MethodMatcher::Mode*, int*, const char*&)':
src/share/vm/compiler/compilerOracle.cpp:425: warning: format not a string literal, argument types not checked
src/os/linux/vm/os_linux.cpp: In function 'jlong slow_thread_cpu_time(Thread*, bool)':
src/os/linux/vm/os_linux.cpp:5316: warning: format not a string literal, argument types not checked

Also, older gccs (4.2.2 and before) can not build hotspot any more. They don't know the option introduced in that change:
cc1plus: error: unrecognized command line option "-Wno-error=format-nonliteral"

Fix the warning in the hotspot code and remove the flag from the makefiles.

Compiler Oracle test output.
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/bsd/makefiles/gcc.make 

rev 6074 : 8036122: Fix warning 'format not a string literal'
1 line changed: 0 ins; 0 del; 1 mod; 487 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/linux/makefiles/gcc.make 

rev 6074 : 8036122: Fix warning 'format not a string literal'
1 line changed: 0 ins; 0 del; 1 mod; 410 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/solaris/makefiles/gcc.make 

rev 6074 : 8036122: Fix warning 'format not a string literal'
1 line changed: 0 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/linux/vm/os_linux.cpp 

rev 6074 : 8036122: Fix warning 'format not a string literal'
5 lines changed: 2 ins; 2 del; 1 mod; 6220 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/compiler/compilerOracle.cpp 

rev 6074 : 8036122: Fix warning 'format not a string literal'
23 lines changed: 0 ins; 19 del; 4 mod; 725 unchg

This code review page was prepared using /sapmnt/home1/d045726/bin/webrev.ksh (vers 24.0-hg+jbs).