Code Review for noWarn-hs-rt

Prepared by:goetz on Tue Feb 25 12:30:29 CET 2014
Workspace:/net/usr.work/d045726/oJ/noWarn-hs-rt
Compare against: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot
Summary of changes: 23 lines changed: 8 ins; 8 del; 7 mod; 7367 unchg
Patch of changes: noWarn-hs-rt.patch
Author comments:

Since 8030350: Enable additional compiler warnings for GCC, older gccs can not build hotspot any more.

They don't know the option introduced in that change:
cc1plus: error: unrecognized command line option "-Wno-error=format-nonliteral"

I saw this with gcc 4.1.2 on linuxppc64 and linuxx86_64, and with gcc 3.3.3 on linuxx86_64. Gcc 4.3.4 works.

Fix this by either adapting hotspot code not to issue these warnings (two places in the code must be adapted), or by adding -Xno-format-nonliteral for older gccs.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/linux/makefiles/gcc.make

1 line changed: 0 ins; 0 del; 1 mod; 410 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/linux/vm/os_linux.cpp

6 lines changed: 3 ins; 2 del; 1 mod; 6220 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compilerOracle.cpp

16 lines changed: 5 ins; 6 del; 5 mod; 737 unchg

This code review page was prepared using /sapmnt/home1/d045726/bin/webrev.ksh (vers 24.0-hg+jbs).