Code Review for oa-hs-rt

Prepared by:goetz on Tue Apr 29 15:33:54 CEST 2014
Workspace:/net/usr.work/d045726/oJ/oa-hs-rt
Compare against: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot
Compare against version:6351
Summary of changes: 418 lines changed: 177 ins; 222 del; 19 mod; 128914 unchg
Changeset: oa-hs-rt.changeset
Author comments:

This change introduces an umbrella header for orderAccess_<os>_<cpu>.inline.hpp files: runtime/orderAccess.inline.hpp. This follows the scheme applied to atomic.inline.hpp.

Further this change adds includes of orderAccess.inline.hpp in all .cpp and .inline.hpp files where a method of OrderAccess declared 'inline' is called.

Finally it moves methods calling inline methods of OrderAccess from g1CollectedHeap.hpp and thread.hpp to the corresponding .inline.hpp files and adds the necessary includes in files using the moved functions.

Still a lot of calls to inline methods of OrderAccess in .hpp files arn't preceded by an according include. But for these files an appropriate .inline.hpp file is missing:

src/cpu/ppc/vm/javaFrameAnchor_ppc.hpp
src/cpu/sparc/vm/javaFrameAnchor_sparc.hpp
src/share/vm/classfile/classLoader.hpp
src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp
src/share/vm/memory/cardTableModRefBS.hpp
src/share/vm/oops/constantPool.hpp
src/share/vm/oops/cpCache.hpp
src/share/vm/oops/instanceKlass.hpp
src/share/vm/oops/method.hpp
src/share/vm/oops/methodData.hpp
src/share/vm/oops/typeArrayOop.hpp
src/share/vm/runtime/interfaceSupport.hpp
src/share/vm/utilities/array.hpp
src/share/vm/utilities/taskqueue.hpp

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/cpu/zero/vm/cppInterpreter_zero.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1063 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/aix/vm/os_aix.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 5112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/aix/vm/os_aix.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
6 lines changed: 1 ins; 4 del; 1 mod; 287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/aix/vm/thread_aix.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
3 lines changed: 0 ins; 3 del; 0 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/bsd/vm/os_bsd.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 4709 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/bsd/vm/os_bsd.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
8 lines changed: 1 ins; 7 del; 0 mod; 290 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/bsd/vm/thread_bsd.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
6 lines changed: 0 ins; 6 del; 0 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/linux/vm/os_linux.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 6210 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/linux/vm/os_linux.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
17 lines changed: 1 ins; 16 del; 0 mod; 279 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/linux/vm/thread_linux.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
11 lines changed: 0 ins; 11 del; 0 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/solaris/vm/os_solaris.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 6038 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/solaris/vm/os_solaris.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
8 lines changed: 1 ins; 7 del; 0 mod; 165 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/solaris/vm/thread_solaris.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
5 lines changed: 0 ins; 4 del; 1 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/windows/vm/os_windows.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 5784 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/windows/vm/os_windows.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
5 lines changed: 1 ins; 4 del; 0 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/windows/vm/thread_windows.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
4 lines changed: 1 ins; 2 del; 1 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os_cpu/aix_ppc/vm/atomic_aix_ppc.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 1 del; 0 mod; 400 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os_cpu/linux_ppc/vm/atomic_linux_ppc.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 1 del; 0 mod; 400 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/ci/ciEnv.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/dictionary.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 721 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/systemDictionary.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 2802 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/verifier.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 0 del; 1 mod; 2739 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/code/dependencies.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1748 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/code/nmethod.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 2946 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 3013 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 9561 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1AllocRegion.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 228 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 6913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
11 lines changed: 0 ins; 9 del; 2 mod; 1946 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
14 lines changed: 14 ins; 0 del; 0 mod; 363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 197 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/heapRegion.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 481 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parNew/parNewGeneration.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 0 del; 1 mod; 1643 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1142 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/interpreter/bytecodeInterpreter.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
35 lines changed: 1 ins; 34 del; 0 mod; 3458 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/gcLocker.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/metaspace.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 3789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/space.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 867 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/cpCache.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 690 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/instanceKlass.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 3688 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/klass.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
2 lines changed: 1 ins; 0 del; 1 mod; 709 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/method.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 2022 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/methodData.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1657 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/objArrayKlass.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 692 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/oop.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
2 lines changed: 1 ins; 0 del; 1 mod; 747 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/typeArrayKlass.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 393 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/typeArrayOop.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
33 lines changed: 0 ins; 32 del; 1 mod; 168 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/precompiled/precompiled.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 325 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/forte.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 0 del; 1 mod; 650 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jni.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 4364 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jniCheck.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 0 del; 1 mod; 2131 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvm.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 4396 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiEnvBase.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1475 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiExport.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 0 del; 1 mod; 2484 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiRawMonitor.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
2 lines changed: 1 ins; 0 del; 1 mod; 421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiThreadState.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/unsafe.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1742 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/fprofiler.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1616 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/interfaceSupport.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/javaFrameAnchor.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
34 lines changed: 1 ins; 33 del; 0 mod; 109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/mutex.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1378 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/objectMonitor.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 2512 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/perfMemory.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 265 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/safepoint.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 1379 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/sweeper.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
2 lines changed: 2 ins; 0 del; 0 mod; 659 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 4637 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
19 lines changed: 0 ins; 15 del; 4 mod; 2008 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
28 lines changed: 28 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/management.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 2382 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/memTracker.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 883 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/memoryManager.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 321 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/memoryPool.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 289 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/threadService.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 974 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/hashtable.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 1 ins; 0 del; 0 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/taskqueue.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
34 lines changed: 1 ins; 33 del; 0 mod; 798 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/vmError.cpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
1 line changed: 0 ins; 0 del; 1 mod; 1141 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/share/vm/runtime/orderAccess.inline.hpp 

rev 6352 : Introduce umbrella header orderAccess.inline.hpp
74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /sapmnt/home1/d045726/bin/webrev.ksh (vers 24.0-hg+jbs).