Code Review for main-hotspot-stubs

Prepared by:Goetz Lindenmaier on Mon Sep 24 15:58:00 CEST 2012
Workspace:/net/usr.work/d045726/oJ/8/main-hotspot-stubs
Compare against: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot
Compare against version:3638
Summary of changes: 82 lines changed: 40 ins; 9 del; 33 mod; 11193 unchg
Patch of changes: main-hotspot-stubs.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/asm/codeBuffer.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
30 lines changed: 14 ins; 8 del; 8 mod; 1122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/asm/codeBuffer.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
1 line changed: 0 ins; 0 del; 1 mod; 597 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeBlob.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
4 lines changed: 4 ins; 0 del; 0 mod; 577 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeBlob.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
1 line changed: 0 ins; 0 del; 1 mod; 506 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/icBuffer.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
3 lines changed: 2 ins; 0 del; 1 mod; 142 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
1 line changed: 0 ins; 0 del; 1 mod; 2921 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
2 lines changed: 0 ins; 0 del; 2 mod; 743 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/stubs.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
8 lines changed: 3 ins; 0 del; 5 mod; 255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/stubs.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
11 lines changed: 6 ins; 0 del; 5 mod; 222 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/disassembler.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
8 lines changed: 3 ins; 1 del; 4 mod; 515 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/disassembler.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
2 lines changed: 1 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/interpreter.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
3 lines changed: 2 ins; 0 del; 1 mod; 463 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/interpreter.hpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
4 lines changed: 2 ins; 0 del; 2 mod; 162 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.cpp

rev 3639 : Implement printing CodeComments in stubs.

The interpreter contains various long assembly code parts which
are stored as stubs.  The output of +PrintInterpreter is unstructured
und thus not easy to read. This can be improved with CodeComments
of the MacroAssembler. So far they were lost when the code is turned
into a Stub, while they were kept if the code is copied to a CodeBlob.
Implemented storing the CodeComments in stubs and added support to
pass them to the disasembler.
Also added some ttyLocks and 
 to format output.
4 lines changed: 3 ins; 0 del; 1 mod; 2876 unchg

This code review page was prepared using /usr/local/bin/webrev.ksh (vers 23.18-hg).