Code Review for hotspot

Prepared by:goetz on Wed May 4 09:24:06 CEST 2016
Workspace:/net/usr.work/d045726/oJ/8140594-covCo-hs-comp/hotspot
Compare against: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot
Compare against version:10978
Summary of changes: 87 lines changed: 20 ins; 8 del; 59 mod; 50071 unchg
Changeset: hotspot.changeset
Author comments:
os_linux.cpp

- Buffer not null terminated

- size of pointer passed to jio_snprintf()

os_linux_x86.cpp

- wrong size passed, scaled automatically by C compiler.

dfa.cpp/formssel./cpp

- no real issues as this is a tool, but nevertheless...

c1_Instruction.hpp

- uninitialized field.

c1_LinearScan.cpp

- Access with negative index if called with any_reg

- Coverity doesn't grok that two calls to base_counter(i) result in same value.

ciMethodBlocks.cpp

- Out of bounds access

classFileParser.cpp

- Don't access array at BAD_ALLOCATION_TYPE, oob.

- CHECK macro results in two statements, second is not in if body.

classLoader.cpp

- jio_snprintf does null termination. But it might return -1 if truncated, in this case array access at -1.

systemDictionary.cpp

- avoid %s in message text.

compileBroker.cpp

_last_method_compiled is an array, not a pointer.

compileLog.cpp

- buffer not null terminated

disassembler.cpp

- lib_offset might be -1.

logTagSet.cpp

- possible buffer overrun

constantPool.cpp

- flagts not initialized

generateOopMap.cpp

- Remaining fields not initialized.

block.cpp

- assertion assigns instead of comparing.

callnode.cpp

_bci not initialized.

graphKit.cpp

- assertion assings instead of comparing

matcher.cpp

- find_receiver might return any_reg

relocator.cpp

- delta might be -4 ... assert returns.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os/linux/vm/os_linux.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
4 lines changed: 1 ins; 0 del; 3 mod; 6220 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os_cpu/linux_x86/vm/os_linux_x86.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
1 line changed: 0 ins; 0 del; 1 mod; 944 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/adlc/dfa.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
23 lines changed: 0 ins; 5 del; 18 mod; 1018 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/adlc/formssel.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
7 lines changed: 1 ins; 0 del; 6 mod; 4269 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/c1/c1_LinearScan.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
5 lines changed: 2 ins; 0 del; 3 mod; 6775 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/ci/ciMethodBlocks.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
1 line changed: 0 ins; 0 del; 1 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/classFileParser.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
7 lines changed: 3 ins; 0 del; 4 mod; 5901 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/classLoader.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
4 lines changed: 0 ins; 2 del; 2 mod; 1740 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/systemDictionary.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
3 lines changed: 0 ins; 0 del; 3 mod; 2912 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/compiler/compileBroker.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
4 lines changed: 0 ins; 1 del; 3 mod; 2404 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/compiler/compileLog.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
2 lines changed: 1 ins; 0 del; 1 mod; 344 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/compiler/disassembler.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
3 lines changed: 0 ins; 0 del; 3 mod; 592 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/logging/logTagSet.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
7 lines changed: 5 ins; 0 del; 2 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/constantPool.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
2 lines changed: 1 ins; 0 del; 1 mod; 2083 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/generateOopMap.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
3 lines changed: 2 ins; 0 del; 1 mod; 2573 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/block.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
1 line changed: 0 ins; 0 del; 1 mod; 1777 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callnode.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
1 line changed: 1 ins; 0 del; 0 mod; 2040 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
1 line changed: 0 ins; 0 del; 1 mod; 4492 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/matcher.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
6 lines changed: 3 ins; 0 del; 3 mod; 2691 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/relocator.cpp 

rev 10979 : 8140594: Various minor code improvements (compiler)
2 lines changed: 0 ins; 0 del; 2 mod; 776 unchg

This code review page was prepared using /sapmnt/home/d045726/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).